From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6816198A0C for ; Mon, 17 Jun 2024 18:48:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718650087; cv=none; b=OcqdCqIyLbqndjSw3uAdC0LPmbcZXXBjQ4/03eK4PoA/EB6PBJPr1Tx910iWfeG3Lu1lVMJrDOZWRSw0e83XkgwHboQ6oJRcSP/Myc9EW7FOcWf42Ubi27IMxdn1toYOMUFl35OGFhF378bmkxOJNIIbBZPc5UupWm6bZksBX0s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718650087; c=relaxed/simple; bh=qeXF72FR93AGBhELVsrcMvphwThBusQ84oeb1Yd3e+Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ueiqBl3IWZNP0MCYNVs3qgZBtgCnblvBV1LwR/5EOQP5Jz6SfQ6XKuzbVEt59bT8FKZE2KBK9aSL4kXt8CZ2EmSY5zKUYNu093U869d+fNEBNuuwDcWREEjUz29YCilXbk5S9gGSQiUwI2bddcB/msQxdmm6taIR/Orm2ew19sI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GFXCBaEv; arc=none smtp.client-ip=209.85.208.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GFXCBaEv" Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2ebe3bac6c6so52086771fa.1 for ; Mon, 17 Jun 2024 11:48:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718650080; x=1719254880; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FYnJ6sKcKYDve5AuIpVcAVHdyyVXD2FX+mVnM7OJR7o=; b=GFXCBaEvpWYuexpHYbZHfxU1Y9zIonEfVTjaf9SMdDZ+xXfIQOWOBhyjv3vfyAZKUV Ftt+GongLM4rUJknxRAY/UK++DxaRsP45LikX8EUWpHUhgGYJpt3iJWulJai0DhGlGpD gWgd0Wc3+QE3yIAs9PUV+pHmrhLViYOuwvioyipCBwyOoyY6LgdweCc+07yU6bUp1hKx 3+UW9IHKbwMRQcsx86gSY/nWhiGRM6tlxcbJmk2nQ5ing02kIUS+DOUHQNTXnlejyrLc iK3f40pUr5VknDsQRj9Q3u12s6DmzZ01J0CN/swDM7I7f5Rw3x5qMOHWPVMXZBlo5H1y 2RiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718650080; x=1719254880; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FYnJ6sKcKYDve5AuIpVcAVHdyyVXD2FX+mVnM7OJR7o=; b=TxRiSvgJJBHcTRVPydv3Xekmn37MlKT8tvFnfxen0fJTY8IrRpX+hHc83dr6FmEbZU i5dReexIpQUS3OQNr/yuFcxsnImAa0U/vXROFc23X9Vt3xe/QEIIMwKO883R69UNxdNd c7yR1cJGkfCrR9h5G7oyWzPxSyBD+uomd5iO1b0AqkJhU0w7KcwkJo5oA+jVFjpKXKM3 cDLNSYuEUEdEXBoVG1JqLdRLvLMAxzutjkJO4csbjAL/3teNCLHp/Ck5UbIKcPifvyLG NOoAFF+V1pQtFTFyryWjg2TI2OLyx4EyQG5jI3hcycEjLHCrHgxvppq3zYShQfzbnfk6 mxyQ== X-Forwarded-Encrypted: i=1; AJvYcCUfBb6Q9MkQqjeXxvt/AqP09EhSh1jUwWCvLUT1ay8FDWFS3vRQlGyIKWTEVMVZ++m36WLVrVAMmmVBkywPUmsHRZwFGp/a8y7gEbo0 X-Gm-Message-State: AOJu0Yx/VB1MlYJ7+nw73eLlALdWW9+/rpHmsG/ka3cMeGCh54KIWhZh Gnvtrghu/byfmfjT4EkTRbc8gS9rjoUTainPT7BwmHPGKMnNOwLvt2lQYjo5lDY= X-Google-Smtp-Source: AGHT+IGx+atBJRdGHE+dU/qVvXUgXHTjfuz4zdzX/PqP8kUgeQ1LM6w0fr0vL2L6wwQuaZMSeOstFQ== X-Received: by 2002:a2e:8895:0:b0:2eb:ea4a:9923 with SMTP id 38308e7fff4ca-2ec0e5d1415mr83982231fa.23.1718650078858; Mon, 17 Jun 2024 11:47:58 -0700 (PDT) Received: from ?IPV6:2a00:f41:cb2:a9df:9f88:17b:c7e7:fa59? ([2a00:f41:cb2:a9df:9f88:17b:c7e7:fa59]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ec05c17d72sm14085621fa.68.2024.06.17.11.47.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jun 2024 11:47:58 -0700 (PDT) Message-ID: <65f248a7-43bb-4f97-ad98-e2ca29e99e51@linaro.org> Date: Mon, 17 Jun 2024 20:47:56 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/8] serial: qcom-geni: Fix arg types for qcom_geni_serial_poll_bit() To: Douglas Anderson , Greg Kroah-Hartman , Jiri Slaby Cc: Yicong Yang , Tony Lindgren , Andy Shevchenko , Johan Hovold , John Ogness , linux-arm-msm@vger.kernel.org, Bjorn Andersson , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Stephen Boyd , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Vijaya Krishna Nivarthi References: <20240610222515.3023730-1-dianders@chromium.org> <20240610152420.v4.4.I24a0de52dd7336908df180fa6b698e001f3aff82@changeid> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20240610152420.v4.4.I24a0de52dd7336908df180fa6b698e001f3aff82@changeid> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/11/24 00:24, Douglas Anderson wrote: > The "offset" passed in should be unsigned since it's always a positive > offset from our memory mapped IO. > > The "field" should be u32 since we're anding it with a 32-bit value > read from the device. > > Suggested-by: Stephen Boyd > Signed-off-by: Douglas Anderson > --- Reviewed-by: Konrad Dybcio Konrad