From: Arjan van de Ven <arjan@linux.intel.com>
To: John Stultz <john.stultz@linaro.org>, Kees Cook <keescook@chromium.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Oren Laadan <orenl@cellrox.com>,
Ruchi Kandoi <kandoiruchi@google.com>,
Rom Lemarchand <romlem@android.com>, Todd Kjos <tkjos@google.com>,
Colin Cross <ccross@android.com>, Nick Kralevich <nnk@google.com>,
Dmitry Shmidt <dimitrysh@google.com>,
Elliott Hughes <enh@google.com>,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH] proc: Fix timerslack_ns CAP_SYS_NICE check when adjusting self
Date: Wed, 10 Aug 2016 13:01:04 -0700 [thread overview]
Message-ID: <65f33d6c-4e51-d659-b6c6-f2eac65c65af@linux.intel.com> (raw)
In-Reply-To: <CALAqxLV6P8U0nVZrsyWSEX+duL7fHt298gm1wHo-Qi5CFAH1_A@mail.gmail.com>
On 8/10/2016 12:03 PM, John Stultz wrote:
> I wasn't entierly sure. I didn't think PR_SET_TIMERSLACK has a
> security hook, but looking again I now see the top-level
> security_task_prctl() check, so maybe not skipping it in this case
> would be good?
the easy fix would be to add back the ptrace check.. just either ptrace-able OR CAP_SYS_NICE ;)
then you can prove you only added new stuff as well, and have all the LSM from before
next prev parent reply other threads:[~2016-08-10 20:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 23:54 [PATCH] proc: Fix timerslack_ns CAP_SYS_NICE check when adjusting self John Stultz
2016-08-10 18:36 ` Kees Cook
2016-08-10 19:03 ` John Stultz
2016-08-10 19:13 ` John Stultz
2016-08-10 20:01 ` Arjan van de Ven [this message]
2016-08-10 20:45 ` John Stultz
2016-08-10 21:02 ` Kees Cook
2016-08-10 21:12 ` John Stultz
2016-08-10 21:22 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65f33d6c-4e51-d659-b6c6-f2eac65c65af@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=ccross@android.com \
--cc=dimitrysh@google.com \
--cc=enh@google.com \
--cc=john.stultz@linaro.org \
--cc=kandoiruchi@google.com \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nnk@google.com \
--cc=orenl@cellrox.com \
--cc=romlem@android.com \
--cc=serge@hallyn.com \
--cc=tglx@linutronix.de \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox