From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C471C3F68F for ; Mon, 20 Jan 2020 07:15:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4900207FD for ; Mon, 20 Jan 2020 07:15:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726573AbgATHPG (ORCPT ); Mon, 20 Jan 2020 02:15:06 -0500 Received: from mga04.intel.com ([192.55.52.120]:10941 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725851AbgATHPF (ORCPT ); Mon, 20 Jan 2020 02:15:05 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jan 2020 23:15:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,341,1574150400"; d="scan'208";a="274939706" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.167]) ([10.237.72.167]) by FMSMGA003.fm.intel.com with ESMTP; 19 Jan 2020 23:15:03 -0800 Subject: Re: [PATCH v2] mmc: sdhci: fix an issue of mixing different types To: Chunyan Zhang , Ulf Hansson Cc: Faiz Abbas , Nathan Chancellor , Chunyan Zhang , linux-mmc@vger.kernel.org, clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org, kbuild test robot References: <20200120031023.32482-1-zhang.chunyan@linaro.org> <20200120033223.897-1-zhang.chunyan@linaro.org> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <65f7272c-ecea-03de-433b-21ba2e672d20@intel.com> Date: Mon, 20 Jan 2020 09:14:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200120033223.897-1-zhang.chunyan@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/01/20 5:32 am, Chunyan Zhang wrote: > Fix an issue reported by sparse, since mixed types of parameters are > used on calling dmaengine_prep_slave_sg(). > > Fixes: 36e1da441fec (mmc: sdhci: add support for using external DMA devices) That commit number is only in next > Reported-by: kbuild test robot > Signed-off-by: Chunyan Zhang > Reviewed-by: Nathan Chancellor Acked-by: Adrian Hunter > --- > Changes from v1: > * address comments from Nathan Chancellor > - define a new variable to avoid type conversions. > --- > drivers/mmc/host/sdhci.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index 30b5a624b50e..f9e0b5f2c692 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -1201,6 +1201,7 @@ static int sdhci_external_dma_setup(struct sdhci_host *host, > struct mmc_command *cmd) > { > int ret, i; > + enum dma_transfer_direction dir; > struct dma_async_tx_descriptor *desc; > struct mmc_data *data = cmd->data; > struct dma_chan *chan; > @@ -1234,8 +1235,8 @@ static int sdhci_external_dma_setup(struct sdhci_host *host, > if (sg_cnt <= 0) > return -EINVAL; > > - desc = dmaengine_prep_slave_sg(chan, data->sg, data->sg_len, > - mmc_get_dma_dir(data), > + dir = data->flags & MMC_DATA_WRITE ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM; > + desc = dmaengine_prep_slave_sg(chan, data->sg, data->sg_len, dir, > DMA_PREP_INTERRUPT | DMA_CTRL_ACK); > if (!desc) > return -EINVAL; >