From: Andy Whitcroft <apw@shadowen.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@xenotime.net>,
Andrew Morton <akpm@osdl.org>, Andy Whitcroft <apw@shadowen.org>,
Andy Whitcroft <apw@shadowen.org>,
Roland Dreier <rolandd@cisco.com>,
Sean Hefty <mshefty@ichips.intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
general@lists.openfabrics.org
Subject: [PATCH 4/6] infiniband: mlx4_MAD_IFC copies out response unconditionally
Date: Thu, 16 Aug 2007 14:19:01 +0100 [thread overview]
Message-ID: <65fd31510014453ccd0a99a20c83deb5@pinky> (raw)
In-Reply-To: exportbomb.1187270320@pinky
It seems a trailing ';' has slipped into mlx4_MAD_IFC() which causes
the response to be copied out unconditionally.
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Cc: Roland Dreier <rolandd@cisco.com>
Cc: Sean Hefty <mshefty@ichips.intel.com>
Cc: Hal Rosenstock <hal.rosenstock@gmail.com>
Cc: general@lists.openfabrics.org
---
drivers/infiniband/hw/mlx4/mad.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c
index 3330917..0ed02b7 100644
--- a/drivers/infiniband/hw/mlx4/mad.c
+++ b/drivers/infiniband/hw/mlx4/mad.c
@@ -109,7 +109,7 @@ int mlx4_MAD_IFC(struct mlx4_ib_dev *dev, int ignore_mkey, int ignore_bkey,
in_modifier, op_modifier,
MLX4_CMD_MAD_IFC, MLX4_CMD_TIME_CLASS_C);
- if (!err);
+ if (!err)
memcpy(response_mad, outmailbox->buf, 256);
mlx4_free_cmd_mailbox(dev->dev, inmailbox);
next prev parent reply other threads:[~2007-08-16 13:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-15 23:58 drivers/infiniband/mlx/mad.c misplaced ; Dave Jones
2007-08-16 0:40 ` Joe Perches
2007-08-16 2:19 ` Kok, Auke
2007-08-16 3:17 ` Joe Perches
2007-08-16 4:20 ` Kok, Auke
2007-08-16 10:21 ` [netfilter-core] " Patrick McHardy
2007-08-16 14:05 ` Andy Whitcroft
2007-08-16 8:46 ` Heiko Carstens
2007-08-16 10:22 ` Ilpo Järvinen
2007-08-16 11:01 ` Karsten Keil
2007-08-18 15:14 ` Daniel Schaffrath
2007-08-16 12:41 ` Satyam Sharma
2007-08-16 14:52 ` Jeff Dike
2007-08-17 6:54 ` [PATCH] hostfs: Remove pointless if statement Satyam Sharma
2007-08-17 13:54 ` Jeff Dike
2007-08-16 16:19 ` drivers/infiniband/mlx/mad.c misplaced ; Paul Mundt
2007-08-16 3:39 ` Roland Dreier
2007-08-16 13:18 ` [PATCH 0/6] checkpatch checks for trailing semicolons on conditionals Andy Whitcroft
2007-08-16 13:18 ` [PATCH 1/6] mips: irix_getcontext will always fail EFAULT Andy Whitcroft
2007-08-22 22:35 ` Ralf Baechle
2007-08-16 13:18 ` [PATCH 2/6] powerpc: hash_preload fails to preload under CONFIG_PPC_MM_SLICES Andy Whitcroft
2007-08-16 13:18 ` [PATCH 3/6] sh: remove extraneous ; on scif_sercon_putc wait loop Andy Whitcroft
2007-08-16 16:27 ` Paul Mundt
2007-08-16 13:19 ` Andy Whitcroft [this message]
2007-08-16 15:01 ` [PATCH 4/6] infiniband: mlx4_MAD_IFC copies out response unconditionally Roland Dreier
2007-08-16 13:19 ` [PATCH 5/6] irda_nl_get_mode: always results in failure Andy Whitcroft
2007-08-16 13:19 ` [PATCH 6/6] netfilter: xt_u32: fix length checks in u32_match_it Andy Whitcroft
2007-08-16 14:32 ` Patrick McHardy
2007-08-16 14:21 ` [PATCH 0/6] checkpatch checks for trailing semicolons on conditionals Satyam Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65fd31510014453ccd0a99a20c83deb5@pinky \
--to=apw@shadowen.org \
--cc=akpm@osdl.org \
--cc=general@lists.openfabrics.org \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mshefty@ichips.intel.com \
--cc=rdunlap@xenotime.net \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox