From: Jacob Keller <jacob.e.keller@intel.com>
To: Johnny Park <pjohnny0508@gmail.com>, Jakub Kicinski <kuba@kernel.org>
Cc: <anthony.l.nguyen@intel.com>, <przemyslaw.kitszel@intel.com>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH] igb: Fix styling in enable/disable SR-IOV
Date: Wed, 16 Oct 2024 15:54:39 -0700 [thread overview]
Message-ID: <6611b169-e071-4b12-a7ab-337fa1cbe314@intel.com> (raw)
In-Reply-To: <Zw866aMO9sfBXRsm@Fantasy-Ubuntu>
On 10/15/2024 9:02 PM, Johnny Park wrote:
> On Tue, Oct 15, 2024 at 05:46:07PM -0700, Jakub Kicinski wrote:
>> On Mon, 14 Oct 2024 17:16:29 -0600 Johnny Park wrote:
>>> This patch fixes the checks and warnings for igb_enable_sriov and
>>> igb_disable_sriov function reported by checkpatch.pl
>>
>> Quoting documentation:
>>
>> Clean-up patches
>> ~~~~~~~~~~~~~~~~
>>
>> Netdev discourages patches which perform simple clean-ups, which are not in
>> the context of other work. For example:
>>
>> * Addressing ``checkpatch.pl`` warnings
>> * Addressing :ref:`Local variable ordering<rcs>` issues
>> * Conversions to device-managed APIs (``devm_`` helpers)
>>
>> This is because it is felt that the churn that such changes produce comes
>> at a greater cost than the value of such clean-ups.
>>
>> Conversely, spelling and grammar fixes are not discouraged.
>>
>> See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
> I see. Apologies for the inconvenience, I'm new to this area so I must have missed that portion of documentation.
You likely missed this because its a recent addition to the docs by
commit aeb218d900e3 ("docs: netdev: document guidance on cleanup
patches") from a week ago.
The policy itself is older than this, but we've had a recent surge in
similar changes on a few drivers.
prev parent reply other threads:[~2024-10-16 22:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 23:16 [PATCH] igb: Fix styling in enable/disable SR-IOV Johnny Park
2024-10-16 0:46 ` Jakub Kicinski
2024-10-16 4:02 ` Johnny Park
2024-10-16 22:54 ` Jacob Keller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6611b169-e071-4b12-a7ab-337fa1cbe314@intel.com \
--to=jacob.e.keller@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pjohnny0508@gmail.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox