From: David Howells <dhowells@redhat.com>
To: Yang Song <songyang@linux.alibaba.com>
Cc: dhowells@redhat.com, dwmw2@infradead.org,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
zhang.jia@linux.alibaba.com, tianjia.zhang@linux.alibaba.com
Subject: Re: [PATCH] sign-file: add openssl engine support
Date: Wed, 10 Feb 2021 08:29:44 +0000 [thread overview]
Message-ID: <664916.1612945784@warthog.procyon.org.uk> (raw)
In-Reply-To: <20210210074554.81100-1-songyang@linux.alibaba.com>
Yang Song <songyang@linux.alibaba.com> wrote:
> + "Usage: scripts/sign-file [-edp] [<openssl engine>] <hash algo> <key> <x509> <module> [<dest>]\n");
Do you mean:
"Usage: scripts/sign-file [-dp] [-e <openssl engine>] <hash algo> <key> <x509> <module> [<dest>]\n");
> + opt = getopt(argc, argv, "sedpk");
"se:dpk"?
> + if (use_engine) {
> + ossl_engine = argv[0];
use_engine ought to be a redundant variable.
David
prev parent reply other threads:[~2021-02-10 8:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 7:45 [PATCH] sign-file: add openssl engine support Yang Song
2021-02-10 8:01 ` David Woodhouse
2021-02-10 14:59 ` James Bottomley
2021-02-10 8:29 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=664916.1612945784@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=songyang@linux.alibaba.com \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=zhang.jia@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox