* [PATCH REPOST net-next 2/2] r8152: Wake up the system if the we need a reset
[not found] <20240530164304.REPOST net-next.1.Ibeda5c0772812ce18953150da5a0888d2d875150@changeid>
@ 2024-05-30 23:43 ` Douglas Anderson
2024-06-03 6:39 ` Hayes Wang
0 siblings, 1 reply; 2+ messages in thread
From: Douglas Anderson @ 2024-05-30 23:43 UTC (permalink / raw)
To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Hayes Wang
Cc: danielgeorgem, Douglas Anderson, Andrew Lunn, Grant Grundler,
Heiner Kallweit, linux-kernel, linux-usb, netdev
If we get to the end of the r8152's suspend() routine and we find that
the USB device is INACCESSIBLE then it means that some of our
preparation for suspend didn't take place. We need a USB reset to get
ourselves back in a consistent state so we can try again and that
can't happen during system suspend. Call pm_wakeup_event() to wake the
system up in this case.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/net/usb/r8152.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 6a3f4b2114ee..09fe70bc45d4 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -8647,6 +8647,13 @@ static int rtl8152_system_suspend(struct r8152 *tp)
tasklet_enable(&tp->tx_tl);
}
+ /* If we're inaccessible here then some of the work that we did to
+ * get the adapter ready for suspend didn't work. Queue up a wakeup
+ * event so we can try again.
+ */
+ if (test_bit(RTL8152_INACCESSIBLE, &tp->flags))
+ pm_wakeup_event(&tp->udev->dev, 0);
+
return 0;
}
--
2.45.1.288.g0e0cd299f1-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH REPOST net-next 2/2] r8152: Wake up the system if the we need a reset
2024-05-30 23:43 ` [PATCH REPOST net-next 2/2] r8152: Wake up the system if the we need a reset Douglas Anderson
@ 2024-06-03 6:39 ` Hayes Wang
0 siblings, 0 replies; 2+ messages in thread
From: Hayes Wang @ 2024-06-03 6:39 UTC (permalink / raw)
To: Douglas Anderson, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: danielgeorgem@google.com, Andrew Lunn, Grant Grundler,
Heiner Kallweit, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Douglas Anderson <dianders@chromium.org>
> Sent: Friday, May 31, 2024 7:43 AM
[...]
> If we get to the end of the r8152's suspend() routine and we find that
> the USB device is INACCESSIBLE then it means that some of our
> preparation for suspend didn't take place. We need a USB reset to get
> ourselves back in a consistent state so we can try again and that
> can't happen during system suspend. Call pm_wakeup_event() to wake the
> system up in this case.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Hayes Wang <hayeswang@realtek.com>
Best Regards,
Hayes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-03 6:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240530164304.REPOST net-next.1.Ibeda5c0772812ce18953150da5a0888d2d875150@changeid>
2024-05-30 23:43 ` [PATCH REPOST net-next 2/2] r8152: Wake up the system if the we need a reset Douglas Anderson
2024-06-03 6:39 ` Hayes Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox