public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [Linux-cachefs] Variable fscache_cache_cleared_wq undefined!
       [not found] <afedd41c-8445-af8d-3ea5-841f8c557e58@marian1000.go.ro>
@ 2017-04-06 14:03 ` David Howells
  0 siblings, 0 replies; only message in thread
From: David Howells @ 2017-04-06 14:03 UTC (permalink / raw)
  To: Corcodel Marian; +Cc: dhowells, linux-cachefs, linux-kernel

Corcodel Marian <asd@marian1000.go.ro> wrote:

> Hi on function fscache_object_destroyed may run with variable undefined when
> in not set CONFIG_FSCACHE
> 
> +void fscache_object_destroyed(struct fscache_cache *cache)
> +{
> +#ifdef CONFIG_FSCACHE
> +       if (atomic_dec_and_test(&cache->object_count))
> +               wake_up_all(&fscache_cache_cleared_wq);
> +#endif
> }

No one should be including linux/fscache-cache.h from code that's built when
CONFIG_FSCACHE is disabled.

David

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-04-06 14:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <afedd41c-8445-af8d-3ea5-841f8c557e58@marian1000.go.ro>
2017-04-06 14:03 ` [Linux-cachefs] Variable fscache_cache_cleared_wq undefined! David Howells

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox