From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935108AbdDFOEF (ORCPT <rfc822;w@1wt.eu>);
        Thu, 6 Apr 2017 10:04:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60982 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S934956AbdDFODs (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 6 Apr 2017 10:03:48 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6A7AF6AAC9
Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dhowells@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 6A7AF6AAC9
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <afedd41c-8445-af8d-3ea5-841f8c557e58@marian1000.go.ro>
References: <afedd41c-8445-af8d-3ea5-841f8c557e58@marian1000.go.ro>
To: Corcodel Marian <asd@marian1000.go.ro>
Cc: dhowells@redhat.com, linux-cachefs@redhat.com,
        linux-kernel@vger.kernel.org
Subject: Re: [Linux-cachefs] Variable fscache_cache_cleared_wq undefined!
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6662.1491487422.1@warthog.procyon.org.uk>
Date: Thu, 06 Apr 2017 15:03:42 +0100
Message-ID: <6663.1491487422@warthog.procyon.org.uk>
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 06 Apr 2017 14:03:47 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Corcodel Marian <asd@marian1000.go.ro> wrote:

> Hi on function fscache_object_destroyed may run with variable undefined when
> in not set CONFIG_FSCACHE
> 
> +void fscache_object_destroyed(struct fscache_cache *cache)
> +{
> +#ifdef CONFIG_FSCACHE
> +       if (atomic_dec_and_test(&cache->object_count))
> +               wake_up_all(&fscache_cache_cleared_wq);
> +#endif
> }

No one should be including linux/fscache-cache.h from code that's built when
CONFIG_FSCACHE is disabled.

David