Re: [Linux-cachefs] Variable fscache_cache_cleared_wq undefined!

David Howells
2017-04-06T14:04:05Z

Corcodel Marian <asd@marian1000.go.ro> wrote:

> Hi on function fscache_object_destroyed may run with variable undefined when
> in not set CONFIG_FSCACHE
>
> +void fscache_object_destroyed(struct fscache_cache *cache)
> +{
> +#ifdef CONFIG_FSCACHE
> + if (atomic_dec_and_test(&cache->object_count))
> + wake_up_all(&fscache_cache_cleared_wq);
> +#endif
> }

No one should be including linux/fscache-cache.h from code that's built when
CONFIG_FSCACHE is disabled.

David