From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64ECCC433F5 for ; Fri, 18 Mar 2022 14:49:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237658AbiCROun (ORCPT ); Fri, 18 Mar 2022 10:50:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237880AbiCROu2 (ORCPT ); Fri, 18 Mar 2022 10:50:28 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3B5BF1BD839 for ; Fri, 18 Mar 2022 07:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647614896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AXh1kXJA2Arm+k9zVpD08NoMYuNv/3gU6u7CxBA2E8s=; b=EXqf4ncJjwpJRhjIeLvaCJPaOcijVlXSW/lo00dGbhZBQMklY62UBKvHcv3tv/4jsuuU/X Cy0UTDqmdKFPwDqDn3aBnE8V96lV2BRxP9K9VK6P3cttScVxQFPmNa/5qU7lhWESP0QtG3 sCOis8xCHp7ywW+TpOkpmUk2Ixrhl/E= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-622-ZiK8pNwNPmCjf2x7J_dSuQ-1; Fri, 18 Mar 2022 10:48:13 -0400 X-MC-Unique: ZiK8pNwNPmCjf2x7J_dSuQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 80D99296A625; Fri, 18 Mar 2022 14:48:12 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 16A4040D282F; Fri, 18 Mar 2022 14:48:09 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <164692909854.2099075.9535537286264248057.stgit@warthog.procyon.org.uk> <164692883658.2099075.5745824552116419504.stgit@warthog.procyon.org.uk> <306388.1647595110@warthog.procyon.org.uk> To: Jeff Layton Cc: dhowells@redhat.com, linux-cachefs@redhat.com, Anna Schumaker , Steve French , Dominique Martinet , David Wysochanski , Ilya Dryomov , Jeffle Xu , Linus Torvalds , linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 13/20] netfs: Add a netfs inode context MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <666407.1647614889.1@warthog.procyon.org.uk> Date: Fri, 18 Mar 2022 14:48:09 +0000 Message-ID: <666408.1647614889@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jeff Layton wrote: > > +static inline bool netfs_is_cache_enabled(struct netfs_i_context *ctx) > > +{ > > +#if IS_ENABLED(CONFIG_FSCACHE) > > + struct fscache_cookie *cookie = ctx->cache; > > + > > + return fscache_cookie_valid(cookie) && cookie->cache_priv && > > + fscache_cookie_enabled(cookie); > > > As you mentioned in the other thread, it may be cleaner to move the > cookie->cache_priv check into fscache_cookie_enabled. Is there ever a > case where you'd need to separate the two checks? I'm not sure, but I'd prefer not to do it in this series as it would affect NFS plus some other operations, so will need retesting thoroughly. I'd prefer to defer it. David