From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758851AbcHaTkG (ORCPT ); Wed, 31 Aug 2016 15:40:06 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:50514 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753048AbcHaTkC (ORCPT ); Wed, 31 Aug 2016 15:40:02 -0400 From: Arnd Bergmann To: David Howells Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released Date: Wed, 31 Aug 2016 21:40:02 +0200 Message-ID: <6677659.qx4okry02K@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <31015.1472665144@warthog.procyon.org.uk> References: <20160831123911.3467676-2-arnd@arndb.de> <20160831123911.3467676-1-arnd@arndb.de> <31015.1472665144@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:i1suym+1xuhyhcJ5IcGtui+GXAWNo5V4zOYkBbv0keX9nQasxm8 8Abm53tzTddI0Av0+cedTvDl1YTqulyqafOnj7oWTXsrM3/NzOgOIH1B26bClhUjag8J2bp eWob/5OVOi4P76coUEzbFluRTxWXM9UyqjAUJ2fGpBGWjHbHqUjfSRbGpoyDo7ZZXk71xCt dglWTjKXHs3Y1wSBks3NA== X-UI-Out-Filterresults: notjunk:1;V01:K0:PPH4nsj0BSs=:PeNoY6jtojZ9TTCwiJa6mH UJN+ilmP+E2pmrdpwvmGLkieycaUL6jv4HdjPuOXXXBag0q8D7bsBiiTQYr2tYtCxzVh9CvST jIGZk+9+hGIEiOw9PIXSGasLRx/Mj8zxT4zooE1Gumcu1cToT6f/eR7OgOJ5yAveUzQ+uzUKS tRZRxipOYJUtQf3PDIfF4E/uR0Gw6dgoZ1vYh3VZFqBcNIf8Loj3+HU02+fkS+qvSM6Ss9+NP 3uiVdOQF4Sitgqau/cG7TTia/PfuTQFnL9d3xnn5tjLorsMq10B48ZGw3Yqd+Qpid77+qzo2C w0dTaFveo9dvaOkv2/aghig15T/COQBDdAri6RzDqgCvJ3OEiTsOmcQOnwi92u8bzTzmrOfN2 UNg5ZFf4tvNfTCVgxqKd/BaHyzFQr5JoWOK6GUosnzYYEae3z7ROXM60bD9Ob+n5nQ3O/VfuP WhHybNDpTefsp5sls6n1K4ERlKhDckmx0KrC1ModVy1AXsd2nzLRJnRKSWY+texXzwwLKMWaR sJYBCFZAjzTkyAmHVL5X8H99iesK3qq1nGEudLhaecxj1qTdcGDaHMtNNp3t6bgnUH0gR75oH +4UF0cQlWgA4M1dqR9IqzsByEWblAgjkUj7GR/9AhYlasj+n7USe6Rd5ujn0Ai/5Oo1v6OrcD QbSOGWF1MGPkUOat4nqiIwIxzOOIGFRaJxXkY6VFiMiHu0e29qap3xnplhdddBhfAYHQIZz0t kuyRBV65UgWB4pjM Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, August 31, 2016 6:39:04 PM CEST David Howells wrote: > Arnd Bergmann wrote: > > > gcc -Wmaybe-initialized correctly points out a newly introduced bug > > through which we can end up calling rxrpc_queue_call() for a dead > > connection: > > How do you turn that on from within the Kbuild system? You don't, my mistake. My build bot runs with 6e8d666e9253 ("Disable "maybe-uninitialized" warning globally") disabled, and I had assumed that Linus left the warning enabled with "make W=1", but that was incorrect as Trond Myklebust also pointed out. You still get the warning with "make EXTRA_CFLAGS=-Wmaybe-uninitialized", which of course nobody normally does. I'll try to come up with a patch to enable the warning in the W=1 level in the same conditions that used to be enabled up to v4.7. Arnd