From: Keith Owens <kaos@ocs.com.au>
To: Matt Chapman <matthewc@cse.unsw.edu.au>
Cc: Dag Brattli <dag@brattli.net>,
linux-kernel@vger.kernel.org, linux-irda@pasta.cs.uit.no
Subject: Re: [PATCH] for Linux IRDA initialisation bug 2.4.5
Date: Fri, 01 Jun 2001 23:59:13 +1000 [thread overview]
Message-ID: <6679.991403953@ocs3.ocs-net> (raw)
In-Reply-To: Your message of "Fri, 01 Jun 2001 23:32:46 +1000." <20010601233245.A10478@cse.unsw.edu.au>
On Fri, 1 Jun 2001 23:32:46 +1000,
Matt Chapman <matthewc@cse.unsw.edu.au> wrote:
>I've found that if you compile IRDA into the kernel, irda_proto_init
>gets called twice - once at do_initcalls time, and once explicitly
>in do_basic_setup - eventually resulting in a hang (as
>register_netdevice_notifier gets called twice with the same struct,
>and it's list becomes circular).
The suggested patch has one non-obvious side effect which somebody in
irda needs to verify is OK. Previously irda_proto_init() and
irda_device_init() were called after every other driver had
initialized. Now irda_proto_init() is called based on the object order
in the top level Makefile, so irda is initialized before i2c,
telephony, acpi and mddev. Is this a valid initialization order? If
not, move
DRIVERS-$(CONFIG_IRDA) += drivers/net/irda/irda.o
to the end of the drivers list and document why it needs to be there.
next prev parent reply other threads:[~2001-06-01 14:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-01 13:32 [PATCH] for Linux IRDA initialisation bug 2.4.5 Matt Chapman
2001-06-01 13:59 ` Keith Owens [this message]
[not found] <mailman.991404121.32135.linux-kernel2news@redhat.com>
2001-06-01 19:16 ` Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6679.991403953@ocs3.ocs-net \
--to=kaos@ocs.com.au \
--cc=dag@brattli.net \
--cc=linux-irda@pasta.cs.uit.no \
--cc=linux-kernel@vger.kernel.org \
--cc=matthewc@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox