From: Florian Fainelli <f.fainelli@gmail.com>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: Doug Berger <opendmb@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: bcmgenet: Fix NULL vs IS_ERR() checking
Date: Sat, 11 Dec 2021 19:58:59 -0800 [thread overview]
Message-ID: <667d693b-4ffc-8318-b570-78929d6db702@gmail.com> (raw)
In-Reply-To: <20211211140154.23613-1-linmq006@gmail.com>
On 12/11/2021 6:01 AM, Miaoqian Lin wrote:
> The phy_attach() function does not return NULL. It returns error pointers.
>
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2021-12-12 3:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-11 14:01 [PATCH] net: bcmgenet: Fix NULL vs IS_ERR() checking Miaoqian Lin
2021-12-12 2:42 ` Joe Perches
2021-12-12 3:58 ` Florian Fainelli [this message]
2021-12-13 14:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=667d693b-4ffc-8318-b570-78929d6db702@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox