From: Jonathan Cameron <jic23@kernel.org>
To: Andrea della Porta <sfaragnaus@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging:iio:accel:adis16029 fixed checkpatch issue - drop braces around single if statement
Date: Sun, 2 Apr 2017 11:31:51 +0100 [thread overview]
Message-ID: <66958d0b-58ef-98fc-c8f2-e4b1cfd81c41@kernel.org> (raw)
In-Reply-To: <20170329083624.GA3281@gmail.com>
See patch title. Check the part number...
On 29/03/17 09:36, Andrea della Porta wrote:
> Fixed the followinf checkpatch warning:
> WARNING: braces {} are not necessary for single statement blocks
> #258: FILE: drivers/staging/iio/accel/adis16209.c:258:
> + if (ret) {
> + return ret;
> + }
>
> Signed-off-by: Andrea della Porta <sfaragnaus@gmail.com>
Was fixed about a week ago by Mark Stenglein.
Patch has made it through the IIO tree to staging yet though.
Should be heading that way this afternoon (depending on how
long Greg's backlog of emails still is ;)
Jonathan
> ---
> drivers/staging/iio/accel/adis16209.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/adis16209.c b/drivers/staging/iio/accel/adis16209.c
> index 52fa2e0..159a687 100644
> --- a/drivers/staging/iio/accel/adis16209.c
> +++ b/drivers/staging/iio/accel/adis16209.c
> @@ -255,9 +255,9 @@ static int adis16209_read_raw(struct iio_dev *indio_dev,
> }
> addr = adis16209_addresses[chan->scan_index][0];
> ret = adis_read_reg_16(st, addr, &val16);
> - if (ret) {
> + if (ret)
> return ret;
> - }
> +
> val16 &= (1 << bits) - 1;
> val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
> *val = val16;
>
prev parent reply other threads:[~2017-04-02 10:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 8:36 [PATCH] staging:iio:accel:adis16029 fixed checkpatch issue - drop braces around single if statement Andrea della Porta
2017-04-02 10:31 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66958d0b-58ef-98fc-c8f2-e4b1cfd81c41@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=sfaragnaus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox