From: Bob Peterson <rpeterso@redhat.com>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: agruenba@redhat.com, cluster-devel@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gfs2: make function gfs2_make_fs_ro() to void type
Date: Thu, 4 Mar 2021 10:22:59 -0500 (EST) [thread overview]
Message-ID: <669736422.59715790.1614871379550.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1614850640-63803-1-git-send-email-yang.lee@linux.alibaba.com>
----- Original Message -----
> It fixes the following warning detected by coccinelle:
> ./fs/gfs2/super.c:592:5-10: Unneeded variable: "error". Return "0" on
> line 628
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> fs/gfs2/ops_fstype.c | 4 +---
> fs/gfs2/super.c | 9 +++------
> fs/gfs2/super.h | 2 +-
> fs/gfs2/util.c | 2 +-
> 4 files changed, 6 insertions(+), 11 deletions(-)
Thanks. Your patch is now pushed to linux-gfs2/for-next.
I did one minor cleanup: Function gfs2_put_super in super.c no longer
needed the variable "error" so I removed it to avoid warnings.
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=0e787a0bfabb8be323f575d5cdda48e607840eb5
Regards,
Bob Peterson
prev parent reply other threads:[~2021-03-04 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 9:37 [PATCH] gfs2: make function gfs2_make_fs_ro() to void type Yang Li
2021-03-04 15:22 ` Bob Peterson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=669736422.59715790.1614871379550.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
--cc=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox