From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Gary Rookard <garyrookard@fastmail.org>, gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] staging: rtl8192e: rename variable HTGetHighestMCSRate
Date: Wed, 13 Dec 2023 20:22:45 +0100 [thread overview]
Message-ID: <66abc945-e539-4152-9044-2931934fb0fc@gmail.com> (raw)
In-Reply-To: <20231213175459.5425-2-garyrookard@fastmail.org>
On 12/13/23 18:54, Gary Rookard wrote:
> oding style issue, checkpatch Avoid CamelCase,
> rename it. HTGetHighestMCSRate -> ht_get_highest_mcs_rate
>
> Signed-off-by: Gary Rookard<garyrookard@fastmail.org>
> ---
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
> drivers/staging/rtl8192e/rtllib.h | 2 +-
> drivers/staging/rtl8192e/rtllib_wx.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index 25097f1935a5..06542ac851fc 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -377,7 +377,7 @@ static u8 ht_pick_mcs_rate(struct rtllib_device *ieee, u8 *pOperateMCS)
> return true;
> }
>
> -u8 HTGetHighestMCSRate(struct rtllib_device *ieee, u8 *pMCSRateSet,
> +u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *pMCSRateSet,
> u8 *pMCSFilter)
> {
> u8 i, j;
> @@ -545,7 +545,7 @@ void HTOnAssocRsp(struct rtllib_device *ieee)
> pMcsFilter = MCS_FILTER_1SS;
> else
> pMcsFilter = MCS_FILTER_ALL;
kernel@matrix-ESPRIMO-P710:~/Documents/git/kernels/staging$ cat
~/Downloads/20231213-\[PATCH\ 1* | git am
Applying: staging: rtl8192e: rename variable HTGetHighestMCSRate
error: patch failed: drivers/staging/rtl8192e/rtl819x_HTProc.c:545
error: drivers/staging/rtl8192e/rtl819x_HTProc.c: patch does not apply
Patch failed at 0001 staging: rtl8192e: rename variable HTGetHighestMCSRate
hint: Use 'git am --show-current-patch=diff' to see the failed patch
next prev parent reply other threads:[~2023-12-13 19:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 17:54 [PATCH 0/5] [Series 3] rename variable HTGetHighestMCSRate and (4) other Gary Rookard
2023-12-13 17:54 ` [PATCH 1/5] staging: rtl8192e: rename variable HTGetHighestMCSRate Gary Rookard
2023-12-13 19:22 ` Philipp Hortmann [this message]
2023-12-13 17:54 ` [PATCH 2/5] staging: rtl8192e: rename variable HTFilterMCSRate Gary Rookard
2023-12-13 17:54 ` [PATCH 3/5] staging: rtl8192e: rename variable HTSetConnectBwMode Gary Rookard
2023-12-13 17:54 ` [PATCH 4/5] staging: rtl8192e: rename variable HTOnAssocRsp Gary Rookard
2023-12-13 17:54 ` [PATCH 5/5] staging: rtl8192e: rename variable HTInitializeHTInfo Gary Rookard
2023-12-15 12:38 ` [PATCH 0/5] [Series 3] rename variable HTGetHighestMCSRate and (4) other Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66abc945-e539-4152-9044-2931934fb0fc@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=garyrookard@fastmail.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox