Re: [PATCH v3 2/6] nvme: assign of_node to nvme device

Christoph Hellwig
2024-08-06T12:43:15Z

On Tue, Aug 06, 2024 at 01:41:12PM +0200, Christian Marangi wrote:
> Introduce support for a dedicated node for a nvme card. This will be a
> subnode of the nvme controller node that will have the "nvme-card"
> compatible.
>
> This follow a similar implementation done for mmc where the specific mmc
> card have a dedicated of_node.
>
> This can be used for scenario where block2mtd module is used to declare
> partition in DT and block2mtd is called on the root block of the nvme
> card, permitting the usage of fixed-partition parser or alternative
> ones.

Err, hell no. Why would you wire up a purely PCIe device to OF?
PCIe is self-discovering.