From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "David E. Box" <david.e.box@linux.intel.com>
Cc: hdegoede@redhat.com, markgross@kernel.org,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86/intel/sdsi: Change mailbox timeout
Date: Thu, 13 Apr 2023 13:17:18 +0300 (EEST) [thread overview]
Message-ID: <66b5cf7-391-8d63-b7da-267fe8a639bd@linux.intel.com> (raw)
In-Reply-To: <20230413013230.1521584-1-david.e.box@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
On Wed, 12 Apr 2023, David E. Box wrote:
> On some platforms, it may take up to 400ms for the ready bit to be set in a
> successful mailbox transaction. Set the timeout to 500ms to cover the worst
> case.
>
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> ---
> drivers/platform/x86/intel/sdsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/intel/sdsi.c
> index 9e0ea2cdd704..556e7c6dbb05 100644
> --- a/drivers/platform/x86/intel/sdsi.c
> +++ b/drivers/platform/x86/intel/sdsi.c
> @@ -49,7 +49,7 @@
> #define SDSI_MBOX_CMD_SUCCESS 0x40
> #define SDSI_MBOX_CMD_TIMEOUT 0x80
>
> -#define MBOX_TIMEOUT_US 2000
> +#define MBOX_TIMEOUT_US 500000
> #define MBOX_TIMEOUT_ACQUIRE_US 1000
> #define MBOX_POLLING_PERIOD_US 100
> #define MBOX_ACQUIRE_NUM_RETRIES 5
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2023-04-13 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 1:32 [PATCH] platform/x86/intel/sdsi: Change mailbox timeout David E. Box
2023-04-13 10:17 ` Ilpo Järvinen [this message]
2023-04-17 10:13 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66b5cf7-391-8d63-b7da-267fe8a639bd@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=david.e.box@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox