From: Dikshita Agarwal <quic_dikshita@quicinc.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Vikash Garodia <quic_vgarodia@quicinc.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"Rob Herring" <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
Sebastian Fricke <sebastian.fricke@collabora.com>,
<linux-arm-msm@vger.kernel.org>, <linux-media@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 02/28] media: iris: add platform driver for iris video device
Date: Wed, 16 Oct 2024 15:59:57 +0530 [thread overview]
Message-ID: <66cf771e-1663-e85c-02e8-524427ab40ec@quicinc.com> (raw)
In-Reply-To: <r7p4glfxjkcecm7fi4qkl3utn3damrun6lfzkmn5wddcd7pxq7@fpav7mavmckn>
On 10/16/2024 3:08 PM, Uwe Kleine-König wrote:
> Hello,
>
> On Mon, Oct 14, 2024 at 02:37:23PM +0530, Dikshita Agarwal wrote:
>> +static struct platform_driver qcom_iris_driver = {
>> + .probe = iris_probe,
>> + .remove_new = iris_remove,
>> + .driver = {
>> + .name = "qcom-iris",
>> + .of_match_table = iris_dt_match,
>> + },
>> +};
>
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers. Please just drop "_new".
>
Noted, Thanks!
Regards,
Dikshita
> Best regards
> Uwe
next prev parent reply other threads:[~2024-10-16 10:30 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 9:07 [PATCH v4 00/28] Qualcomm iris video decoder driver Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 01/28] dt-bindings: media: Add video support for QCOM SM8550 SoC Dikshita Agarwal
2024-10-14 11:57 ` Krzysztof Kozlowski
2024-10-14 9:07 ` [PATCH v4 02/28] media: iris: add platform driver for iris video device Dikshita Agarwal
2024-10-16 9:38 ` Uwe Kleine-König
2024-10-16 10:29 ` Dikshita Agarwal [this message]
2024-10-14 9:07 ` [PATCH v4 03/28] media: iris: implement iris v4l2 file ops Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 04/28] media: iris: introduce iris core state management with shared queues Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 05/28] media: iris: implement video firmware load/unload Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 06/28] media: iris: implement boot sequence of the firmware Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 07/28] media: iris: introduce host firmware interface with necessary hooks Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 08/28] media: iris: implement power management Dikshita Agarwal
2024-10-15 11:25 ` kernel test robot
2024-10-15 12:07 ` kernel test robot
2024-10-14 9:07 ` [PATCH v4 09/28] media: iris: implement reqbuf ioctl with vb2_queue_setup Dikshita Agarwal
2024-10-23 9:59 ` Hans Verkuil
2024-10-23 10:17 ` Dikshita Agarwal
2024-10-23 11:25 ` Hans Verkuil
2024-10-23 11:33 ` Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 10/28] media: iris: implement s_fmt, g_fmt and try_fmt ioctls Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 11/28] media: iris: implement g_selection ioctl Dikshita Agarwal
2024-10-23 10:45 ` Hans Verkuil
2024-10-23 11:31 ` Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 12/28] media: iris: implement enum_fmt and enum_frameintervals ioctls Dikshita Agarwal
2024-10-23 10:49 ` Hans Verkuil
2024-10-23 11:38 ` Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 13/28] media: iris: implement subscribe_event and unsubscribe_event ioctls Dikshita Agarwal
2024-10-23 10:53 ` Hans Verkuil
2024-10-23 12:03 ` Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 14/28] media: iris: implement iris v4l2_ctrl_ops Dikshita Agarwal
2024-10-23 11:02 ` Hans Verkuil
2024-10-25 9:21 ` Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 15/28] media: iris: implement query_cap, query_ctrl and query_menu ioctls Dikshita Agarwal
2024-10-23 11:05 ` Hans Verkuil
2024-10-24 5:50 ` Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 16/28] media: iris: implement vb2 streaming ops Dikshita Agarwal
2024-10-23 11:13 ` Hans Verkuil
2024-10-25 7:06 ` Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 17/28] media: iris: implement set properties to firmware during streamon Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 18/28] media: iris: subscribe parameters and properties to firmware for hfi_gen2 Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 19/28] media: iris: allocate, initialize and queue internal buffers Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 20/28] media: iris: implement vb2 ops for buf_queue and firmware response Dikshita Agarwal
2024-10-23 11:19 ` Hans Verkuil
2024-10-23 11:53 ` Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 21/28] media: iris: add support for dynamic resolution change Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 22/28] media: iris: handle streamoff/on from client in " Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 23/28] media: iris: add support for drain sequence Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 24/28] media: iris: add check whether the video session is supported or not Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 25/28] media: iris: implement power scaling for vpu2 and vpu3 Dikshita Agarwal
2024-10-17 6:08 ` kernel test robot
2024-10-19 11:38 ` kernel test robot
2024-10-14 9:07 ` [PATCH v4 26/28] media: iris: add check to allow sub states transitions Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 27/28] media: iris: enable video driver probe of SM8250 SoC Dikshita Agarwal
2024-10-14 14:00 ` Jianhua Lu
2024-10-14 14:08 ` Dmitry Baryshkov
2024-10-15 9:22 ` Dikshita Agarwal
2024-10-15 12:26 ` Dmitry Baryshkov
2024-10-25 7:03 ` Dikshita Agarwal
2024-10-14 9:07 ` [PATCH v4 28/28] media: MAINTAINERS: add Qualcomm iris video accelerator driver Dikshita Agarwal
2024-10-14 11:54 ` [PATCH v4 00/28] Qualcomm iris video decoder driver Krzysztof Kozlowski
2024-10-15 7:26 ` Dikshita Agarwal
2024-10-17 1:26 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66cf771e-1663-e85c-02e8-524427ab40ec@quicinc.com \
--to=quic_dikshita@quicinc.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=robh@kernel.org \
--cc=sebastian.fricke@collabora.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox