From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5B011E633C for ; Mon, 11 May 2026 11:11:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778497875; cv=none; b=qKQcodePjgMz9f/JSJ1us5a5vfxMZrp4392As4bMZU/72wjvf+Yx7HdSjHG3fszGIsAdO3Ea9KUFe/RwdUUVtQgJfrKuw9fe4mo6XvwXfdsNuleYqzMmob5dPLOhyaojckXCTK8N9AUiwk2zJ4CqKoAiSJImQ8GjfMYYmI7+vL0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778497875; c=relaxed/simple; bh=ixaIdq8s9sK/X9KuhLH5Xt/Pe3ZCxPqzdLBgPPRcCGQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hj5OsN5TVS0DtPcfWpDBob6k2AVnm+RiOWyIOrYr6GC4AcamRYm6Rx/1I9IKbtrNC96392+4MxS07cye2aEJBKqivVHVl7SY1vwiVUI73PJYLZBv5n8nhl27D2R0dH5rNkwJIpqSeJamWWv2pdBSa9gA0kMiAiiH6DXpq4jKuS4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=P4PJgDo2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GDaRh/ez; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="P4PJgDo2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GDaRh/ez" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64B7FKr03332700 for ; Mon, 11 May 2026 11:11:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6U2NCm6PjqK+2xwlJVZjMlcHV/JWJdYIbSn1GNodfVw=; b=P4PJgDo2Uhn4mh4n FLcJF6RN2rBlTrMQ0rlLB0IqaK3O9sM7GY7PQ0FiUnjwo739C0TxM+fgtkfmfVjf LMAgJxqGj2XQLDcq0RyhwxeQDE+JPnzlT5Rf53E0iDR7VE61gnxY5ozxD36apvgp iY+9bIANyf4vIahXNoUNTRiiNqxIxhFSCGKeuOfZ5IpNyfOXyJGVPA0ksIkEtlFr IUTv+2ehe2KsMx8bwlvjR5bAplpUz//MBWpHx+QDiZ3tT9Wt3Zw0TAwHlM0CuZKA ItvvQJsSw5d9O79lus/9/BwnefTrPzXAh4u/qrYPCULrZgNyXjZ6LJ88iz3PbQe7 ufHyDg== Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e3ajgrvds-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 11 May 2026 11:11:13 +0000 (GMT) Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-575296be5b1so375875e0c.0 for ; Mon, 11 May 2026 04:11:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778497873; x=1779102673; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6U2NCm6PjqK+2xwlJVZjMlcHV/JWJdYIbSn1GNodfVw=; b=GDaRh/ezip1EJE2k+oDqN0KD4iZQIDVkfE+HdSoIAJIOrg07Tz7uCk5VrgnWGx7+VV Y1nZqbfHjkweM8ZS/W7iVxT+YqYRhlsAAmR8ZAzXl7D2EPRSbFv3sG6mbvgOf5C0S5FM jr8/LcoSEGD0RcKveKb4N6ECbOuE0Do1WnlYwyyOGu/11M+0MXy/t+j9U194gu1rSdKr 8dXaq+ZQ2EVB485yciTnb5MVOzKaFg7F1q/eu/CfspuenBUGhGeneqbYCWkL6albDkb7 odd+c6RQYBbJhT0GXIJHyXCWG+WWal7G+EmqwCndrzkJZlR3F8ra+IbqQcYTNQ8OeN81 bBLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778497873; x=1779102673; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6U2NCm6PjqK+2xwlJVZjMlcHV/JWJdYIbSn1GNodfVw=; b=GNFlQrrH4dU5Ls8XCIXmr6tnnjG1lwMiQAUEQcQ6cU0ZmT47CzSy6NhR33CoJ/mRT5 u19XNoiqJR/TMlls17pr1P0S68MBmqiGwkqQvz1n6Uz+PcyqCDVPXaYVGjl5GPxxhBzp 1mz2qcbQsaA5/s9wiUgrere7OiAqI88gyi/mYUZ44qsJlAv5FfeZt4LI+HPhINir1MWQ E8+xVF1U9y4x/CzCYTZ42ZsQVkgUAeGGkmEv581cTC8cL8FxHcQfiZIAHyaCogldhO36 JXiWRNN9a3ezTTgP2ORVRqTGXorWlvOdgrLwcrviF69OL1an7O6vItCEs1HoCWgMOf6z rtNg== X-Forwarded-Encrypted: i=1; AFNElJ+j5oTdZysQjetc4PcHk7wEErupS4rOplzMq/0rGWr9eWjajHPw2ePGLsbeweHcRdVXawkXkSm2Z2cXIFE=@vger.kernel.org X-Gm-Message-State: AOJu0YxXUqICb6OjwoKnlRnwHoD7eC2kQ+6JsPBRcLIEMKB0Cocd95Ow VmgIFmvv727W46wKGQqbjkZCqHGBNvOWNlME2uhlhlv6kBqJfgY8ay1apnAChTR6oxla5t/ZZtD r3/K0QvV4QP+Ivg1fSbY17qvDrFyVHBsGsWZGBq1Gd2VbVY+qnX9tdaZizmt68zXCF6w= X-Gm-Gg: Acq92OFJ6Zy2KXYf48Nok586Bqq24GMDOTY+JbQ6+LmHs2hcdfa8uMsI3zhClbQ5y6k rY+7QP+cjJC4PKLLGTKEVCmr+kp0SQ/y4Syc+XnH9Jqa67kzf2RJU7R0ixvQ5V08rd+01Tq9U49 /YG8NaKs6QO1AhvPKwpnFC0GrZOjqrvn6QQ6hFTEEJIjTONIozvRSvZvqWp3C1BQJ0Uuho341Us z0bTaEgpdakHen0cFeZNKpB/+kgMfZOaStUGme20dBKHJzNM1Xc/9grLW+Z/SKDiadWoajVsyZp 8HiIhuL2g4ehmre1rLuB5+hVLHb38YzcazPmAQ0GrjlcmJ+MvVx/0RGFNZT0Qj4gpcqkdcRMIGo NDXR4JUsAV7MjiPKNhVt4Juq3Mi03pwyfV7KftU1uXV2rm4Q7bBP+k9poN3CoXBi0MucsAwxr6W 44Zds= X-Received: by 2002:a05:6102:a12:b0:631:25ab:8bbe with SMTP id ada2fe7eead31-63125ab9e94mr2488685137.5.1778497872876; Mon, 11 May 2026 04:11:12 -0700 (PDT) X-Received: by 2002:a05:6102:a12:b0:631:25ab:8bbe with SMTP id ada2fe7eead31-63125ab9e94mr2488680137.5.1778497872298; Mon, 11 May 2026 04:11:12 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bcf44d53fa2sm173758366b.23.2026.05.11.04.11.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 May 2026 04:11:11 -0700 (PDT) Message-ID: <66d8dd2e-05f8-4f58-bfb4-fd290dde1ebe@oss.qualcomm.com> Date: Mon, 11 May 2026 13:11:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] ASoC: codecs: lpass-wsa-macro: Use devm_clk_hw_register() for MCLK output To: Ajay Kumar Nandam , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org References: <20260508113503.3550647-1-ajay.nandam@oss.qualcomm.com> <20260508113503.3550647-4-ajay.nandam@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260508113503.3550647-4-ajay.nandam@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=GfgnWwXL c=1 sm=1 tr=0 ts=6a01b951 cx=c_pps a=JIY1xp/sjQ9K5JH4t62bdg==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=bpY43GGW-Kl_9GUVYIEA:9 a=QEXdDO2ut3YA:10 a=tNoRWFLymzeba-QzToBc:22 X-Proofpoint-GUID: CVzIzhF_llILM4WGSq2cv4Xltlu7NmzO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTExMDEyNCBTYWx0ZWRfXwN2xBNb2GaG1 5t4CVZpOMM+7lyGboOQBwSxDGnTfSSpnNfAzF6PWtgk+GfLrWirf7yxZOqjhaytkFo7/rB4pLFb aZzdB3oqltmGUJ1v6bQ4QihyCrl+x5Nc+8hM37yPoZZRcc8vaBpjQfsx6orAIzGa5YCqQe45gCB W1YyPE2At+UKb7RFqCf5Bng+VgfBaOV7pLNKpHXN5lWSLMDy9eh3vnVYUFtTQatsNpmRELo1Je/ ff4lQR9tJnoL+SIP5nSx3Ra9Kaj9NLannWhoQG08o33lfgJVcSAbcnr6XtXM2Jz3PA7ej3xCW4n HehY+UqJutJRU7yUkdBmvv685PJvOI5DfP9O8x/h/ScVhUPUSuyZos8bu3kRoWaU2a08K0z2zoN QBnEZhvdI26P3jBLiIb7vJD1MFKOtTpiWRvQUgbRnQCKV+lh+ymIxhQdrxjiz6DiNJDP7NBlBgZ ptmkLrBKkGTqZrLUXbA== X-Proofpoint-ORIG-GUID: CVzIzhF_llILM4WGSq2cv4Xltlu7NmzO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-11_03,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 impostorscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605110124 On 5/8/26 1:35 PM, Ajay Kumar Nandam wrote: > The WSA macro driver registers the MCLK output clock using > clk_hw_register(), but does not explicitly unregister it in the remove > path or on probe failure. > > Switch to devm_clk_hw_register() to make the registration resource-managed > so the clk_hw is automatically unregistered when the device is unbound or > probe fails. This avoids lifetime and cleanup issues and simplifies error > handling. > > No functional change intended. This is a bit of a semantic argument, but the driver will now behave differently, since as you explained above, .remove does not currently unregister the clock (but devres will now do that) > Signed-off-by: Ajay Kumar Nandam > --- Reviewed-by: Konrad Dybcio Konrad