* [syzbot] [audit?] general protection fault in smack_log_callback
@ 2024-09-19 13:23 syzbot
2024-09-19 16:05 ` Paul Moore
0 siblings, 1 reply; 4+ messages in thread
From: syzbot @ 2024-09-19 13:23 UTC (permalink / raw)
To: audit, casey, eparis, jmorris, john.johansen, linux-kernel,
linux-security-module, paul, serge, syzkaller-bugs
Hello,
syzbot found the following issue on:
HEAD commit: bdf56c7580d2 Merge tag 'slab-for-6.12' of git://git.kernel..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=12584b00580000
kernel config: https://syzkaller.appspot.com/x/.config?x=4540f5bcdd31e3de
dashboard link: https://syzkaller.appspot.com/bug?extid=044fdf24e96093584232
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=155cffc7980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=16ad24a9980000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/cec9f3c675f1/disk-bdf56c75.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/21e06ae5b159/vmlinux-bdf56c75.xz
kernel image: https://storage.googleapis.com/syzbot-assets/1e936c954b8b/bzImage-bdf56c75.xz
The issue was bisected to:
commit 5f8d28f6d7d568dbbc8c5bce94894474c07afd4f
Author: Casey Schaufler <casey@schaufler-ca.com>
Date: Wed Jul 10 21:32:26 2024 +0000
lsm: infrastructure management of the key security blob
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1124d69f980000
final oops: https://syzkaller.appspot.com/x/report.txt?x=1324d69f980000
console output: https://syzkaller.appspot.com/x/log.txt?x=1524d69f980000
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+044fdf24e96093584232@syzkaller.appspotmail.com
Fixes: 5f8d28f6d7d5 ("lsm: infrastructure management of the key security blob")
Oops: general protection fault, probably for non-canonical address 0xe006eb2e8e85e5c5: 0000 [#1] PREEMPT SMP KASAN PTI
KASAN: maybe wild-memory-access in range [0x00377974742f2e28-0x00377974742f2e2f]
CPU: 0 UID: 3327 PID: 5215 Comm: syz-executor393 Not tainted 6.11.0-syzkaller-04744-gbdf56c7580d2 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
RIP: 0010:strlen+0x2c/0x70 lib/string.c:402
Code: 1e fa 41 57 41 56 41 54 53 49 89 fe 48 c7 c0 ff ff ff ff 49 bf 00 00 00 00 00 fc ff df 48 89 fb 49 89 c4 48 89 d8 48 c1 e8 03 <42> 0f b6 04 38 84 c0 75 12 48 ff c3 49 8d 44 24 01 43 80 7c 26 01
RSP: 0018:ffffc9000399f838 EFLAGS: 00010207
RAX: 0006ef2e8e85e5c5 RBX: 00377974742f2e2e RCX: ffff888027135a00
RDX: 0000000000000000 RSI: 00377974742f2e2e RDI: 00377974742f2e2e
RBP: 00000000fffffff3 R08: ffffffff897a37ca R09: 3d7463656a626f20
R10: dffffc0000000000 R11: ffffed10050c4e0d R12: ffffffffffffffff
R13: ffff888027135a00 R14: 00377974742f2e2e R15: dffffc0000000000
FS: 0000555591989380(0000) GS:ffff8880b8800000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020caaffb CR3: 0000000024a90000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
audit_log_untrustedstring+0x25/0x1b0 kernel/audit.c:2135
smack_log_callback+0x105/0x1b0 security/smack/smack_access.c:321
common_lsm_audit+0xfd/0x1b30 security/lsm_audit.c:456
smack_log+0x421/0x540 security/smack/smack_access.c:383
smk_access+0x4a4/0x4e0 security/smack/smack_access.c:199
smack_watch_key+0x2f4/0x3a0 security/smack/smack_lsm.c:4656
security_watch_key+0x86/0x250 security/security.c:4448
keyctl_watch_key+0x2b7/0x480 security/keys/keyctl.c:1813
__do_sys_keyctl security/keys/keyctl.c:2021 [inline]
__se_sys_keyctl+0x106/0xa50 security/keys/keyctl.c:1874
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f384e02daf9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 c1 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd63c63ed8 EFLAGS: 00000246 ORIG_RAX: 00000000000000fa
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f384e02daf9
RDX: 0000000000000004 RSI: 000000000adcda0f RDI: 0000000000000020
RBP: 00007f384e0a05f0 R08: 0000000000000000 R09: 0000000000000006
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 431bde82d7b634db R14: 0000000000000001 R15: 0000000000000001
</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:strlen+0x2c/0x70 lib/string.c:402
Code: 1e fa 41 57 41 56 41 54 53 49 89 fe 48 c7 c0 ff ff ff ff 49 bf 00 00 00 00 00 fc ff df 48 89 fb 49 89 c4 48 89 d8 48 c1 e8 03 <42> 0f b6 04 38 84 c0 75 12 48 ff c3 49 8d 44 24 01 43 80 7c 26 01
RSP: 0018:ffffc9000399f838 EFLAGS: 00010207
RAX: 0006ef2e8e85e5c5 RBX: 00377974742f2e2e RCX: ffff888027135a00
RDX: 0000000000000000 RSI: 00377974742f2e2e RDI: 00377974742f2e2e
RBP: 00000000fffffff3 R08: ffffffff897a37ca R09: 3d7463656a626f20
R10: dffffc0000000000 R11: ffffed10050c4e0d R12: ffffffffffffffff
R13: ffff888027135a00 R14: 00377974742f2e2e R15: dffffc0000000000
FS: 0000555591989380(0000) GS:ffff8880b8800000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020caaffb CR3: 0000000024a90000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess), 1 bytes skipped:
0: fa cli
1: 41 57 push %r15
3: 41 56 push %r14
5: 41 54 push %r12
7: 53 push %rbx
8: 49 89 fe mov %rdi,%r14
b: 48 c7 c0 ff ff ff ff mov $0xffffffffffffffff,%rax
12: 49 bf 00 00 00 00 00 movabs $0xdffffc0000000000,%r15
19: fc ff df
1c: 48 89 fb mov %rdi,%rbx
1f: 49 89 c4 mov %rax,%r12
22: 48 89 d8 mov %rbx,%rax
25: 48 c1 e8 03 shr $0x3,%rax
* 29: 42 0f b6 04 38 movzbl (%rax,%r15,1),%eax <-- trapping instruction
2e: 84 c0 test %al,%al
30: 75 12 jne 0x44
32: 48 ff c3 inc %rbx
35: 49 8d 44 24 01 lea 0x1(%r12),%rax
3a: 43 rex.XB
3b: 80 .byte 0x80
3c: 7c 26 jl 0x64
3e: 01 .byte 0x1
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [syzbot] [audit?] general protection fault in smack_log_callback
2024-09-19 13:23 [syzbot] [audit?] general protection fault in smack_log_callback syzbot
@ 2024-09-19 16:05 ` Paul Moore
2024-09-19 16:37 ` Casey Schaufler
2024-09-19 19:37 ` syzbot
0 siblings, 2 replies; 4+ messages in thread
From: Paul Moore @ 2024-09-19 16:05 UTC (permalink / raw)
To: syzbot
Cc: audit, casey, eparis, jmorris, john.johansen, linux-kernel,
linux-security-module, serge, syzkaller-bugs
[-- Attachment #1: Type: text/plain, Size: 1946 bytes --]
On Thu, Sep 19, 2024 at 9:23 AM syzbot
<syzbot+044fdf24e96093584232@syzkaller.appspotmail.com> wrote:
>
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit: bdf56c7580d2 Merge tag 'slab-for-6.12' of git://git.kernel..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=12584b00580000
> kernel config: https://syzkaller.appspot.com/x/.config?x=4540f5bcdd31e3de
> dashboard link: https://syzkaller.appspot.com/bug?extid=044fdf24e96093584232
> compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=155cffc7980000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=16ad24a9980000
>
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/cec9f3c675f1/disk-bdf56c75.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/21e06ae5b159/vmlinux-bdf56c75.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/1e936c954b8b/bzImage-bdf56c75.xz
>
> The issue was bisected to:
>
> commit 5f8d28f6d7d568dbbc8c5bce94894474c07afd4f
> Author: Casey Schaufler <casey@schaufler-ca.com>
> Date: Wed Jul 10 21:32:26 2024 +0000
>
> lsm: infrastructure management of the key security blob
>
> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1124d69f980000
> final oops: https://syzkaller.appspot.com/x/report.txt?x=1324d69f980000
> console output: https://syzkaller.appspot.com/x/log.txt?x=1524d69f980000
I just posted a patch which I believe should fix the problem, but I'd
like to get Casey's ACK on it before submitting upstream as it does
touch Smack code; lore link below:
https://lore.kernel.org/linux-security-module/20240919155740.29539-2-paul@paul-moore.com
... in the meantime, I'm attaching the patch here so syzbot can verify
that it solves the problem.
#syz test
--
paul-moore.com
[-- Attachment #2: 01-lsm-key_blob_fix.patch --]
[-- Type: text/x-patch, Size: 2406 bytes --]
selinux,smack: properly reference the LSM blob in security_watch_key()
From: Paul Moore <paul@paul-moore.com>
Unfortunately when we migrated the lifecycle management of the key LSM
blob to the LSM framework we forgot to convert the security_watch_key()
callbacks for SELinux and Smack. This patch corrects this by making use
of the selinux_key() and smack_key() helper functions respectively.
This patch also removes some input checking in the Smack callback as it
is no longer needed.
Reported-by: syzbot+044fdf24e96093584232@syzkaller.appspotmail.com
Fixes: 5f8d28f6d7d5 ("lsm: infrastructure management of the key security blob")
Signed-off-by: Paul Moore <paul@paul-moore.com>
---
security/selinux/hooks.c | 2 +-
security/smack/smack_lsm.c | 13 +++----------
2 files changed, 4 insertions(+), 11 deletions(-)
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 81fbfa5b80d4..67baa487cf7a 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -6720,7 +6720,7 @@ static int selinux_key_getsecurity(struct key *key, char **_buffer)
#ifdef CONFIG_KEY_NOTIFICATIONS
static int selinux_watch_key(struct key *key)
{
- struct key_security_struct *ksec = key->security;
+ struct key_security_struct *ksec = selinux_key(key);
u32 sid = current_sid();
return avc_has_perm(sid, ksec->sid, SECCLASS_KEY, KEY__VIEW, NULL);
diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index da0c2bffbd08..563fb404f659 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -4629,16 +4629,9 @@ static int smack_watch_key(struct key *key)
{
struct smk_audit_info ad;
struct smack_known *tkp = smk_of_current();
+ struct smack_known **blob = smack_key(key);
int rc;
- if (key == NULL)
- return -EINVAL;
- /*
- * If the key hasn't been initialized give it access so that
- * it may do so.
- */
- if (key->security == NULL)
- return 0;
/*
* This should not occur
*/
@@ -4653,8 +4646,8 @@ static int smack_watch_key(struct key *key)
ad.a.u.key_struct.key = key->serial;
ad.a.u.key_struct.key_desc = key->description;
#endif
- rc = smk_access(tkp, key->security, MAY_READ, &ad);
- rc = smk_bu_note("key watch", tkp, key->security, MAY_READ, rc);
+ rc = smk_access(tkp, *blob, MAY_READ, &ad);
+ rc = smk_bu_note("key watch", tkp, *blob, MAY_READ, rc);
return rc;
}
#endif /* CONFIG_KEY_NOTIFICATIONS */
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [syzbot] [audit?] general protection fault in smack_log_callback
2024-09-19 16:05 ` Paul Moore
@ 2024-09-19 16:37 ` Casey Schaufler
2024-09-19 19:37 ` syzbot
1 sibling, 0 replies; 4+ messages in thread
From: Casey Schaufler @ 2024-09-19 16:37 UTC (permalink / raw)
To: Paul Moore, syzbot
Cc: audit, eparis, jmorris, john.johansen, linux-kernel,
linux-security-module, serge, syzkaller-bugs, Casey Schaufler
On 9/19/2024 9:05 AM, Paul Moore wrote:
> On Thu, Sep 19, 2024 at 9:23 AM syzbot
> <syzbot+044fdf24e96093584232@syzkaller.appspotmail.com> wrote:
>> Hello,
>>
>> syzbot found the following issue on:
>>
>> HEAD commit: bdf56c7580d2 Merge tag 'slab-for-6.12' of git://git.kernel..
>> git tree: upstream
>> console output: https://syzkaller.appspot.com/x/log.txt?x=12584b00580000
>> kernel config: https://syzkaller.appspot.com/x/.config?x=4540f5bcdd31e3de
>> dashboard link: https://syzkaller.appspot.com/bug?extid=044fdf24e96093584232
>> compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=155cffc7980000
>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=16ad24a9980000
>>
>> Downloadable assets:
>> disk image: https://storage.googleapis.com/syzbot-assets/cec9f3c675f1/disk-bdf56c75.raw.xz
>> vmlinux: https://storage.googleapis.com/syzbot-assets/21e06ae5b159/vmlinux-bdf56c75.xz
>> kernel image: https://storage.googleapis.com/syzbot-assets/1e936c954b8b/bzImage-bdf56c75.xz
>>
>> The issue was bisected to:
>>
>> commit 5f8d28f6d7d568dbbc8c5bce94894474c07afd4f
>> Author: Casey Schaufler <casey@schaufler-ca.com>
>> Date: Wed Jul 10 21:32:26 2024 +0000
>>
>> lsm: infrastructure management of the key security blob
>>
>> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1124d69f980000
>> final oops: https://syzkaller.appspot.com/x/report.txt?x=1324d69f980000
>> console output: https://syzkaller.appspot.com/x/log.txt?x=1524d69f980000
> I just posted a patch which I believe should fix the problem, but I'd
> like to get Casey's ACK on it before submitting upstream as it does
> touch Smack code; lore link below:
Thanks for jumping on this. Your build and test cycle is faster than mine.
>
> https://lore.kernel.org/linux-security-module/20240919155740.29539-2-paul@paul-moore.com
>
> .. in the meantime, I'm attaching the patch here so syzbot can verify
> that it solves the problem.
>
> #syz test
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [syzbot] [audit?] general protection fault in smack_log_callback
2024-09-19 16:05 ` Paul Moore
2024-09-19 16:37 ` Casey Schaufler
@ 2024-09-19 19:37 ` syzbot
1 sibling, 0 replies; 4+ messages in thread
From: syzbot @ 2024-09-19 19:37 UTC (permalink / raw)
To: audit, casey, eparis, jmorris, john.johansen, linux-kernel,
linux-security-module, paul, serge, syzkaller-bugs
Hello,
syzbot has tested the proposed patch and the reproducer did not trigger any issue:
Reported-by: syzbot+044fdf24e96093584232@syzkaller.appspotmail.com
Tested-by: syzbot+044fdf24e96093584232@syzkaller.appspotmail.com
Tested on:
commit: 2004cef1 Merge tag 'sched-core-2024-09-19' of git://gi..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1784c427980000
kernel config: https://syzkaller.appspot.com/x/.config?x=38d475ce6711b8b4
dashboard link: https://syzkaller.appspot.com/bug?extid=044fdf24e96093584232
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
patch: https://syzkaller.appspot.com/x/patch.diff?x=162b369f980000
Note: testing is done by a robot and is best-effort only.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-09-19 19:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-19 13:23 [syzbot] [audit?] general protection fault in smack_log_callback syzbot
2024-09-19 16:05 ` Paul Moore
2024-09-19 16:37 ` Casey Schaufler
2024-09-19 19:37 ` syzbot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox