From: Florian Fainelli <f.fainelli@gmail.com>
To: Markus Mayer <markus.mayer@broadcom.com>,
Colin Ian King <colin.king@canonical.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
Linux ARM Kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memory: brcmstb_dpfe: fix array index out of bounds
Date: Thu, 20 Aug 2020 20:15:04 -0700 [thread overview]
Message-ID: <66ec2e07-fbdb-fd8b-9c1e-5f7dc343c9fd@gmail.com> (raw)
In-Reply-To: <20200821010333.20436-1-mmayer@broadcom.com>
On 8/20/2020 6:03 PM, Markus Mayer wrote:
> We would overrun the error_text array if we hit a TIMEOUT condition,
> because we were using the error code "ETIMEDOUT" (which is 110) as an
> array index.
>
> We fix the problem by correcting the array index and by providing a
> function to retrieve error messages rather than accessing the array
> directly. The function includes a bounds check that prevents the array
> from being overrun.
>
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Fixes: 2f330caff577 ("memory: brcmstb: Add driver for DPFE")
Reported-by: Colin Ian King <colin.king@canonical.com>
(Colin, was there a specific coverity ID you wanted to use?)
--
Florian
next prev parent reply other threads:[~2020-08-21 3:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 1:03 [PATCH] memory: brcmstb_dpfe: fix array index out of bounds Markus Mayer
2020-08-21 3:15 ` Florian Fainelli [this message]
2020-08-21 4:42 ` kernel test robot
2020-08-21 5:40 ` Krzysztof Kozlowski
2020-08-21 16:49 ` Markus Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66ec2e07-fbdb-fd8b-9c1e-5f7dc343c9fd@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=colin.king@canonical.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.mayer@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox