[syzbot] [ide?] general protection fault in ata_msense_control

[syzbot] [ide?] general protection fault in ata_msense_control

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit:    2004cef11ea0 Merge tag 'sched-core-2024-09-19' of git://gi..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=14362427980000
kernel config:  https://syzkaller.appspot.com/x/.config?x=390864846727e762
dashboard link: https://syzkaller.appspot.com/bug?extid=37757dc11ee77ef850bb
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=16f5f69f980000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=154afb00580000

Downloadable assets:
disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/7bc7510fe41f/non_bootable_disk-2004cef1.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/8654ff1e22d1/vmlinux-2004cef1.xz
kernel image: https://storage.googleapis.com/syzbot-assets/049428496a18/bzImage-2004cef1.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+37757dc11ee77ef850bb@syzkaller.appspotmail.com

program syz-executor305 is using a deprecated SCSI ioctl, please convert it to SG_IO
Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP KASAN NOPTI
KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
CPU: 0 UID: 0 PID: 5092 Comm: syz-executor305 Not tainted 6.11.0-syzkaller-07337-g2004cef11ea0 #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
RIP: 0010:ata_msense_control_spgt2 drivers/ata/libata-scsi.c:2276 [inline]
RIP: 0010:ata_msense_control+0x966/0x1cf0 drivers/ata/libata-scsi.c:2358
Code: b6 04 10 84 c0 0f 85 9b 0f 00 00 4c 89 e8 48 c1 e8 03 0f b6 04 10 84 c0 0f 85 b6 0f 00 00 66 c7 03 00 e4 49 89 ec 49 c1 ec 03 <41> 0f b6 04 14 84 c0 0f 85 cc 0f 00 00 0f b6 5d 00 c0 e3 04 80 e3
RSP: 0018:ffffc90002d8f068 EFLAGS: 00010046
RAX: 0000000000000000 RBX: ffffffff9a7036be RCX: 0000000000000000
RDX: dffffc0000000000 RSI: 0000000000000000 RDI: ffffffff9a7036bd
RBP: 0000000000000000 R08: 0000000000000005 R09: 0000000000000003
R10: ffffffff9a7036b3 R11: fffffbfff34e06d8 R12: 0000000000000000
R13: ffffffff9a7036bf R14: 0000000000000046 R15: ffff888034faadf8
FS:  00005555605c5380(0000) GS:ffff88801fe00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020000380 CR3: 000000003dd82000 CR4: 0000000000350ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 ata_scsiop_mode_sense drivers/ata/libata-scsi.c:2474 [inline]
 ata_scsi_rbuf_fill drivers/ata/libata-scsi.c:1815 [inline]
 ata_scsi_simulate+0x1ae8/0x2320 drivers/ata/libata-scsi.c:4316
 __ata_scsi_queuecmd+0x21e/0x1030 drivers/ata/libata-scsi.c:4191
 ata_scsi_queuecmd+0x3bb/0x530 drivers/ata/libata-scsi.c:4234
 scsi_dispatch_cmd drivers/scsi/scsi_lib.c:1608 [inline]
 scsi_queue_rq+0x1d7c/0x2e90 drivers/scsi/scsi_lib.c:1850
 blk_mq_dispatch_rq_list+0xb89/0x1b30 block/blk-mq.c:2032
 __blk_mq_sched_dispatch_requests+0x424/0x1840 block/blk-mq-sched.c:301
 blk_mq_sched_dispatch_requests+0xcb/0x140 block/blk-mq-sched.c:331
 blk_mq_run_hw_queue+0x9a5/0xae0 block/blk-mq.c:2245
 blk_execute_rq+0x239/0x4b0 block/blk-mq.c:1398
 sg_scsi_ioctl drivers/scsi/scsi_ioctl.c:593 [inline]
 scsi_ioctl+0x222f/0x2d80 drivers/scsi/scsi_ioctl.c:901
 sg_ioctl_common drivers/scsi/sg.c:1109 [inline]
 sg_ioctl+0x16e9/0x2e80 drivers/scsi/sg.c:1163
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:907 [inline]
 __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f83297361a9
Code: 48 83 c4 28 c3 e8 37 17 00 00 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fffb0f41208 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007fffb0f413d8 RCX: 00007f83297361a9
RDX: 0000000020000380 RSI: 0000000000000001 RDI: 0000000000000003
RBP: 00007f83297a9610 R08: 002367732f766564 R09: 00007fffb0f413d8
R10: 000000000000001f R11: 0000000000000246 R12: 0000000000000001
R13: 00007fffb0f413c8 R14: 0000000000000001 R15: 0000000000000001
 </TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:ata_msense_control_spgt2 drivers/ata/libata-scsi.c:2276 [inline]
RIP: 0010:ata_msense_control+0x966/0x1cf0 drivers/ata/libata-scsi.c:2358
Code: b6 04 10 84 c0 0f 85 9b 0f 00 00 4c 89 e8 48 c1 e8 03 0f b6 04 10 84 c0 0f 85 b6 0f 00 00 66 c7 03 00 e4 49 89 ec 49 c1 ec 03 <41> 0f b6 04 14 84 c0 0f 85 cc 0f 00 00 0f b6 5d 00 c0 e3 04 80 e3
RSP: 0018:ffffc90002d8f068 EFLAGS: 00010046
RAX: 0000000000000000 RBX: ffffffff9a7036be RCX: 0000000000000000
RDX: dffffc0000000000 RSI: 0000000000000000 RDI: ffffffff9a7036bd
RBP: 0000000000000000 R08: 0000000000000005 R09: 0000000000000003
R10: ffffffff9a7036b3 R11: fffffbfff34e06d8 R12: 0000000000000000
R13: ffffffff9a7036bf R14: 0000000000000046 R15: ffff888034faadf8
FS:  00005555605c5380(0000) GS:ffff88801fe00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020000380 CR3: 000000003dd82000 CR4: 0000000000350ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess):
   0:	b6 04                	mov    $0x4,%dh
   2:	10 84 c0 0f 85 9b 0f 	adc    %al,0xf9b850f(%rax,%rax,8)
   9:	00 00                	add    %al,(%rax)
   b:	4c 89 e8             	mov    %r13,%rax
   e:	48 c1 e8 03          	shr    $0x3,%rax
  12:	0f b6 04 10          	movzbl (%rax,%rdx,1),%eax
  16:	84 c0                	test   %al,%al
  18:	0f 85 b6 0f 00 00    	jne    0xfd4
  1e:	66 c7 03 00 e4       	movw   $0xe400,(%rbx)
  23:	49 89 ec             	mov    %rbp,%r12
  26:	49 c1 ec 03          	shr    $0x3,%r12
* 2a:	41 0f b6 04 14       	movzbl (%r12,%rdx,1),%eax <-- trapping instruction
  2f:	84 c0                	test   %al,%al
  31:	0f 85 cc 0f 00 00    	jne    0x1003
  37:	0f b6 5d 00          	movzbl 0x0(%rbp),%ebx
  3b:	c0 e3 04             	shl    $0x4,%bl
  3e:	80                   	.byte 0x80
  3f:	e3                   	.byte 0xe3


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

Re: [syzbot] [ide?] general protection fault in ata_msense_control

[Jeongjun Park]

#syz test git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

---
 drivers/ata/libata-scsi.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 3328a6febc13..6f5527f12b0e 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -2442,7 +2442,9 @@ static unsigned int ata_scsiop_mode_sense(struct ata_scsi_args *args, u8 *rbuf)
 	if (spg) {
 		switch (spg) {
 		case ALL_SUB_MPAGES:
-			break;
+			if (dev->flags & ATA_DFLAG_CDL)
+				break;
+			fallthrough;
 		case CDL_T2A_SUB_MPAGE:
 		case CDL_T2B_SUB_MPAGE:
 		case ATA_FEATURE_SUB_MPAGE:
--

Re: [syzbot] [ide?] general protection fault in ata_msense_control

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-by: syzbot+37757dc11ee77ef850bb@syzkaller.appspotmail.com
Tested-by: syzbot+37757dc11ee77ef850bb@syzkaller.appspotmail.com

Tested on:

commit:         1868f9d0 Merge tag 'for-linux-6.12-ofs1' of git://git...
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=16960080580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=d0b35925215243c6
dashboard link: https://syzkaller.appspot.com/bug?extid=37757dc11ee77ef850bb
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
patch:          https://syzkaller.appspot.com/x/patch.diff?x=12c3f607980000

Note: testing is done by a robot and is best-effort only.