From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18475C7619A for ; Mon, 27 Mar 2023 01:30:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230227AbjC0BaS (ORCPT ); Sun, 26 Mar 2023 21:30:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbjC0BaP (ORCPT ); Sun, 26 Mar 2023 21:30:15 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59CD04680; Sun, 26 Mar 2023 18:30:11 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 27CE024E13F; Mon, 27 Mar 2023 09:29:55 +0800 (CST) Received: from EXMBX162.cuchost.com (172.16.6.72) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 27 Mar 2023 09:29:55 +0800 Received: from [192.168.120.42] (171.223.208.138) by EXMBX162.cuchost.com (172.16.6.72) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 27 Mar 2023 09:29:53 +0800 Message-ID: <670108d3-d8d7-102b-75fc-52e2db8945f2@starfivetech.com> Date: Mon, 27 Mar 2023 09:29:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v8 6/6] net: stmmac: starfive_dmac: Add phy interface settings Content-Language: en-US To: Emil Renner Berthing CC: , , , , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Jose Abreu , Richard Cochran , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Lunn , Heiner Kallweit , Peter Geis , Yanhong Wang , Tommaso Merciai References: <20230324022819.2324-1-samin.guo@starfivetech.com> <20230324022819.2324-7-samin.guo@starfivetech.com> From: Guo Samin In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX162.cuchost.com (172.16.6.72) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Re: [PATCH v8 6/6] net: stmmac: starfive_dmac: Add phy interface settings From: Emil Renner Berthing to: Samin Guo data: 2023/3/24 > On Fri, 24 Mar 2023 at 03:30, Samin Guo wrote: >> >> dwmac supports multiple modess. When working under rmii and rgmii, >> you need to set different phy interfaces. >> >> According to the dwmac document, when working in rmii, it needs to be >> set to 0x4, and rgmii needs to be set to 0x1. >> >> The phy interface needs to be set in syscon, the format is as follows: >> starfive,syscon: <&syscon, offset, shift> >> >> Tested-by: Tommaso Merciai >> Signed-off-by: Samin Guo >> --- >> .../ethernet/stmicro/stmmac/dwmac-starfive.c | 47 +++++++++++++++++++ >> 1 file changed, 47 insertions(+) >> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c >> index ef5a769b1c75..84690c8f0250 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c >> @@ -13,6 +13,10 @@ >> >> #include "stmmac_platform.h" >> >> +#define STARFIVE_DWMAC_PHY_INFT_RGMII 0x1 >> +#define STARFIVE_DWMAC_PHY_INFT_RMII 0x4 >> +#define STARFIVE_DWMAC_PHY_INFT_FIELD 0x7U >> + >> struct starfive_dwmac { >> struct device *dev; >> struct clk *clk_tx; >> @@ -44,6 +48,43 @@ static void starfive_dwmac_fix_mac_speed(void *priv, unsigned int speed) >> dev_err(dwmac->dev, "failed to set tx rate %lu\n", rate); >> } >> >> +static int starfive_dwmac_set_mode(struct plat_stmmacenet_data *plat_dat) >> +{ >> + struct starfive_dwmac *dwmac = plat_dat->bsp_priv; >> + struct regmap *regmap; >> + unsigned int args[2]; >> + unsigned int mode; >> + >> + switch (plat_dat->interface) { >> + case PHY_INTERFACE_MODE_RMII: >> + mode = STARFIVE_DWMAC_PHY_INFT_RMII; >> + break; >> + >> + case PHY_INTERFACE_MODE_RGMII: >> + case PHY_INTERFACE_MODE_RGMII_ID: >> + mode = STARFIVE_DWMAC_PHY_INFT_RGMII; >> + break; >> + >> + default: >> + dev_err(dwmac->dev, "unsupported interface %d\n", >> + plat_dat->interface); >> + return -EINVAL; >> + } >> + >> + regmap = syscon_regmap_lookup_by_phandle_args(dwmac->dev->of_node, >> + "starfive,syscon", >> + 2, args); >> + if (IS_ERR(regmap)) { >> + dev_err(dwmac->dev, "syscon regmap failed.\n"); >> + return -ENXIO; >> + } >> + >> + /* args[0]:offset args[1]: shift */ >> + return regmap_update_bits(regmap, args[0], >> + STARFIVE_DWMAC_PHY_INFT_FIELD << args[1], >> + mode << args[1]); >> +} >> + >> static int starfive_dwmac_probe(struct platform_device *pdev) >> { >> struct plat_stmmacenet_data *plat_dat; >> @@ -89,6 +130,12 @@ static int starfive_dwmac_probe(struct platform_device *pdev) >> plat_dat->bsp_priv = dwmac; >> plat_dat->dma_cfg->dche = true; >> >> + err = starfive_dwmac_set_mode(plat_dat); >> + if (err) { >> + dev_err(&pdev->dev, "dwmac set mode failed.\n"); >> + return err; >> + } > > Usually it's better to keep all error messages at the same "level". > Like this you'll get two error messages if > syscon_regmap_lookup_by_phandle_args fails. So I'd suggest moving this > message into the starfive_dwmac_set_mode function and while you're at > it you can do > > err = regmap_update_bits(...); > if (err) > return dev_err_probe(dwmac->dev, err, "error setting phy mode\n"); > > Also the file is called dwmac-starfive.c, so I'd expect the patch > header to be "net: stmmac: dwmac-starfive: Add phy interface > settings". > > /Emil > Thanks, the next version will be optimized. Best regards, Samin >> err = stmmac_dvr_probe(&pdev->dev, plat_dat, &stmmac_res); >> if (err) { >> stmmac_remove_config_dt(pdev, plat_dat); >> -- >> 2.17.1 >> >> >> _______________________________________________ >> linux-riscv mailing list >> linux-riscv@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-riscv