From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753613AbbKXMuR (ORCPT ); Tue, 24 Nov 2015 07:50:17 -0500 Received: from mail.efficios.com ([78.47.125.74]:47293 "EHLO mail.efficios.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753431AbbKXMuP (ORCPT ); Tue, 24 Nov 2015 07:50:15 -0500 Date: Tue, 24 Nov 2015 12:50:04 +0000 (UTC) From: Mathieu Desnoyers To: rostedt Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Peter Zijlstra Message-ID: <671305361.148742.1448369404193.JavaMail.zimbra@efficios.com> In-Reply-To: <20151123164643.04f8601d@gandalf.local.home> References: <1446504164-21563-1-git-send-email-mathieu.desnoyers@efficios.com> <1446504164-21563-2-git-send-email-mathieu.desnoyers@efficios.com> <20151123164643.04f8601d@gandalf.local.home> Subject: Re: [PATCH 2/3] ftrace: add ftrace-buffer option MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [78.47.125.74] X-Mailer: Zimbra 8.6.0_GA_1178 (ZimbraWebClient - FF42 (Linux)/8.6.0_GA_1178) Thread-Topic: ftrace: add ftrace-buffer option Thread-Index: OKWTV2/uW0x0q76h0qDD+nTyep0WMg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- On Nov 23, 2015, at 4:46 PM, rostedt rostedt@goodmis.org wrote: > On Mon, 2 Nov 2015 17:42:43 -0500 > Mathieu Desnoyers wrote: > >> In order to use ftrace tracers to generate tracepoints without doing >> tracing to its own hardcoded ring buffers, add a ftrace-buffer option >> (default: 1). When set to 0, it disables tracing into the ftrace >> hardcoded buffers. >> > > This should be a tracer specific option. And it shouldn't be called > "ftrace-buffer" as that is a very confusing name. > > Perhaps I can add an option that will prevent the snapshots as well. > Perhaps an option called "quiet", and a "no_snapshot" one too. I can > create the no snapshot one. But this should be converted to "quiet" and > added as a tracer specific option. Sure, I can add the "quiet" option to the irqsoff/irqspreemptoff tracers if that's the route you recommend, Thanks! Mathieu > > -- Steve > > >> Signed-off-by: Mathieu Desnoyers >> CC: Thomas Gleixner >> CC: Steven Rostedt >> CC: Ingo Molnar >> CC: Peter Zijlstra >> --- >> kernel/trace/trace.c | 4 +++- >> kernel/trace/trace.h | 1 + >> kernel/trace/trace_irqsoff.c | 19 +++++++++++-------- > > 3 files changed, 15 insertions(+), 9 deletions(-) -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com