Re: [PATCH 2/3] ftrace: add ftrace-buffer option

Mathieu Desnoyers
2015-11-24T12:50:17Z

----- On Nov 23, 2015, at 4:46 PM, rostedt rostedt@goodmis.org wrote:

> On Mon, 2 Nov 2015 17:42:43 -0500
> Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
>
>> In order to use ftrace tracers to generate tracepoints without doing
>> tracing to its own hardcoded ring buffers, add a ftrace-buffer option
>> (default: 1). When set to 0, it disables tracing into the ftrace
>> hardcoded buffers.
>>
>
> This should be a tracer specific option. And it shouldn't be called
> "ftrace-buffer" as that is a very confusing name.
>
> Perhaps I can add an option that will prevent the snapshots as well.
> Perhaps an option called "quiet", and a "no_snapshot" one too. I can
> create the no snapshot one. But this should be converted to "quiet" and
> added as a tracer specific option.

Sure, I can add the "quiet" option to the irqsoff/irqspreemptoff
tracers if that's the route you recommend,

Thanks!

Mathieu

>
> -- Steve
>
>
>> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
>> CC: Thomas Gleixner <tglx@linutronix.de>
>> CC: Steven Rostedt <rostedt@goodmis.org>
>> CC: Ingo Molnar <mingo@redhat.com>
>> CC: Peter Zijlstra <peterz@infradead.org>
>> ---
>> kernel/trace/trace.c | 4 +++-
>> kernel/trace/trace.h | 1 +
>> kernel/trace/trace_irqsoff.c | 19 +++++++++++--------
> > 3 files changed, 15 insertions(+), 9 deletions(-)

--
Mathieu Desnoyers
EfficiOS Inc.