From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: boqun.feng@gmail.com, linux-kernel@vger.kernel.org,
Len Brown <lenb@kernel.org>,
"open list:ACPI" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 22/30] ACPI: OSL: Add missing annotation for acpi_os_acquire_lock()
Date: Wed, 04 Mar 2020 12:00:19 +0100 [thread overview]
Message-ID: <6715482.taCdthcxpl@kreacher> (raw)
In-Reply-To: <20200223231711.157699-23-jbi.octave@gmail.com>
On Monday, February 24, 2020 12:17:03 AM CET Jules Irenge wrote:
> Sparse reports a warning at acpi_os_acquire_lock()
>
> warning: context imbalance in acpi_os_acquire_lock() - unexpected unlock
>
> The root cause is the missing annotation at acpi_os_acquire_lock()
> Add the missing annotation __acquires(lockp)
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/acpi/osl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 41168c027a5a..7094abc5ffc6 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -1598,6 +1598,7 @@ void acpi_os_delete_lock(acpi_spinlock handle)
> */
>
> acpi_cpu_flags acpi_os_acquire_lock(acpi_spinlock lockp)
> + __acquires(lockp)
> {
> acpi_cpu_flags flags;
> spin_lock_irqsave(lockp, flags);
>
Merged with the [23/30] and applied with modified subject and changelog as
5.7 material.
Thanks!
next prev parent reply other threads:[~2020-03-04 11:00 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/30>
2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
2020-02-14 20:47 ` [PATCH 01/30] x86/apic/vector: Add missing annotation to lock_vector_lock(void) Jules Irenge
2020-02-14 20:47 ` [PATCH 02/30] " Jules Irenge
2020-02-14 20:47 ` [PATCH 03/30] mm/memcontrol: Add missing annotation for unlock_page_lru() Jules Irenge
2020-02-14 20:47 ` [PATCH 04/30] mm/memcontrol: Add missing annotation for lock_page_lru() Jules Irenge
2020-02-14 20:47 ` [PATCH 05/30] mm/compaction: Add missing annotation for compact_lock_irqsave Jules Irenge
2020-02-14 20:47 ` [PATCH 06/30] mm/hugetlb: Add missing annotation for gather_surplus_pages() Jules Irenge
2020-02-14 23:40 ` Mike Kravetz
2020-02-14 20:47 ` [PATCH 07/30] mm/mempolicy: Add missing annotation for queue_pages_pmd() Jules Irenge
2020-02-14 20:47 ` [PATCH 08/30] mm/slub: Add missing annotation for get_map() Jules Irenge
2020-02-14 20:47 ` [PATCH 09/30] mm/slub: Add missing annotation for put_map() Jules Irenge
2020-02-14 20:47 ` [PATCH 10/30] mm/zsmalloc: Add missing annotation for migrate_read_lock() Jules Irenge
2020-02-27 21:52 ` Minchan Kim
2020-02-27 21:52 ` Minchan Kim
2020-02-14 20:47 ` [PATCH 11/30] mm/zsmalloc: Add missing annotation for migrate_read_unlock() Jules Irenge
2020-02-27 21:54 ` Minchan Kim
2020-02-14 20:47 ` [PATCH 12/30] mm/zsmalloc: Add missing annotation for pin_tag() Jules Irenge
2020-02-27 21:53 ` Minchan Kim
2020-02-14 20:47 ` [PATCH 13/30] mm/zsmalloc: Add missing annotation for unpin_tag() Jules Irenge
2020-02-27 21:53 ` Minchan Kim
2020-02-14 20:47 ` [PATCH 14/30] x86/xen: Add missing annotation for xen_pte_lock() Jules Irenge
2020-02-14 22:40 ` [Xen-devel] " Boris Ostrovsky
2020-02-15 21:13 ` Jules Irenge
2020-02-14 20:47 ` [PATCH 15/30] x86/xen: Add missing annotation for xen_pte_unlock() Jules Irenge
2020-02-14 20:47 ` [PATCH 16/30] drm/vkms: Add missing annotation for vkms_crtc_atomic_begin() Jules Irenge
2020-02-14 20:47 ` [PATCH 17/30] drm/vkms: Add missing annotation for vkms_crtc_atomic_flush() Jules Irenge
2020-02-14 20:47 ` [PATCH 18/30] driver core: Add missing annotation for device_links_write_lock() Jules Irenge
2020-02-14 20:47 ` [PATCH 19/30] driver core: Add missing annotation for device_links_read_lock() Jules Irenge
2020-02-14 20:47 ` [PATCH 20/30] pcnet32: Add missing annotation for pcnet32_suspend() Jules Irenge
2020-02-14 20:47 ` [PATCH 21/30] sfc: Add missing annotation for efx_ef10_try_update_nic_stats_vf() Jules Irenge
2020-02-17 18:00 ` Martin Habets
2020-02-14 20:47 ` [PATCH 22/30] xhci: Add missing annotation for xhci_set_port_power() Jules Irenge
2020-02-14 20:47 ` [PATCH 23/30] xhci: Add missing annotation for xhci_enter_test_mode Jules Irenge
2020-02-14 20:47 ` [PATCH 24/30] tipc: Add missing annotation for tipc_node_read_lock() Jules Irenge
2020-02-14 20:47 ` [PATCH 25/30] tipc: Add missing annotation for tipc_node_read_unlock() Jules Irenge
2020-02-14 20:47 ` [PATCH 26/30] tipc: Add missing annotation for tipc_node_write_lock() Jules Irenge
2020-02-14 20:47 ` [PATCH 27/30] tipc: Add missing annotation for tipc_node_write_unlock_fast() Jules Irenge
2020-02-14 20:47 ` [PATCH 28/30] tipc: Add missing annotation for tipc_node_write_unlock() Jules Irenge
2020-02-14 20:47 ` [PATCH 29/30] net: Add missing annotation for netlink_walk_start() Jules Irenge
2020-02-14 20:47 ` [PATCH 30/30] net: Add missing annotation for netlink_walk_stop() Jules Irenge
2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
2020-02-23 23:16 ` [PATCH 01/30] btrfs: Add missing annotation for release_extent_buffer() Jules Irenge
2020-02-23 23:27 ` Nikolay Borisov
2020-02-24 15:19 ` David Sterba
2020-02-23 23:16 ` [PATCH 02/30] dax: Add missing annotations ofr dax_read_lock() and dax_read_unlock() Jules Irenge
2020-02-24 1:23 ` Yi Zhang
2020-02-23 23:16 ` [PATCH 03/30] xfs: Add missing annotation to xfs_ail_check() Jules Irenge
2020-02-25 15:44 ` Darrick J. Wong
2020-02-23 23:16 ` [PATCH 04/30] sctp: Add missing annotation for sctp_err_finish() Jules Irenge
2020-02-24 21:28 ` David Miller
2020-02-23 23:16 ` [PATCH 05/30] sctp: Add missing annotation for sctp_transport_walk_start() Jules Irenge
2020-02-24 21:28 ` David Miller
2020-02-23 23:16 ` [PATCH 06/30] sctp: Add missing annotation for sctp_transport_walk_stop() Jules Irenge
2020-02-24 21:28 ` David Miller
2020-02-23 23:16 ` [PATCH 07/30] net: Add missing annotation for llc_seq_start() Jules Irenge
2020-02-24 21:28 ` David Miller
2020-02-23 23:16 ` [PATCH 08/30] netrom: Add missing annotation for nr_info_start() Jules Irenge
2020-02-24 21:29 ` David Miller
2020-02-23 23:16 ` [PATCH 09/30] netrom: Add missing annotation for nr_info_stop() Jules Irenge
2020-02-24 21:29 ` David Miller
2020-02-23 23:16 ` [PATCH 10/30] net: netrom: Add missing annotation for nr_node_start() Jules Irenge
2020-02-24 21:29 ` David Miller
2020-02-23 23:16 ` [PATCH 11/30] net: netrom: Add missing annotation for nr_node_stop() Jules Irenge
2020-02-24 21:29 ` David Miller
2020-02-23 23:16 ` [PATCH 12/30] net: netrom: Add missing annotation for nr_neigh_start() Jules Irenge
2020-02-24 21:29 ` David Miller
2020-02-23 23:16 ` [PATCH 13/30] net: netrom: Add missing annotation for nr_neigh_stop() Jules Irenge
2020-02-24 21:29 ` David Miller
2020-02-23 23:16 ` [PATCH 14/30] dccp: Add missing annotation for dccp_child_process() Jules Irenge
2020-02-24 21:29 ` David Miller
2020-02-23 23:16 ` [PATCH 15/30] af_unix: Add missing annotation for unix_wait_for_peer() Jules Irenge
2020-02-24 21:29 ` David Miller
2020-02-23 23:16 ` [PATCH 16/30] proc: Add missing annotation for close_pdeo() Jules Irenge
2020-02-23 23:16 ` [PATCH 17/30] mm/zsmalloc: Add missing annotation for zs_map_object() Jules Irenge
2020-02-23 23:16 ` [PATCH 18/30] mm/zsmalloc: Add missing annotation for zs_unmap_object() Jules Irenge
2020-02-23 23:17 ` [PATCH 19/30] mm/zsmalloc: Add missing annotation for migrate_write_lock() Jules Irenge
2020-02-23 23:17 ` [PATCH 20/30] mm/zsmalloc: Add missing annotation for migrate_write_unlock() Jules Irenge
2020-02-23 23:17 ` [PATCH 21/30] scsi: csiostor: Add missing annotation for csio_scsi_cleanup_io_q() Jules Irenge
2020-02-23 23:17 ` [PATCH 22/30] ACPI: OSL: Add missing annotation for acpi_os_acquire_lock() Jules Irenge
2020-03-04 11:00 ` Rafael J. Wysocki [this message]
2020-02-23 23:17 ` [PATCH 23/30] ACPI: OSL: Add missing annotation for acpi_os_release_lock() Jules Irenge
2020-02-23 23:17 ` [PATCH 24/30] dmaengine: mic_x100_dma: Add missing annotation for mic_dma_tx_submit_unlock() Jules Irenge
2020-02-23 23:17 ` [PATCH 25/30] zram: Add missing annotatin for zram_slot_lock() Jules Irenge
2020-02-23 23:17 ` [PATCH 26/30] zram: Add missing annotatin for zram_slot_unlock() Jules Irenge
2020-02-23 23:17 ` [PATCH 27/30] habanalabs: Add missing annotation for goya_hw_queues_lock() Jules Irenge
2020-02-25 11:55 ` Oded Gabbay
2020-02-23 23:17 ` [PATCH 28/30] habanalabs: Add missing annotation for goya_hw_queues_unlock() Jules Irenge
2020-02-25 11:56 ` Oded Gabbay
2020-02-23 23:17 ` [PATCH 29/30] sgi-xp: Add missing annotation for xpc_disconnect_channel() Jules Irenge
2020-02-28 19:22 ` Robin Holt
2020-02-23 23:17 ` [PATCH 30/30] sgi-xp: Add missing annotation for ocfs2_inode_cache_lock() and ocfs2_inode_cache_unlock() Jules Irenge
2020-02-24 1:52 ` Joseph Qi
2020-02-25 0:54 ` Joseph Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6715482.taCdthcxpl@kreacher \
--to=rjw@rjwysocki.net \
--cc=boqun.feng@gmail.com \
--cc=jbi.octave@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox