Re: [PATCH v2 11/15] blktrace: add block trace commands for zone operations

Christoph Hellwig
2025-10-03T07:33:02Z

On Thu, Sep 25, 2025 at 05:02:27PM +0200, Johannes Thumshirn wrote:
> Add block trace commands for zone operations. These are added as a
> separate set of 'block trace commands' shifted by 32bit so that they do
> not interfere with the old 16bit wide trace command field in 'struct
> blk_io_trace' action.

Can you explain how the commands are handled for old/new here?

Because I'd still much prefer to sort things out so that they make
sense for the new code if possible. i.e. have a 32-bit command
and 32 bit flags, and use sensible encoding for the new one, and
remap the supported once to the old organically grown one.