Re: [PATCH v2 11/15] blktrace: add block trace commands for zone operations

Damien Le Moal
2025-10-01T07:23:27Z

On 9/26/25 00:02, Johannes Thumshirn wrote:
> Add block trace commands for zone operations. These are added as a
> separate set of 'block trace commands' shifted by 32bit so that they do
> not interfere with the old 16bit wide trace command field in 'struct
> blk_io_trace' action.
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> ---
> include/uapi/linux/blktrace_api.h | 13 ++++++++++++-
> kernel/trace/blktrace.c | 18 ++++++++++++++++++
> 2 files changed, 30 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/blktrace_api.h b/include/uapi/linux/blktrace_api.h
> index d58ef484de49..0f336140ce4e 100644
> --- a/include/uapi/linux/blktrace_api.h
> +++ b/include/uapi/linux/blktrace_api.h
> @@ -26,11 +26,22 @@ enum blktrace_cat {
> BLK_TC_DRV_DATA = 1 << 14, /* binary per-driver data */
> BLK_TC_FUA = 1 << 15, /* fua requests */
>
> - BLK_TC_END = 1 << 15, /* we've run out of bits! */
> + BLK_TC_END_V1 = 1 << 15, /* we've run out of bits! */
> +
> + BLK_TC_ZONE_APPEND = 1 << 16ull, /* zone append */
> + BLK_TC_ZONE_RESET = 1 << 17ull, /* zone reset */
> + BLK_TC_ZONE_RESET_ALL = 1 << 18ull, /* zone reset all */
> + BLK_TC_ZONE_FINISH = 1 << 19ull, /* zone finish */
> + BLK_TC_ZONE_OPEN = 1 << 20ull, /* zone open */
> + BLK_TC_ZONE_CLOSE = 1 << 21ull, /* zone close */

Isn't it more common/correct to do "1ULL << 21" ?

--
Damien Le Moal
Western Digital Research