[syzbot] [kernel?] WARNING in get_pat_info

[syzbot] [kernel?] WARNING in get_pat_info

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit:    67784a74e258 Merge tag 'ata-6.11-rc7' of git://git.kernel...
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=12ac82ab980000
kernel config:  https://syzkaller.appspot.com/x/.config?x=931962fa28089080
dashboard link: https://syzkaller.appspot.com/bug?extid=16b1da89309a06cd0e3a
compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/5d04638ac9ee/disk-67784a74.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/2b56a931235c/vmlinux-67784a74.xz
kernel image: https://storage.googleapis.com/syzbot-assets/3b447615c560/bzImage-67784a74.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+16b1da89309a06cd0e3a@syzkaller.appspotmail.com

------------[ cut here ]------------
WARNING: CPU: 1 PID: 7739 at include/linux/rwsem.h:195 rwsem_assert_held include/linux/rwsem.h:195 [inline]
WARNING: CPU: 1 PID: 7739 at include/linux/rwsem.h:195 mmap_assert_locked include/linux/mmap_lock.h:65 [inline]
WARNING: CPU: 1 PID: 7739 at include/linux/rwsem.h:195 follow_pte+0x414/0x4c0 mm/memory.c:6133
Modules linked in:
CPU: 1 UID: 0 PID: 7739 Comm: syz.1.945 Not tainted 6.11.0-rc6-syzkaller-00019-g67784a74e258 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
R13: ffffc90004cff530 R14: ffffc90004cff550 R15: ffff88801e6e2600
FS:  00007f7831aab6c0(0000) GS:ffff8880b8900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000000110c379ecd CR3: 000000002ad46000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 follow_phys arch/x86/mm/pat/memtype.c:957 [inline]
 get_pat_info+0xf2/0x510 arch/x86/mm/pat/memtype.c:991
 unmap_mapping_range_vma mm/memory.c:3734 [inline]
 unmap_mapping_range_tree mm/memory.c:3751 [inline]
 unmap_mapping_pages mm/memory.c:3817 [inline]
 unmap_mapping_range+0x1ee/0x280 mm/memory.c:3854
RIP: 0033:0x7f7830d79eb9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f7831aab038 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 00007f7830f15f80 RCX: 00007f7830d79eb9
RDX: 0000000000000300 RSI: 0000000020000080 RDI: ffffffffffffff9c
RBP: 00007f7830de793e R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f7830f15f80 R15: 00007ffd316c3c28
 </TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

Re: [syzbot] [kernel?] WARNING in get_pat_info

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit:    7758b206117d Merge tag 'tracefs-v6.12-rc6' of git://git.ke..
git tree:       upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=10f6bd5f980000
kernel config:  https://syzkaller.appspot.com/x/.config?x=921b01cbfd887a9b
dashboard link: https://syzkaller.appspot.com/bug?extid=16b1da89309a06cd0e3a
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=148adf40580000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1704ae30580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/4535eeeccbd4/disk-7758b206.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/f7f34cce38f1/vmlinux-7758b206.xz
kernel image: https://storage.googleapis.com/syzbot-assets/626c3346b3bd/bzImage-7758b206.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+16b1da89309a06cd0e3a@syzkaller.appspotmail.com

Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffccfb961e8 EFLAGS: 00000246 ORIG_RAX: 0000000000000009
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007fc6265e02e9
RDX: 0000000000000000 RSI: 0000000000003000 RDI: 0000000020ff6000
RBP: 0000000000000002 R08: 0000000000000003 R09: 0000000000000000
R10: 0000000000000013 R11: 0000000000000246 R12: 00007fc626624153
R13: 00007ffccfb96260 R14: 00007fc62662a29c R15: 00007fc626624032
 </TASK>
------------[ cut here ]------------
WARNING: CPU: 0 PID: 5831 at arch/x86/mm/pat/memtype.c:983 get_pat_info+0x1eb/0x3f0 arch/x86/mm/pat/memtype.c:983
Modules linked in:
CPU: 0 UID: 0 PID: 5831 Comm: syz-executor181 Not tainted 6.12.0-rc6-syzkaller-00099-g7758b206117d #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
RIP: 0010:get_pat_info+0x1eb/0x3f0 arch/x86/mm/pat/memtype.c:983
Code: 00 00 00 48 89 de e8 c4 e0 50 00 48 83 fb 20 75 13 48 83 7c 24 10 00 0f 84 5e 01 00 00 e8 cd db 50 00 eb 09 e8 c6 db 50 00 90 <0f> 0b 90 b8 ea ff ff ff 48 c7 44 24 20 0e 36 e0 45 48 b9 00 00 00
RSP: 0018:ffffc90003e37020 EFLAGS: 00010293
RAX: ffffffff8143fe3a RBX: 0000000000000000 RCX: ffff88807c4d9e00
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000020
RBP: ffffc90003e37110 R08: ffffffff8143fe1c R09: 1ffffffff2037b8d
R10: dffffc0000000000 R11: fffffbfff2037b8e R12: 1ffff920007c6e08
R13: 1ffff1100f973597 R14: ffffc90003e37060 R15: ffff88807cb9ac98
FS:  0000555586d8f480(0000) GS:ffff8880b8600000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020000000 CR3: 0000000033636000 CR4: 00000000003526f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 untrack_pfn+0x327/0x640 arch/x86/mm/pat/memtype.c:1085
 unmap_single_vma+0x1f6/0x2b0 mm/memory.c:1834
 zap_page_range_single+0x45c/0x630 mm/memory.c:1935
 remap_pfn_range_notrack+0xc8e/0xe10 mm/memory.c:2708
 remap_pfn_range+0x12c/0x1b0 mm/memory.c:2733
 usbdev_mmap+0x4ba/0x900 drivers/usb/core/devio.c:276
 call_mmap include/linux/fs.h:2172 [inline]
 mmap_region+0x1689/0x2940 mm/mmap.c:1450
 do_mmap+0x8f0/0x1000 mm/mmap.c:496
 vm_mmap_pgoff+0x1dd/0x3d0 mm/util.c:588
 ksys_mmap_pgoff+0x4eb/0x720 mm/mmap.c:542
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fc6265e02e9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffccfb961e8 EFLAGS: 00000246 ORIG_RAX: 0000000000000009
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007fc6265e02e9
RDX: 0000000000000000 RSI: 0000000000003000 RDI: 0000000020ff6000
RBP: 0000000000000002 R08: 0000000000000003 R09: 0000000000000000
R10: 0000000000000013 R11: 0000000000000246 R12: 00007fc626624153
R13: 00007ffccfb96260 R14: 00007fc62662a29c R15: 00007fc626624032
 </TASK>
----------------
Code disassembly (best guess):
   0:	ff c3                	inc    %ebx
   2:	66 2e 0f 1f 84 00 00 	cs nopw 0x0(%rax,%rax,1)
   9:	00 00 00
   c:	0f 1f 44 00 00       	nopl   0x0(%rax,%rax,1)
  11:	48 89 f8             	mov    %rdi,%rax
  14:	48 89 f7             	mov    %rsi,%rdi
  17:	48 89 d6             	mov    %rdx,%rsi
  1a:	48 89 ca             	mov    %rcx,%rdx
  1d:	4d 89 c2             	mov    %r8,%r10
  20:	4d 89 c8             	mov    %r9,%r8
  23:	4c 8b 4c 24 08       	mov    0x8(%rsp),%r9
  28:	0f 05                	syscall
* 2a:	48 3d 01 f0 ff ff    	cmp    $0xfffffffffffff001,%rax <-- trapping instruction
  30:	73 01                	jae    0x33
  32:	c3                   	ret
  33:	48 c7 c1 b8 ff ff ff 	mov    $0xffffffffffffffb8,%rcx
  3a:	f7 d8                	neg    %eax
  3c:	64 89 01             	mov    %eax,%fs:(%rcx)
  3f:	48                   	rex.W


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

Re: [syzbot] [kernel?] WARNING in get_pat_info

[syzbot]

syzbot has bisected this issue to:

commit 79a61cc3fc0466ad2b7b89618a6157785f0293b3
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Thu Sep 12 00:11:23 2024 +0000

    mm: avoid leaving partial pfn mappings around in error case

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=11df65f7980000
start commit:   7758b206117d Merge tag 'tracefs-v6.12-rc6' of git://git.ke..
git tree:       upstream
final oops:     https://syzkaller.appspot.com/x/report.txt?x=13df65f7980000
console output: https://syzkaller.appspot.com/x/log.txt?x=15df65f7980000
kernel config:  https://syzkaller.appspot.com/x/.config?x=921b01cbfd887a9b
dashboard link: https://syzkaller.appspot.com/bug?extid=16b1da89309a06cd0e3a
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=148adf40580000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1704ae30580000

Reported-by: syzbot+16b1da89309a06cd0e3a@syzkaller.appspotmail.com
Fixes: 79a61cc3fc04 ("mm: avoid leaving partial pfn mappings around in error case")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Re: [syzbot] [kernel?] WARNING in get_pat_info

[David Hildenbrand]

On 11.11.24 07:40, syzbot wrote:
> syzbot has bisected this issue to:
> 
> commit 79a61cc3fc0466ad2b7b89618a6157785f0293b3
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date:   Thu Sep 12 00:11:23 2024 +0000
> 
>      mm: avoid leaving partial pfn mappings around in error case
> 
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=11df65f7980000
> start commit:   7758b206117d Merge tag 'tracefs-v6.12-rc6' of git://git.ke..
> git tree:       upstream
> final oops:     https://syzkaller.appspot.com/x/report.txt?x=13df65f7980000
> console output: https://syzkaller.appspot.com/x/log.txt?x=15df65f7980000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=921b01cbfd887a9b
> dashboard link: https://syzkaller.appspot.com/bug?extid=16b1da89309a06cd0e3a
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=148adf40580000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1704ae30580000
> 
> Reported-by: syzbot+16b1da89309a06cd0e3a@syzkaller.appspotmail.com
> Fixes: 79a61cc3fc04 ("mm: avoid leaving partial pfn mappings around in error case")
> 
> For information about bisection process see: https://goo.gl/tpsmEJ#bisection
> 

As discussed elsewhere [1], the patch [2] from Peter should fix this one.

I should probably resend both VM_PAT fixes that are on the list in a 
single series.

[1] 
https://lkml.kernel.org/r/262aa19c-59fe-420a-aeae-0b1866a3e36b@redhat.com

[2] 
https://lore.kernel.org/all/20240712144244.3090089-1-peterx@redhat.com/T/#u

-- 
Cheers,

David / dhildenb

Re: [syzbot] [kernel?] WARNING in get_pat_info

[syzbot]

syzbot suspects this issue was fixed by commit:

commit f8e97613fed25758ddf52159b87e1c66e619a23a
Author: David Hildenbrand <david@redhat.com>
Date:   Mon May 12 12:34:17 2025 +0000

    mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack()

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=12f1448c580000
start commit:   fac04efc5c79 Linux 6.13-rc2
git tree:       upstream
kernel config:  https://syzkaller.appspot.com/x/.config?x=fee25f93665c89ac
dashboard link: https://syzkaller.appspot.com/bug?extid=16b1da89309a06cd0e3a
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=13e2ab30580000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=11d113e8580000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack()

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Re: [syzbot] [kernel?] WARNING in get_pat_info

[David Hildenbrand]

On 30.06.25 22:06, syzbot wrote:
> syzbot suspects this issue was fixed by commit:
> 
> commit f8e97613fed25758ddf52159b87e1c66e619a23a
> Author: David Hildenbrand <david@redhat.com>
> Date:   Mon May 12 12:34:17 2025 +0000
> 
>      mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack()
> 
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=12f1448c580000
> start commit:   fac04efc5c79 Linux 6.13-rc2
> git tree:       upstream
> kernel config:  https://syzkaller.appspot.com/x/.config?x=fee25f93665c89ac
> dashboard link: https://syzkaller.appspot.com/bug?extid=16b1da89309a06cd0e3a
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=13e2ab30580000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=11d113e8580000
> 
> If the result looks correct, please mark the issue as fixed by replying with:
> 
> #syz fix: mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack()

Yes, that should be correct. I didnt't remember that we had a syzbot complaint
about that one, otherwise I would have tagged it.

#syz fix: mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack()

-- 
Cheers,

David / dhildenb