From: "Miquel Sabaté Solà" <mikisabate@gmail.com>
To: paul.walmsley@sifive.com
Cc: palmer@dabbelt.com, aou@eecs.berkeley.edu,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Jesse Taube <jesse@rivosinc.com>,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [RESEND PATCH v2] riscv: hwprobe: export Zicntr and Zihpm extensions
Date: Thu, 14 Nov 2024 07:37:20 +0100 [thread overview]
Message-ID: <67359aa2.050a0220.cc412.2c60@mx.google.com> (raw)
In-Reply-To: <66f1cc93.050a0220.bf7a0.30f3@mx.google.com> ("Miquel Sabaté Solà"'s message of "Mon, 23 Sep 2024 22:16:17 +0200")
[-- Attachment #1: Type: text/plain, Size: 3864 bytes --]
On dl., de set. 23 2024, Miquel Sabaté Solà wrote:
> On dv., de set. 13 2024, Miquel Sabaté Solà wrote:
>
>> Export Zicntr and Zihpm ISA extensions through the hwprobe syscall.
>>
>> Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
>> Acked-by: Jesse Taube <jesse@rivosinc.com>
>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>> ---
>> This is a resend because I sent v2 as a reply to the original thread and
>> it most probably was lost by most people. Fortunately Conor picked it up
>> and gave it a review.
>>
>> I am resending this so it can be properly applied. Thank you for your time and
>> sorry for the inconvenience.
>>
>> Changes since v1 [1]: the EXT_KEY instructions have been written in order.
>>
>> [1] https://lore.kernel.org/linux-riscv/20240817075629.262318-1-mikisabate@gmail.com/
>>
>> Documentation/arch/riscv/hwprobe.rst | 6 ++++++
>> arch/riscv/include/uapi/asm/hwprobe.h | 2 ++
>> arch/riscv/kernel/sys_hwprobe.c | 2 ++
>> 3 files changed, 10 insertions(+)
>>
>> diff --git a/Documentation/arch/riscv/hwprobe.rst b/Documentation/arch/riscv/hwprobe.rst
>> index 3db60a0911df..cfd2929d0562 100644
>> --- a/Documentation/arch/riscv/hwprobe.rst
>> +++ b/Documentation/arch/riscv/hwprobe.rst
>> @@ -183,6 +183,9 @@ The following keys are defined:
>> defined in the Atomic Compare-and-Swap (CAS) instructions manual starting
>> from commit 5059e0ca641c ("update to ratified").
>>
>> + * :c:macro:`RISCV_HWPROBE_EXT_ZICNTR`: The Zicntr extension version 2.0
>> + is supported as defined in the RISC-V ISA manual.
>> +
>> * :c:macro:`RISCV_HWPROBE_EXT_ZICOND`: The Zicond extension is supported as
>> defined in the RISC-V Integer Conditional (Zicond) operations extension
>> manual starting from commit 95cf1f9 ("Add changes requested by Ved
>> @@ -192,6 +195,9 @@ The following keys are defined:
>> supported as defined in the RISC-V ISA manual starting from commit
>> d8ab5c78c207 ("Zihintpause is ratified").
>>
>> + * :c:macro:`RISCV_HWPROBE_EXT_ZIHPM`: The Zihpm extension version 2.0
>> + is supported as defined in the RISC-V ISA manual.
>> +
>> * :c:macro:`RISCV_HWPROBE_EXT_ZVE32X`: The Vector sub-extension Zve32x is
>> supported, as defined by version 1.0 of the RISC-V Vector extension manual.
>>
>> diff --git a/arch/riscv/include/uapi/asm/hwprobe.h b/arch/riscv/include/uapi/asm/hwprobe.h
>> index b706c8e47b02..098a815b3fd4 100644
>> --- a/arch/riscv/include/uapi/asm/hwprobe.h
>> +++ b/arch/riscv/include/uapi/asm/hwprobe.h
>> @@ -72,6 +72,8 @@ struct riscv_hwprobe {
>> #define RISCV_HWPROBE_EXT_ZCF (1ULL << 46)
>> #define RISCV_HWPROBE_EXT_ZCMOP (1ULL << 47)
>> #define RISCV_HWPROBE_EXT_ZAWRS (1ULL << 48)
>> +#define RISCV_HWPROBE_EXT_ZICNTR (1ULL << 49)
>> +#define RISCV_HWPROBE_EXT_ZIHPM (1ULL << 50)
>> #define RISCV_HWPROBE_KEY_CPUPERF_0 5
>> #define RISCV_HWPROBE_MISALIGNED_UNKNOWN (0 << 0)
>> #define RISCV_HWPROBE_MISALIGNED_EMULATED (1 << 0)
>> diff --git a/arch/riscv/kernel/sys_hwprobe.c b/arch/riscv/kernel/sys_hwprobe.c
>> index 8d1b5c35d2a7..910b41b6a7ab 100644
>> --- a/arch/riscv/kernel/sys_hwprobe.c
>> +++ b/arch/riscv/kernel/sys_hwprobe.c
>> @@ -107,9 +107,11 @@ static void hwprobe_isa_ext0(struct riscv_hwprobe *pair,
>> EXT_KEY(ZCB);
>> EXT_KEY(ZCMOP);
>> EXT_KEY(ZICBOZ);
>> + EXT_KEY(ZICNTR);
>> EXT_KEY(ZICOND);
>> EXT_KEY(ZIHINTNTL);
>> EXT_KEY(ZIHINTPAUSE);
>> + EXT_KEY(ZIHPM);
>> EXT_KEY(ZIMOP);
>> EXT_KEY(ZKND);
>> EXT_KEY(ZKNE);
>
> Hello,
>
> Gently ping :) Can we get this merged for 6.12?
>
> Thanks!
> Miquel
Hello,
Gently ping :)
This will certainly not be included for 6.12, but is there a chance to
get it for 6.13?
Thanks,
Miquel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
prev parent reply other threads:[~2024-11-14 6:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 5:13 [RESEND PATCH v2] riscv: hwprobe: export Zicntr and Zihpm extensions Miquel Sabaté Solà
2024-09-23 20:16 ` Miquel Sabaté Solà
2024-11-14 6:37 ` Miquel Sabaté Solà [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67359aa2.050a0220.cc412.2c60@mx.google.com \
--to=mikisabate@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=jesse@rivosinc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox