From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1764342AbcINW4m (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Sep 2016 18:56:42 -0400
Received: from mout.kundenserver.de ([217.72.192.75]:57690 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755204AbcINW4k (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Sep 2016 18:56:40 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Jerome Brunet <jbrunet@baylibre.com>, Felipe Balbi <balbi@ti.com>,
        Peter Chen <peter.chen@freescale.com>, Rob Herring <robh@kernel.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: use of_usb_get_dr_mode_by_phy() inline helper without USB
Date: Thu, 15 Sep 2016 00:56:18 +0200
Message-ID: <6742169.XRyEUkvEM4@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <20160914135126.3122728-1-arnd@arndb.de>
References: <20160914135126.3122728-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:VLjXo8d1pIBWPErt5se4T/DUoR744OFLubYh4KPttkNptGKED1d
 j1K7go5yob2EkNSY3FoI4pLvSYEKeQnfr82jCDjpPmyO4QWeoxZdG7BqqZpa8StyNfzEfL6
 btoILOo3wbV7EL4WEjUiwCfgLzwyDWxk2Jb0KvaGniQLbffUNwZb42Xgwv11vErg7rjA0cd
 nV70bajl1r/9fOPrOpaWw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:X08Zuy0lv7U=:XqP112Tk9SGTRX2CIhCKVy
 Rv8xVUpsD3BP0sjhUVQpQlmvO8YisJ4EnfS8furF+Z5lgthLid3NGul8puapH+E2A2NxXnLGo
 +RoWv8nA5BdUVGumu3E0JwGmTnFZGtJnK2ekfq8fZpbY/fklgPK88xaJslLig9m5EQuEB63fY
 sQTvMXZzSW9PV6j76gHbeLJ0f7H4DxN+cthrtAVy/WK55Gj6nh1j9i0KW9H/RfqH0OfNPV7bi
 CYKoD+fg7bf+gu6zqIKO80YDZJhGRdTRyHVuunEJBwgMO0Ke2R6H0ky12MNz0AMkRLdXgUcuQ
 EN3BRdoncMlL5R1or+9Abg35iJLdsqxIMdtdBbJenMaaYPMc83VYhH+iDNvwdJlQEzSWGR/bg
 LVYAkxMFU+eGQ4zZMnhZU28I6hs5vBq6Tv7hjjX5K9w36KMPnBAxmXvKOIpjTfEavQZS+XNPT
 xymmnXNLxWx0mESmF28tLeWK8KsmsH3RQYgqdEOudF9nFTfZkECg53uVILc03VJtFkab+n+cw
 kYjaaw1HnX1vsFh72hshBruygm0RDmnNNDlwU5NzTOC0B8//mDPlDvkE9pPLKFeHiAn8n4atP
 al0TPk5sR8//g8QaSLjDCNZEhkAs+SYVpAxeDaykfAJcSVnK5vAKEAgm74Mc9+kGXuGv6azP7
 eFDPEmS6hOxf7M8aJY5Ez3qBSy5jtMVc8xkaj2k6F4Gd2TfD4aH8nfim1FA6xQvlslGnsT9BF
 2gIhTJ6cO/gyzuQE
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, September 14, 2016 3:51:01 PM CEST Arnd Bergmann wrote:
> We have had two new PHY drivers call of_usb_get_dr_mode_by_phy()
> recently without having a dependency on CONFIG_USB_COMMON, resulting
> in a link error:
> 
> ERROR: "of_usb_get_dr_mode_by_phy" [drivers/phy/phy-meson-usb2.ko] undefined!
> 
> I fixed up the first one (sun4i) by adding the dependency, but
> if we get more of this, it's probably better to allow the PHY
> drivers to build without the dependency.
> 
> This changes the guard around declarations so we only refer to
> them when both CONFIG_OF and CONFIG_USB_COMMON are enabled,
> which is the right thing for all of the first calls but not the
> one that already has a correct check for USB_SUPPORT rather than
> USB_COMMON.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 5ed935458519 ("phy: meson: add USB2 PHY support for Meson8b and GXBB")
> 

Please hold off applying for now, the randconfig builder came up with a
new build failure after this one, I have to investigate tomorrow.

	Arnd