From: Christian Marangi <ansuelsmth@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Antoine Tenart <atenart@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
upstream@airoha.com, Richard van Schagen <vschagen@icloud.com>
Subject: Re: [PATCH v7 3/3] crypto: Add Inside Secure SafeXcel EIP-93 crypto engine support
Date: Tue, 10 Dec 2024 21:51:50 +0100 [thread overview]
Message-ID: <6758a9e8.050a0220.b60b3.184c@mx.google.com> (raw)
In-Reply-To: <Z1hB2WftNhyGt9oj@gondor.apana.org.au>
On Tue, Dec 10, 2024 at 09:27:53PM +0800, Herbert Xu wrote:
> On Tue, Dec 10, 2024 at 01:16:42PM +0100, Christian Marangi wrote:
> >
> > Oh! Ok, that is neat. Just to make sure everything is clear,
> > to complete the request it's the same used for final, the
> > ahash_request_complete(). I tought the -EINPROGRESS,
> > ahash_request_complete() pattern was only for final.
>
> Correct, the same calling convention applies whether you're doing
> update or finup/final. One difference is that after final/finup
> you don't have to export the hash state because it's no longer
> defined.
>
I just sent v8 with the thing fixed. Hope everything is good now!
As always I passed it with the test flag enabled + extra and fuzz set to
10000.
--
Ansuel
prev parent reply other threads:[~2024-12-10 20:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 1:58 [PATCH v7 0/3] crypto: Add EIP-93 crypto engine support Christian Marangi
2024-11-12 1:58 ` [PATCH v7 1/3] spinlock: extend guard with spinlock_bh variants Christian Marangi
2024-11-12 1:58 ` [PATCH v7 2/3] dt-bindings: crypto: Add Inside Secure SafeXcel EIP-93 crypto engine Christian Marangi
2024-11-12 1:59 ` [PATCH v7 3/3] crypto: Add Inside Secure SafeXcel EIP-93 crypto engine support Christian Marangi
2024-12-09 23:27 ` Christian Marangi
2024-12-10 3:23 ` Herbert Xu
2024-12-10 11:55 ` Christian Marangi
2024-12-10 12:06 ` Herbert Xu
2024-12-10 12:16 ` Christian Marangi
2024-12-10 13:27 ` Herbert Xu
2024-12-10 20:51 ` Christian Marangi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6758a9e8.050a0220.b60b3.184c@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=atenart@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=justinstitt@google.com \
--cc=krzk+dt@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=upstream@airoha.com \
--cc=vschagen@icloud.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox