Re: [net-next PATCH v11 9/9] net: phy: Add Airoha AN8855 Internal Switch Gigabit PHY

Andrew Lunn
2024-12-10T01:36:45Z

> +config AIR_AN8855_PHY
> + tristate "Airoha AN8855 Internal Gigabit PHY"
> + help
> + Currently supports the internal Airoha AN8855 Switch PHY.
> +
> config AIR_EN8811H_PHY
> tristate "Airoha EN8811H 2.5 Gigabit PHY"
> help

Do you have any idea why the new one is AN, and previous one is EN? I
just like consistent naming, or an explanation why it is not
consistent.

> +#define AN8855_PHY_ID 0xc0ff0410
> +static struct phy_driver an8855_driver[] = {
> +{
> + PHY_ID_MATCH_EXACT(AN8855_PHY_ID),

Is there any documentation about the ID, and the lower nibble. Given
it is 0, i'm wondering if PHY_ID_MATCH_EXACT() is correct.

Andrew