From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1E5BC433E2 for ; Thu, 16 Jul 2020 18:24:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7C6E2074B for ; Thu, 16 Jul 2020 18:24:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="DSDVb32+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729364AbgGPSY5 (ORCPT ); Thu, 16 Jul 2020 14:24:57 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:58596 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726986AbgGPSY4 (ORCPT ); Thu, 16 Jul 2020 14:24:56 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1594923895; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=YDMbyhasawV6+ZRUOo3wA7/5QQM8cB+5MVZva9CP2rA=; b=DSDVb32++uJdOZeFi/k8xXFYW03IFDlgWfWr+/NfBm6nGBY+3xroT9L+gS8QZynmlA/3Mz36 w1g0gwY8Sk2BYi+uuA8JUaR1rhC4g+xk8UuBYj+DYQ4pOjLicX6vlyo0ick4HKSmGflDQC7o t5vYTXGF7cLLttIeTEbhhl5IYfM= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n12.prod.us-west-2.postgun.com with SMTP id 5f109b4e75eeb235f6c6ec98 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 16 Jul 2020 18:24:14 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 4FFCEC43395; Thu, 16 Jul 2020 18:24:14 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: rishabhb) by smtp.codeaurora.org (Postfix) with ESMTPSA id C89F4C433CB; Thu, 16 Jul 2020 18:24:13 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 16 Jul 2020 11:24:13 -0700 From: rishabhb@codeaurora.org To: Sibi Sankar Cc: Mathieu Poirier , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, tsoni@codeaurora.org, psodagud@codeaurora.org, sidgup@codeaurora.org, linux-kernel-owner@vger.kernel.org, linux-remoteproc-owner@vger.kernel.org Subject: Re: [PATCH v1 2/4] remoteproc: qcom_q6v5_mss: Replace mask based tracking with size In-Reply-To: References: <1594326716-15474-1-git-send-email-rishabhb@codeaurora.org> <1594326716-15474-3-git-send-email-rishabhb@codeaurora.org> <20200714171836.GA1407705@xps15> Message-ID: <6764de16a278f2663d1b88a40b7f662f@codeaurora.org> X-Sender: rishabhb@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-07-16 01:10, Sibi Sankar wrote: > On 2020-07-14 22:48, Mathieu Poirier wrote: >> On Thu, Jul 09, 2020 at 01:31:54PM -0700, Rishabh Bhatnagar wrote: >>> From: Sibi Sankar >>> >>> In order to land inline coredump support for mss, the dump_segment >>> function would need to support granularities less than the segment >>> size. This is achieved by replacing mask based tracking with size. >>> >>> Signed-off-by: Sibi Sankar >>> Signed-off-by: Rishabh Bhatnagar >>> --- >>> drivers/remoteproc/qcom_q6v5_mss.c | 15 +++++++-------- >>> 1 file changed, 7 insertions(+), 8 deletions(-) >>> >>> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c >>> b/drivers/remoteproc/qcom_q6v5_mss.c >>> index feb70283b..c6ce032 100644 >>> --- a/drivers/remoteproc/qcom_q6v5_mss.c >>> +++ b/drivers/remoteproc/qcom_q6v5_mss.c >>> @@ -181,8 +181,8 @@ struct q6v5 { >>> bool running; >>> >>> bool dump_mba_loaded; >>> - unsigned long dump_segment_mask; >>> - unsigned long dump_complete_mask; >>> + size_t current_dump_size; >>> + size_t total_dump_size; >>> >>> phys_addr_t mba_phys; >>> void *mba_region; >>> @@ -1203,7 +1203,6 @@ static void qcom_q6v5_dump_segment(struct rproc >>> *rproc, >>> { >>> int ret = 0; >>> struct q6v5 *qproc = rproc->priv; >>> - unsigned long mask = BIT((unsigned long)segment->priv); >>> int offset = segment->da - qproc->mpss_reloc; >>> void *ptr = NULL; >>> >>> @@ -1229,10 +1228,10 @@ static void qcom_q6v5_dump_segment(struct >>> rproc *rproc, >>> memset(dest, 0xff, segment->size); >>> } >>> >>> - qproc->dump_segment_mask |= mask; >>> + qproc->current_dump_size += segment->size; >>> >>> /* Reclaim mba after copying segments */ >>> - if (qproc->dump_segment_mask == qproc->dump_complete_mask) { >>> + if (qproc->current_dump_size == qproc->total_dump_size) { >>> if (qproc->dump_mba_loaded) { >>> /* Try to reset ownership back to Q6 */ >>> q6v5_xfer_mem_ownership(qproc, &qproc->mpss_perm, >>> @@ -1274,7 +1273,7 @@ static int q6v5_start(struct rproc *rproc) >>> "Failed to reclaim mba buffer system may become unstable\n"); >>> >>> /* Reset Dump Segment Mask */ >>> - qproc->dump_segment_mask = 0; >>> + qproc->current_dump_size = 0; >>> qproc->running = true; >>> >>> return 0; >>> @@ -1323,7 +1322,7 @@ static int >>> qcom_q6v5_register_dump_segments(struct rproc *rproc, >>> >>> ehdr = (struct elf32_hdr *)fw->data; >>> phdrs = (struct elf32_phdr *)(ehdr + 1); >>> - qproc->dump_complete_mask = 0; >>> + qproc->total_dump_size = 0; >>> >>> for (i = 0; i < ehdr->e_phnum; i++) { >>> phdr = &phdrs[i]; >>> @@ -1338,7 +1337,7 @@ static int >>> qcom_q6v5_register_dump_segments(struct rproc *rproc, >>> if (ret) >>> break; >> >> There is also no longer a need to carry the 'i' in: >> >> ret = rproc_coredump_add_custom_segment(rproc, >> phdr->p_paddr, >> phdr->p_memsz, >> >> qcom_q6v5_dump_segment, >> (void *)i); > > I assume Rishabh will re-spin the > series today and this will be taken > care as well. > Hi Sibi, I'll respin and add the fixes. Thanks >>> >>> - qproc->dump_complete_mask |= BIT(i); >>> + qproc->total_dump_size += phdr->p_memsz; >>> } >>> >>> release_firmware(fw); >>> -- >>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora >>> Forum, >>> a Linux Foundation Collaborative Project >>>