From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4632DC77B73 for ; Mon, 22 May 2023 15:23:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233981AbjEVPXD (ORCPT ); Mon, 22 May 2023 11:23:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234499AbjEVPW4 (ORCPT ); Mon, 22 May 2023 11:22:56 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEF151A7 for ; Mon, 22 May 2023 08:22:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684768968; x=1716304968; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=B+VCFjsrJW/lh7B61VjWVRHmyHm6MpEB6o9V7PhypQQ=; b=jjEyX5oWuigriSSKx+p09Jlnm3ncVZb1U6SYicRkY1SW3zRSAQ+a7o+N iUgGg7GuOrzNyEqXZyvBLT9X/9qTRojlm9VxwG5UZefbYQGnFdj1fG28K bvhH2+9t+8ILXXqYmEnSM39dhY5yq5dMh1vqHMBLUyNyaslsnEM+ZAN8A jWGKGSA+lBDc8+8nAf4TIdQ2jCqr+ummft7l2ReeEWU/7Gd2yszmBSfgC B1Rk8aOBdqStLNSD9HpZhvsIVJDUv65my+JzXXojAWncwd29GtaE3pP6Q wz/OhKHnxol+WXs4YLyvqesIhHb+dWZsDlIvQu8V6uuz+EGYlGftGjoDU Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="381182210" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="381182210" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2023 08:22:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="703554971" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="703554971" Received: from djiang5-mobl3.amr.corp.intel.com (HELO [10.213.173.219]) ([10.213.173.219]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2023 08:22:45 -0700 Message-ID: <67717c6d-de28-795a-74f8-e1fed71e627a@intel.com> Date: Mon, 22 May 2023 08:22:44 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.10.0 Subject: Re: [PATCH 3/3] libnvdimm: mark 'security_show' static again Content-Language: en-US To: Arnd Bergmann , Dan Williams , Vishal Verma , Ira Weiny , Jonathan Cameron Cc: Arnd Bergmann , Greg Kroah-Hartman , Hans de Goede , nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org References: <20230516201415.556858-1-arnd@kernel.org> <20230516201415.556858-3-arnd@kernel.org> From: Dave Jiang In-Reply-To: <20230516201415.556858-3-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/16/23 1:14 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > The security_show() function was made global and __weak at some > point to allow overriding it. The override was removed later, but > it remains global, which causes a warning about the missing > declaration: > > drivers/nvdimm/dimm_devs.c:352:9: error: no previous prototype for 'security_show' > > This is also not an appropriate name for a global symbol in the > kernel, so just make it static again. > > Fixes: 15a8348707ff ("libnvdimm: Introduce CONFIG_NVDIMM_SECURITY_TEST flag") > Signed-off-by: Arnd Bergmann Reviewed-by: Dave Jiang > --- > drivers/nvdimm/dimm_devs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c > index 957f7c3d17ba..10c3cb6a574a 100644 > --- a/drivers/nvdimm/dimm_devs.c > +++ b/drivers/nvdimm/dimm_devs.c > @@ -349,7 +349,7 @@ static ssize_t available_slots_show(struct device *dev, > } > static DEVICE_ATTR_RO(available_slots); > > -ssize_t security_show(struct device *dev, > +static ssize_t security_show(struct device *dev, > struct device_attribute *attr, char *buf) > { > struct nvdimm *nvdimm = to_nvdimm(dev);