From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Akshu Agrawal <akshu.agrawal@amd.com>
Cc: rrangel@chromium.org, Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Wolfram Sang <wsa@the-dreams.de>,
Neil Armstrong <narmstrong@baylibre.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
"open list:I2C SUBSYSTEM HOST DRIVERS"
<linux-i2c@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: i2c-cros-ec-tunnel: Fix slave device enumeration
Date: Tue, 26 Nov 2019 11:23:53 +0100 [thread overview]
Message-ID: <6772efe4-3de1-efbd-15ca-268209c46b47@collabora.com> (raw)
In-Reply-To: <20191121090620.75569-1-akshu.agrawal@amd.com>
Hi,
On 21/11/19 10:06, Akshu Agrawal wrote:
> During adding of the adapter the slave device registration
> use to fail as the acpi companion field was not populated.
>
> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com>
Looks good to me.
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> drivers/i2c/busses/i2c-cros-ec-tunnel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> index c551aa96a2e3..aca8070393bd 100644
> --- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> +++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> @@ -273,6 +273,7 @@ static int ec_i2c_probe(struct platform_device *pdev)
> bus->adap.dev.parent = &pdev->dev;
> bus->adap.dev.of_node = np;
> bus->adap.retries = I2C_MAX_RETRIES;
> + ACPI_COMPANION_SET(&bus->adap.dev, ACPI_COMPANION(&pdev->dev));
>
> err = i2c_add_adapter(&bus->adap);
> if (err)
>
next prev parent reply other threads:[~2019-11-26 10:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 9:06 [PATCH] i2c: i2c-cros-ec-tunnel: Fix slave device enumeration Akshu Agrawal
2019-11-25 15:32 ` Enric Balletbo i Serra
2019-11-25 18:08 ` Raul Rangel
2019-11-25 18:09 ` Raul Rangel
2019-11-26 10:23 ` Enric Balletbo i Serra [this message]
2020-01-31 7:45 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6772efe4-3de1-efbd-15ca-268209c46b47@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=akshu.agrawal@amd.com \
--cc=bleung@chromium.org \
--cc=cw00.choi@samsung.com \
--cc=groeck@chromium.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=rrangel@chromium.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox