Re: [PATCH v2 04/18] clocksource: Add ARM System timer driver

Maxime Coquelin
2015-03-04T12:08:12Z

2015-03-03 20:43 GMT+01:00 Paul Bolle <pebolle@tiscali.nl>:
> Maxime Coquelin schreef op ma 02-03-2015 om 17:53 [+0100]:
>> Do you agree if I define it like this:
>>
>> config ARMV7M_SYSTICK
>> bool "Clocksource driver for ARMv7-M System timer"
>> depends on OF && (CPU_V7M || COMPILE_TEST)
>> select CLKSRC_OF
>> select CLKSRC_MMIO
>> help
>> This options enables clocksource support for the ARMv7-M system
>> timer unit.
>
> I don't really have strong feelings on whatever way you choose to fix
> the, well, minor problem I pointed out.
>
> Having said that, if a Kconfig entry without a prompt (and therefor,
> without help) actually does what you want it to do, why bother adding a
> prompt and a one line help text?

This is because I added also support for COMPILE_TEST coverage as per
Uwe advice,
and thought it was necessary to have an entry for this.
Maybe I'm just wrong?

Thanks,
Maxime

>
>
> Paul Bolle
>