Re: [PATCH v2 04/18] clocksource: Add ARM System timer driver

Uwe Kleine-König
2015-03-09T22:18:55Z

Hello,

On Mon, Mar 09, 2015 at 10:12:32PM +0100, Paul Bolle wrote:
> On Wed, 2015-03-04 at 13:08 +0100, Maxime Coquelin wrote:
> > This is because I added also support for COMPILE_TEST coverage as per
> > Uwe advice,
> > and thought it was necessary to have an entry for this.
> > Maybe I'm just wrong?
>
> I missed that you added COMPILE_TEST.
>
> A quick scan of your idea doesn't show any obvious issues. (Note that I
> don't really know how people actually use COMPILE_TEST. I guess things
> like "make allyesconfig" are involved.)
Maybe this can clearify the purpose of COMPILE_TEST:

diff --git a/init/Kconfig b/init/Kconfig
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -67,6 +67,26 @@ config COMPILE_TEST
here. If you are a user/distributor, say N here to exclude useless
drivers to be distributed.

+ # If you are a driver author consider to adjust your driver's
+ # dependencies to make it buildable with minimal preconditions if
+ # COMPILE_TEST is enabled. This helps contributers and maintainers
+ # that might not have the necessary toolchain or kernel config handy and
+ # also increases compile test coverage. It's your advantage if others can
+ # build your driver more easily! So for a device that is only found on the
+ # foo cpu use:
+ #
+ # depends on CPU_FOO || COMPILE_TEST
+ #
+ # . You might have to use
+ #
+ # depends on CPU_FOO || (COMPILE_TEST && COOKIE)
+ #
+ # or
+ #
+ # depends on COOKIE && (CPU_FOO || COMPILE_TEST)
+ #
+ # if your driver uses features that are only available if COOKIE is on.
+
config LOCALVERSION
string "Local version - append to kernel release"
help

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |