From: Wei Xu <xuwei5@hisilicon.com>
To: "Rob Herring (Arm)" <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<xuwei5@hisilicon.com>
Subject: Re: [PATCH] arm64: dts: hisilicon: Remove unused and undocumented "enable-dma" property
Date: Thu, 2 Jan 2025 19:26:37 +0800 [thread overview]
Message-ID: <677677ED.7060902@hisilicon.com> (raw)
In-Reply-To: <20241115193454.3619297-1-robh@kernel.org>
Hi Rob,
On 2024/11/16 3:34, Rob Herring (Arm) wrote:
> Remove "enable-dma" property which is both unused in the kernel and
> undocumented. Most likely they are leftovers from downstream.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index a589954c29e2..12f621cedf89 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -728,7 +728,6 @@ spi0: spi@f7106000 {
> reg = <0x0 0xf7106000 0x0 0x1000>;
> interrupts = <0 50 4>;
> bus-id = <0>;
> - enable-dma = <0>;
> clocks = <&sys_ctrl HI6220_SPI_CLK>, <&sys_ctrl HI6220_SPI_CLK>;
> clock-names = "sspclk", "apb_pclk";
> pinctrl-names = "default";
>
Thanks!
Since the "enable-dma" and "bus-id" both are not used by the pl022 driver,
when applying this patch, I have removed the "bus-id" and changed the
commit message as well.
The detail is as following:
https://github.com/hisilicon/linux-hisi/commit/4a45f8c502a8b8a836c3c932a18d538856097ac7
Best Regards,
Wei
prev parent reply other threads:[~2025-01-02 11:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 19:34 [PATCH] arm64: dts: hisilicon: Remove unused and undocumented "enable-dma" property Rob Herring (Arm)
2025-01-02 11:26 ` Wei Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=677677ED.7060902@hisilicon.com \
--to=xuwei5@hisilicon.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox