From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1271E1D89FE for ; Mon, 6 Jan 2025 10:29:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.69 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736159392; cv=none; b=HveKIkOtPdbaRpXB8Mn3elRPRdzZ/yDuOdWJdVTOyF7bYESC90KdS5dYi0WjT/AUaxuDTTQ7dNhLWXb0m1yIiJqfwRcpDJFj6QcbvLkM1qdc6wsQXD0DEWVea0sw6jjmlFLK+wcQ+NJNJg2/ddDxgVn+aXX4AHybZrTTdWP1o78= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736159392; c=relaxed/simple; bh=vtuRP4/uMotyahZEv+uba92cJbtKme57kGsrh4OcQW4=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=k+NShuV0eMIdFfQg8Ph49pjTLNJda4EH1zorz+IeGjAd0dy2WbxJe2DUuqLRFXqU67vpPJu0dTYXE8nS1qsr3yh+qvw0gYe2U1jVGFy8h92ZwgxEwkvhhwBBQUAFYT5pJ1ysgn9x9RSwKDobHU9gqjWWiWTkIevsqbTkmVyxlq0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.166.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-io1-f69.google.com with SMTP id ca18e2360f4ac-844d54c3e62so2313210139f.2 for ; Mon, 06 Jan 2025 02:29:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736159390; x=1736764190; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bLrrB6rypw9eR3q1b+fe0N7TodJ4gT/GzUZU3Ez2MnE=; b=t4THDlR4hIDzOV54rneG3p8NsdiOfCcZqz2nfzL09KKqYdCGwo9INj11cjjR6PbdQ6 U7y+rGoTl6qL2BEicZv2esJMZQgS811FYYq6cQ0tZXmKWIcsU0HOpZKnOtg/vjmwlSmg E+MQu+Y2MgDMd9Zz6lfz32u6/HTSh+ShCUvTKuyfVemoXMuePhlc9heHuODyxDKptYRg ZDmi61/9ZRFdbeRoq5hKKWzRm2FgROWHrdlPVw5t34+TNLiF4ttuYEjsx6VLMMvYLjet NdfD6ZH5q9aKzxHK/KZxNFWSVNzX7cvMA6BQeskppsqQgyiLeY3KrKIGqFCtSZbLRgcv uOBA== X-Gm-Message-State: AOJu0Yz3XRBvN7p4jrDvsZT/OGNfD9gAab41UmB1GvrTnTU7mafmRQLs wFEcAM9k6a+5E5H9eX93O9ANS3wJlSIuumWQ7YLu9H/b6G4cXg5rbZTdAgOlK30aswx/4N+a57j YVzWTMPQXqbUVSLOMzx1QyAG0FOQOab9zOo6BviUNVEYeGLpomCBe+EE= X-Google-Smtp-Source: AGHT+IGfjS8NdR9L5py8bTVJfrktwfhsx+fkOQT9Z2QEdP+YrISeNVPMuzN+VBrY1jXJ9hnu4hlliNFTn3G+WGTPOUL9eHLz3/om Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6e02:1a0b:b0:3a7:e0c0:5f27 with SMTP id e9e14a558f8ab-3c2d1c915a9mr438460065ab.2.1736159390276; Mon, 06 Jan 2025 02:29:50 -0800 (PST) Date: Mon, 06 Jan 2025 02:29:50 -0800 In-Reply-To: <677a7db3.050a0220.380ff0.0012.GAE@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <677bb09e.050a0220.a40f5.000a.GAE@google.com> Subject: Re: [syzbot] Re: [syzbot] [input?] possible deadlock in input_ff_flush From: syzbot To: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org. *** Subject: Re: [syzbot] [input?] possible deadlock in input_ff_flush Author: hdanton@sina.com On Sun, 05 Jan 2025 04:40:19 -0800 > syzbot found the following issue on: > > HEAD commit: ccb98ccef0e5 Merge tag 'platform-drivers-x86-v6.13-4' of g.. > git tree: upstream > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17bd56df980000 #syz test --- x/drivers/input/input.c +++ y/drivers/input/input.c @@ -642,17 +642,11 @@ EXPORT_SYMBOL(input_open_device); int input_flush_device(struct input_handle *handle, struct file *file) { struct input_dev *dev = handle->dev; - int retval; - - retval = mutex_lock_interruptible(&dev->mutex); - if (retval) - return retval; if (dev->flush) - retval = dev->flush(dev, file); + return dev->flush(dev, file); - mutex_unlock(&dev->mutex); - return retval; + return 0; } EXPORT_SYMBOL(input_flush_device); --