[syzbot] [input?] KASAN: null-ptr-deref Read in input_event

[syzbot] [input?] KASAN: null-ptr-deref Read in input_event

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit:    f097a36ef88d dt-bindings: usb: qcom,dwc3: Add QCS615 to US..
git tree:       https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
console output: https://syzkaller.appspot.com/x/log.txt?x=15d42d0f980000
kernel config:  https://syzkaller.appspot.com/x/.config?x=c7df994a0b7c30a9
dashboard link: https://syzkaller.appspot.com/bug?extid=fddd3aa6dfcfe50c760d
compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=151d56df980000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=17e2a8b0580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/bede28be1169/disk-f097a36e.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/6c75ceb4a6ea/vmlinux-f097a36e.xz
kernel image: https://storage.googleapis.com/syzbot-assets/3fdd4b8ab4d3/bzImage-f097a36e.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+fddd3aa6dfcfe50c760d@syzkaller.appspotmail.com

==================================================================
BUG: KASAN: null-ptr-deref in instrument_atomic_read include/linux/instrumented.h:68 [inline]
BUG: KASAN: null-ptr-deref in _test_bit include/asm-generic/bitops/instrumented-non-atomic.h:141 [inline]
BUG: KASAN: null-ptr-deref in is_event_supported drivers/input/input.c:67 [inline]
BUG: KASAN: null-ptr-deref in input_event+0x42/0xa0 drivers/input/input.c:395
Read of size 8 at addr 0000000000000028 by task syz-executor199/2949

CPU: 0 UID: 0 PID: 2949 Comm: syz-executor199 Not tainted 6.13.0-rc4-syzkaller-00076-gf097a36ef88d #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
 <IRQ>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 kasan_report+0xd9/0x110 mm/kasan/report.c:602
 check_region_inline mm/kasan/generic.c:183 [inline]
 kasan_check_range+0xef/0x1a0 mm/kasan/generic.c:189
 instrument_atomic_read include/linux/instrumented.h:68 [inline]
 _test_bit include/asm-generic/bitops/instrumented-non-atomic.h:141 [inline]
 is_event_supported drivers/input/input.c:67 [inline]
 input_event+0x42/0xa0 drivers/input/input.c:395
 input_report_key include/linux/input.h:439 [inline]
 key_down drivers/hid/hid-appleir.c:159 [inline]
 appleir_raw_event+0x3e5/0x5e0 drivers/hid/hid-appleir.c:232
 __hid_input_report.constprop.0+0x312/0x440 drivers/hid/hid-core.c:2111
 hid_ctrl+0x49f/0x550 drivers/hid/usbhid/hid-core.c:484
 __usb_hcd_giveback_urb+0x389/0x6e0 drivers/usb/core/hcd.c:1650
 usb_hcd_giveback_urb+0x396/0x450 drivers/usb/core/hcd.c:1734
 dummy_timer+0x17f7/0x3960 drivers/usb/gadget/udc/dummy_hcd.c:1993
 __run_hrtimer kernel/time/hrtimer.c:1739 [inline]
 __hrtimer_run_queues+0x20a/0xae0 kernel/time/hrtimer.c:1803
 hrtimer_run_softirq+0x17d/0x350 kernel/time/hrtimer.c:1820
 handle_softirqs+0x206/0x8d0 kernel/softirq.c:561
 __do_softirq kernel/softirq.c:595 [inline]
 invoke_softirq kernel/softirq.c:435 [inline]
 __irq_exit_rcu+0xfa/0x160 kernel/softirq.c:662
 irq_exit_rcu+0x9/0x30 kernel/softirq.c:678
 instr_sysvec_apic_timer_interrupt arch/x86/kernel/apic/apic.c:1049 [inline]
 sysvec_apic_timer_interrupt+0x90/0xb0 arch/x86/kernel/apic/apic.c:1049
 </IRQ>
 <TASK>
 asm_sysvec_apic_timer_interrupt+0x1a/0x20 arch/x86/include/asm/idtentry.h:702
RIP: 0010:__raw_spin_unlock_irqrestore include/linux/spinlock_api_smp.h:152 [inline]
RIP: 0010:_raw_spin_unlock_irqrestore+0x31/0x80 kernel/locking/spinlock.c:194
Code: f5 53 48 8b 74 24 10 48 89 fb 48 83 c7 18 e8 e6 04 45 fa 48 89 df e8 2e 84 45 fa f7 c5 00 02 00 00 75 23 9c 58 f6 c4 02 75 37 <bf> 01 00 00 00 e8 85 9d 39 fa 65 8b 05 86 86 10 79 85 c0 74 16 5b
RSP: 0018:ffffc90000537a00 EFLAGS: 00000246
RAX: 0000000000000002 RBX: ffff8881f582a680 RCX: 1ffffffff1f5f36c
RDX: 0000000000000000 RSI: ffffffff8727fee0 RDI: ffffffff874735a0
RBP: 0000000000000293 R08: 0000000000000001 R09: fffffbfff1f579d7
R10: ffffffff8fabcebf R11: 0000000000000001 R12: 00000000ffff99eb
R13: 0000000000000000 R14: ffff8881f582a680 R15: 00000000ffffffff
 __mod_timer+0x8f6/0xdc0 kernel/time/timer.c:1185
 add_timer+0x62/0x90 kernel/time/timer.c:1295
 schedule_timeout+0x11f/0x280 kernel/time/sleep_timeout.c:98
 usbhid_wait_io+0x1c7/0x380 drivers/hid/usbhid/hid-core.c:645
 usbhid_init_reports+0x19f/0x390 drivers/hid/usbhid/hid-core.c:784
 hiddev_ioctl+0x1133/0x15b0 drivers/hid/usbhid/hiddev.c:794
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:906 [inline]
 __se_sys_ioctl fs/ioctl.c:892 [inline]
 __x64_sys_ioctl+0x190/0x200 fs/ioctl.c:892
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f05d1cf05a9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f05d1c86228 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f05d1d773f8 RCX: 00007f05d1cf05a9
RDX: 0000000000000000 RSI: 00000000d01c4813 RDI: 0000000000000004
RBP: 00007f05d1d773f0 R08: 00007f05d1c866c0 R09: 00007f05d1c866c0
R10: 00007f05d1c866c0 R11: 0000000000000246 R12: 00007f05d1d773fc
R13: 00007f05d1d440d8 R14: 04ed000000080000 R15: 00007ffe6e0843e8
 </TASK>
==================================================================
----------------
Code disassembly (best guess):
   0:	f5                   	cmc
   1:	53                   	push   %rbx
   2:	48 8b 74 24 10       	mov    0x10(%rsp),%rsi
   7:	48 89 fb             	mov    %rdi,%rbx
   a:	48 83 c7 18          	add    $0x18,%rdi
   e:	e8 e6 04 45 fa       	call   0xfa4504f9
  13:	48 89 df             	mov    %rbx,%rdi
  16:	e8 2e 84 45 fa       	call   0xfa458449
  1b:	f7 c5 00 02 00 00    	test   $0x200,%ebp
  21:	75 23                	jne    0x46
  23:	9c                   	pushf
  24:	58                   	pop    %rax
  25:	f6 c4 02             	test   $0x2,%ah
  28:	75 37                	jne    0x61
* 2a:	bf 01 00 00 00       	mov    $0x1,%edi <-- trapping instruction
  2f:	e8 85 9d 39 fa       	call   0xfa399db9
  34:	65 8b 05 86 86 10 79 	mov    %gs:0x79108686(%rip),%eax        # 0x791086c1
  3b:	85 c0                	test   %eax,%eax
  3d:	74 16                	je     0x55
  3f:	5b                   	pop    %rbx


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

Re: [syzbot] [input?] KASAN: null-ptr-deref Read in input_event

[Hillf Danton]

On Sun, 05 Jan 2025 00:31:21 -0800
> syzbot found the following issue on:
> 
> HEAD commit:    f097a36ef88d dt-bindings: usb: qcom,dwc3: Add QCS615 to US..
> git tree:       https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=17e2a8b0580000

#syz test

--- x/include/linux/input.h
+++ y/include/linux/input.h
@@ -140,17 +140,17 @@ struct input_dev {
 	const char *uniq;
 	struct input_id id;
 
-	unsigned long propbit[BITS_TO_LONGS(INPUT_PROP_CNT)];
+	unsigned long propbit[1+ BITS_TO_LONGS(INPUT_PROP_CNT)];
 
-	unsigned long evbit[BITS_TO_LONGS(EV_CNT)];
-	unsigned long keybit[BITS_TO_LONGS(KEY_CNT)];
-	unsigned long relbit[BITS_TO_LONGS(REL_CNT)];
-	unsigned long absbit[BITS_TO_LONGS(ABS_CNT)];
-	unsigned long mscbit[BITS_TO_LONGS(MSC_CNT)];
-	unsigned long ledbit[BITS_TO_LONGS(LED_CNT)];
-	unsigned long sndbit[BITS_TO_LONGS(SND_CNT)];
-	unsigned long ffbit[BITS_TO_LONGS(FF_CNT)];
-	unsigned long swbit[BITS_TO_LONGS(SW_CNT)];
+	unsigned long evbit[1+ BITS_TO_LONGS(EV_CNT)];
+	unsigned long keybit[1+ BITS_TO_LONGS(KEY_CNT)];
+	unsigned long relbit[1+ BITS_TO_LONGS(REL_CNT)];
+	unsigned long absbit[1+ BITS_TO_LONGS(ABS_CNT)];
+	unsigned long mscbit[1+ BITS_TO_LONGS(MSC_CNT)];
+	unsigned long ledbit[1+ BITS_TO_LONGS(LED_CNT)];
+	unsigned long sndbit[1+ BITS_TO_LONGS(SND_CNT)];
+	unsigned long ffbit[1+ BITS_TO_LONGS(FF_CNT)];
+	unsigned long swbit[1+ BITS_TO_LONGS(SW_CNT)];
 
 	unsigned int hint_events_per_packet;
 
@@ -177,10 +177,10 @@ struct input_dev {
 
 	struct input_absinfo *absinfo;
 
-	unsigned long key[BITS_TO_LONGS(KEY_CNT)];
-	unsigned long led[BITS_TO_LONGS(LED_CNT)];
-	unsigned long snd[BITS_TO_LONGS(SND_CNT)];
-	unsigned long sw[BITS_TO_LONGS(SW_CNT)];
+	unsigned long key[1+ BITS_TO_LONGS(KEY_CNT)];
+	unsigned long led[1+ BITS_TO_LONGS(LED_CNT)];
+	unsigned long snd[1+ BITS_TO_LONGS(SND_CNT)];
+	unsigned long sw[1+ BITS_TO_LONGS(SW_CNT)];
 
 	int (*open)(struct input_dev *dev);
 	void (*close)(struct input_dev *dev);
--

Re: [syzbot] [input?] KASAN: null-ptr-deref Read in input_event

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
KASAN: null-ptr-deref Read in input_event

==================================================================
BUG: KASAN: null-ptr-deref in instrument_atomic_read include/linux/instrumented.h:68 [inline]
BUG: KASAN: null-ptr-deref in _test_bit include/asm-generic/bitops/instrumented-non-atomic.h:141 [inline]
BUG: KASAN: null-ptr-deref in is_event_supported drivers/input/input.c:67 [inline]
BUG: KASAN: null-ptr-deref in input_event+0x42/0xa0 drivers/input/input.c:395
Read of size 8 at addr 0000000000000030 by task swapper/0/0

CPU: 0 UID: 0 PID: 0 Comm: swapper/0 Not tainted 6.13.0-rc4-syzkaller-00080-gf1a2241778d9-dirty #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
 <IRQ>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 kasan_report+0xd9/0x110 mm/kasan/report.c:602
 check_region_inline mm/kasan/generic.c:183 [inline]
 kasan_check_range+0xef/0x1a0 mm/kasan/generic.c:189
 instrument_atomic_read include/linux/instrumented.h:68 [inline]
 _test_bit include/asm-generic/bitops/instrumented-non-atomic.h:141 [inline]
 is_event_supported drivers/input/input.c:67 [inline]
 input_event+0x42/0xa0 drivers/input/input.c:395
 input_report_key include/linux/input.h:439 [inline]
 key_down drivers/hid/hid-appleir.c:159 [inline]
 appleir_raw_event+0x3e5/0x5e0 drivers/hid/hid-appleir.c:232
 __hid_input_report.constprop.0+0x312/0x440 drivers/hid/hid-core.c:2111
 hid_ctrl+0x49f/0x550 drivers/hid/usbhid/hid-core.c:484
 __usb_hcd_giveback_urb+0x389/0x6e0 drivers/usb/core/hcd.c:1650
 usb_hcd_giveback_urb+0x396/0x450 drivers/usb/core/hcd.c:1734
 dummy_timer+0x17f7/0x3960 drivers/usb/gadget/udc/dummy_hcd.c:1993
 __run_hrtimer kernel/time/hrtimer.c:1739 [inline]
 __hrtimer_run_queues+0x20a/0xae0 kernel/time/hrtimer.c:1803
 hrtimer_run_softirq+0x17d/0x350 kernel/time/hrtimer.c:1820
 handle_softirqs+0x206/0x8d0 kernel/softirq.c:561
 __do_softirq kernel/softirq.c:595 [inline]
 invoke_softirq kernel/softirq.c:435 [inline]
 __irq_exit_rcu+0xfa/0x160 kernel/softirq.c:662
 irq_exit_rcu+0x9/0x30 kernel/softirq.c:678
 instr_sysvec_apic_timer_interrupt arch/x86/kernel/apic/apic.c:1049 [inline]
 sysvec_apic_timer_interrupt+0x90/0xb0 arch/x86/kernel/apic/apic.c:1049
 </IRQ>
 <TASK>
 asm_sysvec_apic_timer_interrupt+0x1a/0x20 arch/x86/include/asm/idtentry.h:702
RIP: 0010:finish_task_switch.isra.0+0x1e5/0xa40 kernel/sched/core.c:5243
Code: 0f 85 ad 07 00 00 8b 0d 9d ce 28 09 85 c9 0f 85 cb 02 00 00 48 89 df e8 f9 f1 c5 05 e8 44 ae 35 00 fb 65 48 8b 1d ab 69 d6 7e <48> 8d bb 30 15 00 00 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1
RSP: 0018:ffffffff88c07c80 EFLAGS: 00000206
RAX: 00000000000d375f RBX: ffffffff88c2c780 RCX: 1ffffffff14abb89
RDX: 0000000000000000 RSI: ffffffff8727fee0 RDI: ffffffff874735a0
RBP: ffffffff88c07cc8 R08: 0000000000000001 R09: 0000000000000001
R10: ffffffff8a561557 R11: 0000000000000000 R12: ffff8881f583d318
R13: ffff888101f357c0 R14: 0000000000000000 R15: ffff8881f583d318
 context_switch kernel/sched/core.c:5372 [inline]
 __schedule+0x1034/0x34b0 kernel/sched/core.c:6756
 schedule_idle+0x5c/0x90 kernel/sched/core.c:6874
 do_idle+0x284/0x3f0 kernel/sched/idle.c:353
 cpu_startup_entry+0x4f/0x60 kernel/sched/idle.c:423
 rest_init+0x16b/0x2b0 init/main.c:747
 start_kernel+0x3df/0x4c0 init/main.c:1102
 x86_64_start_reservations+0x18/0x30 arch/x86/kernel/head64.c:507
 x86_64_start_kernel+0xb2/0xc0 arch/x86/kernel/head64.c:488
 common_startup_64+0x12c/0x138
 </TASK>
==================================================================
----------------
Code disassembly (best guess):
   0:	0f 85 ad 07 00 00    	jne    0x7b3
   6:	8b 0d 9d ce 28 09    	mov    0x928ce9d(%rip),%ecx        # 0x928cea9
   c:	85 c9                	test   %ecx,%ecx
   e:	0f 85 cb 02 00 00    	jne    0x2df
  14:	48 89 df             	mov    %rbx,%rdi
  17:	e8 f9 f1 c5 05       	call   0x5c5f215
  1c:	e8 44 ae 35 00       	call   0x35ae65
  21:	fb                   	sti
  22:	65 48 8b 1d ab 69 d6 	mov    %gs:0x7ed669ab(%rip),%rbx        # 0x7ed669d5
  29:	7e
* 2a:	48 8d bb 30 15 00 00 	lea    0x1530(%rbx),%rdi <-- trapping instruction
  31:	48 b8 00 00 00 00 00 	movabs $0xdffffc0000000000,%rax
  38:	fc ff df
  3b:	48 89 fa             	mov    %rdi,%rdx
  3e:	48                   	rex.W
  3f:	c1                   	.byte 0xc1


Tested on:

commit:         f1a22417 usb: typec: ucsi: Implement ChromeOS UCSI dri..
git tree:       https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
console output: https://syzkaller.appspot.com/x/log.txt?x=12ab3418580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=e27867f71e8bc406
dashboard link: https://syzkaller.appspot.com/bug?extid=fddd3aa6dfcfe50c760d
compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
patch:          https://syzkaller.appspot.com/x/patch.diff?x=11b33418580000

Re: [syzbot] [input?] KASAN: null-ptr-deref Read in input_event

[Hillf Danton]

On Sun, 05 Jan 2025 00:31:21 -0800
> syzbot found the following issue on:
> 
> HEAD commit:    f097a36ef88d dt-bindings: usb: qcom,dwc3: Add QCS615 to US..
> git tree:       https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=17e2a8b0580000

#syz test

--- l/drivers/hid/hid-appleir.c
+++ y/drivers/hid/hid-appleir.c
@@ -150,12 +150,16 @@ static int get_key(int data)
 
 static void key_up(struct hid_device *hid, struct appleir *appleir, int key)
 {
+	if (!appleir->input_dev)
+		return;
 	input_report_key(appleir->input_dev, key, 0);
 	input_sync(appleir->input_dev);
 }
 
 static void key_down(struct hid_device *hid, struct appleir *appleir, int key)
 {
+	if (!appleir->input_dev)
+		return;
 	input_report_key(appleir->input_dev, key, 1);
 	input_sync(appleir->input_dev);
 }
--

Re: [syzbot] [input?] KASAN: null-ptr-deref Read in input_event

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-by: syzbot+fddd3aa6dfcfe50c760d@syzkaller.appspotmail.com
Tested-by: syzbot+fddd3aa6dfcfe50c760d@syzkaller.appspotmail.com

Tested on:

commit:         f1a22417 usb: typec: ucsi: Implement ChromeOS UCSI dri..
git tree:       https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
console output: https://syzkaller.appspot.com/x/log.txt?x=1512c4b0580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=e27867f71e8bc406
dashboard link: https://syzkaller.appspot.com/bug?extid=fddd3aa6dfcfe50c760d
compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
patch:          https://syzkaller.appspot.com/x/patch.diff?x=11b1330f980000

Note: testing is done by a robot and is best-effort only.