From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751019AbdCNND7 (ORCPT ); Tue, 14 Mar 2017 09:03:59 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:33522 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbdCNND4 (ORCPT ); Tue, 14 Mar 2017 09:03:56 -0400 X-AuditID: b6c32a2c-f79b56d0000012f0-9a-58c7ea388766 From: Bartlomiej Zolnierkiewicz To: Krzysztof Kozlowski Cc: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Kukjin Kim , Javier Martinez Canillas , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 Date: Tue, 14 Mar 2017 14:03:49 +0100 Message-id: <6788694.7QfyuOlrPv@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170311172527.16368-4-krzk@kernel.org> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNKsWRmVeSWpSXmKPExsWy7bCmpq7Fq+MRBj83KlrMP3KO1eLN2zVM Fv2PXzNbnD+/gd1i0+NrrBaXd81hs5hxfh+TxY11+9gtniw8w2TRuvcIu8WtGS9YHbg9rm0W 89i0qpPNY/OSeo8t/XfZPXZ+b2D3+LxJLoAtissmJTUnsyy1SN8ugStj3r42loI/7BVdXatY GhgPsXUxcnBICJhItE8I7WLkBDLFJC7cWw8U5uIQEljKKHFw5VcWCKedSeLR0WesEFUmEusX 3GGGSCxnlHg1dws7hPOVUaKhYQ9YFZuAlcTE9lWMILaIgKbE9b/fWUGKmAWeM0lsPfOSDSQh LBAgsaHvMDOIzSKgKrFt9XF2EJsXqKH3zi8mEFtUwEtiy752MJtTwFRi/5mbLBA1ghI/Jt8D s5kF5CX27Z/KCmHrSJw9to4RZJmEwDF2iWkn3jJCPCorsekAM8QLLhKrN19mhLCFJV4d38IO YUtL/F16Cyo+nVFi+28JiDmbGSVW7Z4AVWQtcfj4RahlfBK9v58wQcznlehoE4Io8ZC4Mv8F NLgcJX4fvQINLqA5ezesYZnAKD8LyQ+zkPwwC8kPCxiZVzGKpRYU56anFpsWGOoVJ+YWl+al 6yXn525iBCchLZ0djPcWeB9iFOBgVOLhZTh0LEKINbGsuDL3EKMEB7OSCO/jF8cjhHhTEiur Uovy44tKc1KLDzFKc7AoifNGGUyMEBJITyxJzU5NLUgtgskycXBKNTCW/S0LKK1V1VK8GhY8 aeF3yX13mS5VfOFJWuBr/XhaWujdsIxn01bM4VBjZZLdc0qlI/fMen2bRWprvZfJ9HXe638+ 5bmo2nIJllA1xz22+jPXGK9QF3b54+BbI9DmJyZ5bHHAjulGUlsudt6+fOlX+K6mjN2b54pe lvgr6jexKvF8Ueunf0lKLMUZiYZazEXFiQBPFtSTPgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDIsWRmVeSWpSXmKPExsVy+t9jAV2LV8cjDBpnslnMP3KO1eLN2zVM Fv2PXzNbnD+/gd1i0+NrrBaXd81hs5hxfh+TxY11+9gtniw8w2TRuvcIu8WtGS9YHbg9rm0W 89i0qpPNY/OSeo8t/XfZPXZ+b2D3+LxJLoAtys0mIzUxJbVIITUvOT8lMy/dVik0xE3XQkkh LzE31VYpQtc3JEhJoSwxpxTIMzJAAw7OAe7BSvp2CW4Z8/a1sRT8Ya/o6lrF0sB4iK2LkZND QsBEYv2CO8wQtpjEhXvrweJCAksZJc6sLOli5AKyvzJKnPu1mAkkwSZgJTGxfRUjiC0ioClx /e93VpAiZoGXTBJXnj9mB0kIC/hJ7Pi+CsxmEVCV2Lb6OJjNC9TQe+cX2CBRAS+JLfvawWxO AVOJ/WduskBsjpfYs7iNGaJeUOLH5HtgcWYBeYl9+6eyQthaEut3HmeawCgwC0nZLCRls5CU LWBkXsUokVqQXFCclJ5rlJdarlecmFtcmpeul5yfu4kRHJPPpHcwHt7lfohRgINRiYf3xrxj EUKsiWXFlbmHGCU4mJVEeB+/OB4hxJuSWFmVWpQfX1Sak1p8iNEU6MGJzFKiyfnAdJFXEm9o Ym5ibmxgYW5paWKkJM7bOPtZuJBAemJJanZqakFqEUwfEwenVAOjNOPyP5PSf5R9ir9R03b7 1O2lXAl5X6XMchJ0DW7dFL2TmtN3es75LEGl/PKt52q+fd6l1yTw+naKZNeJuAjRul5pkfo9 /Fe9mB7+nTxFu7W3/7U4T6vBA1PXPu3WiFuX1t/75bBlst6RxPVG82IFph25IPAvrHdq4Vv1 b/qiZ6prH7ZN+rxRiaU4I9FQi7moOBEABx6Vbd8CAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170314130352epcas5p472cdaa4ae512b4a839d92e85d6dadb81 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170314130352epcas5p472cdaa4ae512b4a839d92e85d6dadb81 X-RootMTR: 20170314130352epcas5p472cdaa4ae512b4a839d92e85d6dadb81 References: <20170311172527.16368-1-krzk@kernel.org> <20170311172527.16368-4-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Saturday, March 11, 2017 07:25:22 PM Krzysztof Kozlowski wrote: > The Exynos4412 has the same watchdog as newer SoCs (e.g. Exynos5250). > Just like the others, for working it requires additional steps in Power > Management Unit: unmasking the reset request and enabling the system > reset. Without these additional steps in PMU, the watchdog will not be > able to reset the system on expiration event. > > Change the compatible of Exynos4412 watchdog device node to > samsung,exynos5250-wdt which includes the additional PMU steps. This is going to confuse people. How's about doing it cleanly (by adding samsung,exynos4412-wdt compatible and convert existing users to use instead)? > This will also fix infinite watchdog interrupt in soft mode (lack of > interrupt clear) because it is also included in samsung,exynos5250-wdt. > > Signed-off-by: Krzysztof Kozlowski Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics