RE: [PATCH v11 2/8] x86/resctrl: Prepare for per-CTRL_MON group mba_MBps control

Luck, Tony
2024-12-09T22:05:46Z

> > diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> > index d94abba1c716..fd05b937e2f4 100644
> > --- a/include/linux/resctrl.h
> > +++ b/include/linux/resctrl.h
> > @@ -49,6 +49,8 @@ enum resctrl_event_id {
> > QOS_L3_MBM_LOCAL_EVENT_ID = 0x03,
> > };
> >
> > +extern enum resctrl_event_id mba_mbps_default_event;
>
> Any reason this extern isn't in
>
> arch/x86/kernel/cpu/resctrl/internal.h

Trying to avoid making more work for the ARM folks as they split resctrl
into "file system" and "architecture specific" bits.

mba_mbps_default_event isn't architecture specific. The mba_MBps
feedback code could be implemented on any architecture that supports
both measurement and control of memory bandwidth.

-Tony