From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v2 1/4] dt-bindings: clock: convert stm32 rcc bindings to json-schema
Date: Tue, 14 Jan 2025 10:28:19 +0100 [thread overview]
Message-ID: <679440a5-5ee2-47a3-9811-3be96cdcf2a2@kernel.org> (raw)
In-Reply-To: <CABGWkvqu10dyW6y5S7qvY4G7uh0OaUgr6k-F7BA1AU0H9bA9GQ@mail.gmail.com>
On 14/01/2025 10:10, Dario Binacchi wrote:
> On Sat, Jan 11, 2025 at 10:25 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Thu, Jan 09, 2025 at 10:18:28PM +0100, Dario Binacchi wrote:
>>> +maintainers:
>>> + - Dario Binacchi <dario.binacchi@amarulasolutions.com>
>>> +
>>> +description: |
>>> + The RCC IP is both a reset and a clock controller.
>>> + The reset phandle argument is the bit number within the RCC registers bank,
>>> + starting from RCC base address.
>>> +
>>> +properties:
>>> + compatible:
>>> + oneOf:
>>> + - items:
>>> + - const: st,stm32f42xx-rcc
>>> + - const: st,stm32-rcc
>>> + - items:
>>> + - enum:
>>> + - st,stm32f469-rcc
>>> + - const: st,stm32f42xx-rcc
>>> + - const: st,stm32-rcc
>>> + - items:
>>> + - const: st,stm32f746-rcc
>>
>> Why this isn't just part of enum with first group/list? Different
>> groups/lists are for different fallbacks and I am pretty sure fallback
>> is the same.
>
> I tried running tests after applying the changes you suggested, but
> the tests are failing.
And? Fix the code then?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-14 9:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 21:18 [PATCH v2 0/4] Support spread spectrum clocking for stm32f{4,7} platforms Dario Binacchi
2025-01-09 21:18 ` [PATCH v2 1/4] dt-bindings: clock: convert stm32 rcc bindings to json-schema Dario Binacchi
2025-01-11 9:25 ` Krzysztof Kozlowski
2025-01-14 9:10 ` Dario Binacchi
2025-01-14 9:28 ` Krzysztof Kozlowski [this message]
2025-01-09 21:18 ` [PATCH v2 2/4] dt-bindings: clock: st,stm32-rcc: support spread spectrum clocking Dario Binacchi
2025-01-11 9:35 ` Krzysztof Kozlowski
2025-01-09 21:18 ` [PATCH v2 3/4] clk: stm32f4: use FIELD helpers to access the PLLCFGR fields Dario Binacchi
2025-01-09 21:18 ` [PATCH v2 4/4] clk: stm32f4: support spread spectrum clock generation Dario Binacchi
2025-01-13 19:12 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=679440a5-5ee2-47a3-9811-3be96cdcf2a2@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox