From: Changwoo Min <changwoo@igalia.com>
To: Andrea Righi <arighi@nvidia.com>
Cc: tj@kernel.org, void@manifault.com, kernel-dev@igalia.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sched_ext: Replace rq_lock() to raw_spin_rq_lock() in scx_ops_bypass()
Date: Wed, 8 Jan 2025 17:46:10 +0900 [thread overview]
Message-ID: <67a26bd1-e7de-40eb-9545-2d8f815c30aa@igalia.com> (raw)
In-Reply-To: <Z346WcFfn6jTckm8@gpd3>
Hello again,
On 25. 1. 8. 17:42, Andrea Righi wrote:
>> This change fixes: 0e7ffff1b811 ("scx: Fix raciness in scx_ops_bypass()")
>
> We should use the `Fixes:` tag, put this right before your SoB line:
>
> Fixes: 0e7ffff1b811 ("scx: Fix raciness in scx_ops_bypass()")
Ah! My bad!
>>
>> Without this change, we observe the following warnings:
>
> Maybe report only the first warning, or even something small like this
> should be sufficient to identify the issue I think:
>
> [ 6.615205] rq->balance_callback && rq->balance_callback != &balance_push_callback
> [ 6.615208] WARNING: CPU: 2 PID: 0 at kernel/sched/sched.h:1730 __schedule+0x1130/0x1c90
Sure. Will fix it.
Regards,
Changwoo Min
prev parent reply other threads:[~2025-01-08 8:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 8:33 [PATCH v2] sched_ext: Replace rq_lock() to raw_spin_rq_lock() in scx_ops_bypass() Changwoo Min
2025-01-08 8:42 ` Andrea Righi
2025-01-08 8:46 ` Changwoo Min [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67a26bd1-e7de-40eb-9545-2d8f815c30aa@igalia.com \
--to=changwoo@igalia.com \
--cc=arighi@nvidia.com \
--cc=kernel-dev@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox