public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: syzbot <syzbot+62dfea789a2cedac1298@syzkaller.appspotmail.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [syzbot] Re: [syzbot] [overlayfs?] general protection fault in clone_private_mount
Date: Thu, 06 Feb 2025 23:02:27 -0800	[thread overview]
Message-ID: <67a5b003.050a0220.2b1e6.0015.GAE@google.com> (raw)
In-Reply-To: <67a4b9e8.050a0220.d6d27.0000.GAE@google.com>

For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org.

***

Subject: Re: [syzbot] [overlayfs?] general protection fault in clone_private_mount
Author: lizhi.xu@windriver.com

#syz test

diff --git a/fs/namespace.c b/fs/namespace.c
index 1314f11ed961..8e2ff3dbab58 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -2421,6 +2421,9 @@ struct vfsmount *clone_private_mount(const struct path *path)
 		if (!check_mnt(old_mnt))
 			return ERR_PTR(-EINVAL);
 	} else {
+		if (!is_mounted(&old_mnt->mnt))
+			return ERR_PTR(-EINVAL);
+
 		/* Make sure this isn't something purely kernel internal. */
 		if (!is_anon_ns(old_mnt->mnt_ns))
 			return ERR_PTR(-EINVAL);

  parent reply	other threads:[~2025-02-07  7:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-06 13:32 [syzbot] [overlayfs?] general protection fault in clone_private_mount syzbot
2025-02-06 15:53 ` Amir Goldstein
2025-02-07  7:02 ` syzbot [this message]
2025-02-07  7:13 ` [PATCH] fs: prevent access to ns if it is not mounted Lizhi Xu
2025-02-07 12:42   ` Amir Goldstein
2025-02-07 12:50     ` Christian Brauner
2025-02-08  7:25 ` [syzbot] [overlayfs?] general protection fault in clone_private_mount syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67a5b003.050a0220.2b1e6.0015.GAE@google.com \
    --to=syzbot+62dfea789a2cedac1298@syzkaller.appspotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox