Re: [syzbot] [ocfs2?] kernel BUG in ocfs2_journal_toggle_dirty

[syzbot <syzbot+ea8d1726e1e3367085ce@syzkaller.appspotmail.com>]

syzbot has found a reproducer for the following issue on:

HEAD commit:    69b54314c975 Merge tag 'kbuild-fixes-v6.14' of git://git.k..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=178742a4580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=1909f2f0d8e641ce
dashboard link: https://syzkaller.appspot.com/bug?extid=ea8d1726e1e3367085ce
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=107a3b18580000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=10d86bdf980000

Downloadable assets:
disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/7feb34a89c2a/non_bootable_disk-69b54314.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/e32e396b49c9/vmlinux-69b54314.xz
kernel image: https://storage.googleapis.com/syzbot-assets/30d7fe7e4148/bzImage-69b54314.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/16cf04118a70/mount_0.gz
  fsck result: OK (log: https://syzkaller.appspot.com/x/fsck.log?x=13586bdf980000)

The issue was bisected to:

commit 98ded54a33839e7b8f8bed772e01a544f48e33a7
Author: Christoph Hellwig <hch@lst.de>
Date:   Wed Mar 30 05:29:10 2022 +0000

    loop: remove the racy bd_inode->i_mapping->nrpages asserts

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=144cf0b0580000
final oops:     https://syzkaller.appspot.com/x/report.txt?x=164cf0b0580000
console output: https://syzkaller.appspot.com/x/log.txt?x=124cf0b0580000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+ea8d1726e1e3367085ce@syzkaller.appspotmail.com
Fixes: 98ded54a3383 ("loop: remove the racy bd_inode->i_mapping->nrpages asserts")

(syz-executor198,5726,0):ocfs2_inode_lock_full_nested:2512 ERROR: status = -30
(syz-executor198,5726,0):ocfs2_shutdown_local_alloc:412 ERROR: status = -30
------------[ cut here ]------------
kernel BUG at fs/ocfs2/journal.c:1012!
Oops: invalid opcode: 0000 [#1] PREEMPT SMP KASAN NOPTI
CPU: 0 UID: 0 PID: 5726 Comm: syz-executor198 Not tainted 6.14.0-rc1-syzkaller-00276-g69b54314c975 #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
RIP: 0010:ocfs2_journal_toggle_dirty+0x397/0x3a0 fs/ocfs2/journal.c:1012
Code: 6f fe e9 f7 fd ff ff 89 d9 80 e1 07 80 c1 03 38 c1 0f 8c 2a fe ff ff 48 89 df e8 d4 68 6f fe e9 1d fe ff ff e8 da cf 08 fe 90 <0f> 0b e8 92 58 3f 08 66 90 90 90 90 90 90 90 90 90 90 90 90 90 90
RSP: 0000:ffffc9000e2fefe0 EFLAGS: 00010293
RAX: ffffffff83b67fc6 RBX: 00000000ffffffff RCX: ffff88801f368000
RDX: 0000000000000000 RSI: 00000000ffffffff RDI: 0000000000000000
RBP: ffffc9000e2ff0b0 R08: ffffffff83b67d30 R09: 1ffffffff285f32a
R10: dffffc0000000000 R11: fffffbfff285f32b R12: dffffc0000000000
R13: ffff88804121a740 R14: ffff8880449e9600 R15: 1ffff92001c5fe04
FS:  00007f04682156c0(0000) GS:ffff88801fc00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f046066b000 CR3: 000000005005a000 CR4: 0000000000352ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 ocfs2_journal_shutdown+0x479/0xc10 fs/ocfs2/journal.c:1094
 ocfs2_mount_volume fs/ocfs2/super.c:1785 [inline]
 ocfs2_fill_super+0x668e/0x7200 fs/ocfs2/super.c:1083
 get_tree_bdev_flags+0x48c/0x5c0 fs/super.c:1636
 vfs_get_tree+0x90/0x2b0 fs/super.c:1814
 do_new_mount+0x2be/0xb40 fs/namespace.c:3560
 do_mount fs/namespace.c:3900 [inline]
 __do_sys_mount fs/namespace.c:4111 [inline]
 __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4088
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f0468a70faa
Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 7e 09 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f0468214f88 EFLAGS: 00000282 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 0000400000004440 RCX: 00007f0468a70faa
RDX: 0000400000004440 RSI: 0000400000000040 RDI: 00007f0468214fe0
RBP: 00007f0468214fe0 R08: 00007f0468215020 R09: 000000000000441b
R10: 00000000000008c0 R11: 0000000000000282 R12: 0000400000000040
R13: 00007f0468215020 R14: 0000000000004421 R15: 0000400000000080
 </TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:ocfs2_journal_toggle_dirty+0x397/0x3a0 fs/ocfs2/journal.c:1012
Code: 6f fe e9 f7 fd ff ff 89 d9 80 e1 07 80 c1 03 38 c1 0f 8c 2a fe ff ff 48 89 df e8 d4 68 6f fe e9 1d fe ff ff e8 da cf 08 fe 90 <0f> 0b e8 92 58 3f 08 66 90 90 90 90 90 90 90 90 90 90 90 90 90 90
RSP: 0000:ffffc9000e2fefe0 EFLAGS: 00010293
RAX: ffffffff83b67fc6 RBX: 00000000ffffffff RCX: ffff88801f368000
RDX: 0000000000000000 RSI: 00000000ffffffff RDI: 0000000000000000
RBP: ffffc9000e2ff0b0 R08: ffffffff83b67d30 R09: 1ffffffff285f32a
R10: dffffc0000000000 R11: fffffbfff285f32b R12: dffffc0000000000
R13: ffff88804121a740 R14: ffff8880449e9600 R15: 1ffff92001c5fe04
FS:  00007f04682156c0(0000) GS:ffff88801fc00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f0460bff000 CR3: 000000005005a000 CR4: 0000000000352ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.