From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07E56EEA8 for ; Sun, 23 Feb 2025 03:47:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740282426; cv=none; b=bIiSFCX92XkN9LvqBQSMiarCIOE/d5bPNETr1Wdl+uHLEZ1XzrCNV92+A1c1diiiTUtyDcb1MszqOmFTQ6WyuVapv0nDUXE4NoL9vopvPjwN8tsoA/jEbDp2requNM65nBvm7zx7iK9dfw8alzKyt2HxOsbefwCi6mF0oIk9D2w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740282426; c=relaxed/simple; bh=2EdI0KCQqF6g/OFk03vtubaIGea39PksXCqOPqLqk4c=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=ugTy5lAtEHCqDpaEKbWW720aTwrb6JbzR/LYy3piEOwhCRP/s5r6yaz3UV39EcAPB3y40WbY4apu8onJC5/QnD1Nn8w6HRyoMV7+LV/BxvrBIF2cRfLDHQ6JkrjaGrfNp9a/yYH3UeAmUyVS89wC3dmL+mXR0Ha1clx5KCfCju4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.166.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-il1-f197.google.com with SMTP id e9e14a558f8ab-3d2ab0fbab2so24316895ab.3 for ; Sat, 22 Feb 2025 19:47:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740282423; x=1740887223; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RTmkIvPw29XEaR2h/FAlLV+AdeSbeFhGWiCSFb8tdoc=; b=xBGX3Irym1JlrzZIr7jkDY5BYnLC90PT7xXqvRpC3QILYeR4xAdJrjTIZduZJGCv70 PjByWnBuo9kE51rAU930UMbCx435nwByTVJRv3XqGy9vvmTZqp+qy+favbgGBSY8hvkI fLSGZk2xdcy16LNNERJCiYAa5VUfE3ejXdn58he/5e6jrGnSm1P7QV+ka6zDH7TGvmZ9 /l3S+DOQql5xazl1o0hHOHvytscUHOpnIudl1BU7fgGItwmhI6vyAgAVtCCktJl+HbAM 4EXGJLRMCTqSLicya6pFV4V6EZT1TOT6QFURmXPajwCRzTZv6Gt2vusCQwnUeZNwZbIw Kb4w== X-Forwarded-Encrypted: i=1; AJvYcCWsW3PQkIr2uM1ZTBrJkufhYbnpZQcUQ14hb2Af98EzfWUgfogeVKaC7CbxSX/j/XTBT41+5n4MhPoocSQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzKzZ+Npzlm3cgKV8jhpLWAgnVt+1QV97YAmCeEOl+Szv4ddSPK hd346z5uNyCLtbsDI1a9NFBCKQZ8vRDBfFgkup1RVTEdfM4ERJ0fnWZk9LrawcgODs57ScY63c3 XKjzqQ65HoHa7X+/wDDWKtRWDZUok/81RIg86iSOb83XqpT8c0EmnWRY= X-Google-Smtp-Source: AGHT+IFd5AjIpJUI5BLR9cdJvhcSulMjU+wJFFcpjjkZqvldaLJDdPVXAwLdvq5WfDrA21+wV8QqAZb1DFNBuJzHc9sE7YXJMrfK Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6e02:2413:b0:3d0:ca2:156d with SMTP id e9e14a558f8ab-3d2caf04813mr87527015ab.14.1740282423044; Sat, 22 Feb 2025 19:47:03 -0800 (PST) Date: Sat, 22 Feb 2025 19:47:03 -0800 In-Reply-To: <20250223025417.2617-1-hdanton@sina.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <67ba9a37.050a0220.bbfd1.000b.GAE@google.com> Subject: Re: [syzbot] [input?] [usb?] KASAN: slab-use-after-free Read in steam_input_open From: syzbot To: hdanton@sina.com, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Hello, syzbot has tested the proposed patch but the reproducer is still triggering an issue: KASAN: slab-use-after-free Read in steam_input_close ================================================================== BUG: KASAN: slab-use-after-free in steam_input_close+0x13b/0x150 drivers/hid/hid-steam.c:621 Read of size 8 at addr ffff888135dc7130 by task acpid/2828 CPU: 0 UID: 0 PID: 2828 Comm: acpid Not tainted 6.14.0-rc3-syzkaller-00293-g5cf80612d3f7-dirty #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120 print_address_description mm/kasan/report.c:408 [inline] print_report+0xc3/0x670 mm/kasan/report.c:521 kasan_report+0xd9/0x110 mm/kasan/report.c:634 steam_input_close+0x13b/0x150 drivers/hid/hid-steam.c:621 input_close_device+0x21f/0x290 drivers/input/input.c:654 evdev_close_device drivers/input/evdev.c:405 [inline] evdev_release+0x350/0x400 drivers/input/evdev.c:447 __fput+0x3ff/0xb70 fs/file_table.c:464 __fput_sync+0xa1/0xc0 fs/file_table.c:550 __do_sys_close fs/open.c:1580 [inline] __se_sys_close fs/open.c:1565 [inline] __x64_sys_close+0x86/0x100 fs/open.c:1565 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f31902de0a8 Code: 48 8b 05 83 9d 0d 00 64 c7 00 16 00 00 00 83 c8 ff 48 83 c4 20 5b c3 64 8b 04 25 18 00 00 00 85 c0 75 20 b8 03 00 00 00 0f 05 <48> 3d 00 f0 ff ff 76 5b 48 8b 15 51 9d 0d 00 f7 d8 64 89 02 48 83 RSP: 002b:00007fff1432be88 EFLAGS: 00000246 ORIG_RAX: 0000000000000003 RAX: ffffffffffffffda RBX: 00007fff1432c118 RCX: 00007f31902de0a8 RDX: 0000000000000000 RSI: 000000000000001e RDI: 000000000000000a RBP: 000000000000000a R08: 0000000000000008 R09: 00007fff1432bff8 R10: 0000000000000000 R11: 0000000000000246 R12: 00007fff1432bff8 R13: 0000000000000040 R14: 00007fff1432c0f8 R15: 00007fff1432bff8 Allocated by task 2803: kasan_save_stack+0x33/0x60 mm/kasan/common.c:47 kasan_save_track+0x14/0x30 mm/kasan/common.c:68 poison_kmalloc_redzone mm/kasan/common.c:377 [inline] __kasan_kmalloc+0x8f/0xa0 mm/kasan/common.c:394 kasan_kmalloc include/linux/kasan.h:260 [inline] __do_kmalloc_node mm/slub.c:4294 [inline] __kmalloc_node_track_caller_noprof+0x20b/0x4c0 mm/slub.c:4313 alloc_dr drivers/base/devres.c:119 [inline] devm_kmalloc+0xa5/0x260 drivers/base/devres.c:843 devm_kzalloc include/linux/device.h:328 [inline] steam_probe+0x132/0x1060 drivers/hid/hid-steam.c:1240 __hid_device_probe drivers/hid/hid-core.c:2713 [inline] hid_device_probe+0x349/0x700 drivers/hid/hid-core.c:2750 call_driver_probe drivers/base/dd.c:579 [inline] really_probe+0x23e/0xa90 drivers/base/dd.c:658 __driver_probe_device+0x1de/0x440 drivers/base/dd.c:800 driver_probe_device+0x4c/0x1b0 drivers/base/dd.c:830 __device_attach_driver+0x1df/0x310 drivers/base/dd.c:958 bus_for_each_drv+0x157/0x1e0 drivers/base/bus.c:462 __device_attach+0x1e8/0x4b0 drivers/base/dd.c:1030 bus_probe_device+0x17f/0x1c0 drivers/base/bus.c:537 device_add+0x114b/0x1a70 drivers/base/core.c:3665 hid_add_device+0x374/0xa60 drivers/hid/hid-core.c:2896 usbhid_probe+0xd32/0x1400 drivers/hid/usbhid/hid-core.c:1431 usb_probe_interface+0x300/0x9c0 drivers/usb/core/driver.c:396 call_driver_probe drivers/base/dd.c:579 [inline] really_probe+0x23e/0xa90 drivers/base/dd.c:658 __driver_probe_device+0x1de/0x440 drivers/base/dd.c:800 driver_probe_device+0x4c/0x1b0 drivers/base/dd.c:830 __device_attach_driver+0x1df/0x310 drivers/base/dd.c:958 bus_for_each_drv+0x157/0x1e0 drivers/base/bus.c:462 __device_attach+0x1e8/0x4b0 drivers/base/dd.c:1030 bus_probe_device+0x17f/0x1c0 drivers/base/bus.c:537 device_add+0x114b/0x1a70 drivers/base/core.c:3665 usb_set_configuration+0x10cb/0x1c50 drivers/usb/core/message.c:2210 usb_generic_driver_probe+0xb1/0x110 drivers/usb/core/generic.c:250 usb_probe_device+0xec/0x3e0 drivers/usb/core/driver.c:291 call_driver_probe drivers/base/dd.c:579 [inline] really_probe+0x23e/0xa90 drivers/base/dd.c:658 __driver_probe_device+0x1de/0x440 drivers/base/dd.c:800 driver_probe_device+0x4c/0x1b0 drivers/base/dd.c:830 __device_attach_driver+0x1df/0x310 drivers/base/dd.c:958 bus_for_each_drv+0x157/0x1e0 drivers/base/bus.c:462 __device_attach+0x1e8/0x4b0 drivers/base/dd.c:1030 bus_probe_device+0x17f/0x1c0 drivers/base/bus.c:537 device_add+0x114b/0x1a70 drivers/base/core.c:3665 usb_new_device+0xd09/0x1a20 drivers/usb/core/hub.c:2663 hub_port_connect drivers/usb/core/hub.c:5533 [inline] hub_port_connect_change drivers/usb/core/hub.c:5673 [inline] port_event drivers/usb/core/hub.c:5833 [inline] hub_event+0x2e58/0x4f40 drivers/usb/core/hub.c:5915 process_one_work+0x9c5/0x1ba0 kernel/workqueue.c:3236 process_scheduled_works kernel/workqueue.c:3317 [inline] worker_thread+0x6c8/0xf00 kernel/workqueue.c:3398 kthread+0x3af/0x750 kernel/kthread.c:464 ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:148 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 Freed by task 2803: kasan_save_stack+0x33/0x60 mm/kasan/common.c:47 kasan_save_track+0x14/0x30 mm/kasan/common.c:68 kasan_save_free_info+0x3b/0x60 mm/kasan/generic.c:576 poison_slab_object mm/kasan/common.c:247 [inline] __kasan_slab_free+0x37/0x50 mm/kasan/common.c:264 kasan_slab_free include/linux/kasan.h:233 [inline] slab_free_hook mm/slub.c:2353 [inline] slab_free mm/slub.c:4609 [inline] kfree+0x294/0x480 mm/slub.c:4757 release_nodes+0x11e/0x240 drivers/base/devres.c:506 devres_release_group+0x1be/0x2a0 drivers/base/devres.c:689 hid_device_remove+0x107/0x260 drivers/hid/hid-core.c:2774 device_remove+0xc8/0x170 drivers/base/dd.c:567 __device_release_driver drivers/base/dd.c:1273 [inline] device_release_driver_internal+0x44a/0x610 drivers/base/dd.c:1296 bus_remove_device+0x22f/0x420 drivers/base/bus.c:579 device_del+0x396/0x9f0 drivers/base/core.c:3854 hid_remove_device drivers/hid/hid-core.c:2953 [inline] hid_destroy_device+0x19c/0x240 drivers/hid/hid-core.c:2975 usbhid_disconnect+0xa0/0xe0 drivers/hid/usbhid/hid-core.c:1458 usb_unbind_interface+0x1e2/0x960 drivers/usb/core/driver.c:458 device_remove drivers/base/dd.c:569 [inline] device_remove+0x122/0x170 drivers/base/dd.c:561 __device_release_driver drivers/base/dd.c:1273 [inline] device_release_driver_internal+0x44a/0x610 drivers/base/dd.c:1296 bus_remove_device+0x22f/0x420 drivers/base/bus.c:579 device_del+0x396/0x9f0 drivers/base/core.c:3854 usb_disable_device+0x36c/0x7f0 drivers/usb/core/message.c:1418 usb_disconnect+0x2e1/0x920 drivers/usb/core/hub.c:2316 hub_port_connect drivers/usb/core/hub.c:5373 [inline] hub_port_connect_change drivers/usb/core/hub.c:5673 [inline] port_event drivers/usb/core/hub.c:5833 [inline] hub_event+0x1bed/0x4f40 drivers/usb/core/hub.c:5915 process_one_work+0x9c5/0x1ba0 kernel/workqueue.c:3236 process_scheduled_works kernel/workqueue.c:3317 [inline] worker_thread+0x6c8/0xf00 kernel/workqueue.c:3398 kthread+0x3af/0x750 kernel/kthread.c:464 ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:148 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 Last potentially related work creation: kasan_save_stack+0x33/0x60 mm/kasan/common.c:47 kasan_record_aux_stack+0x9b/0xb0 mm/kasan/generic.c:548 insert_work+0x36/0x230 kernel/workqueue.c:2183 __queue_work+0x97e/0x1080 kernel/workqueue.c:2339 queue_work_on+0x11a/0x140 kernel/workqueue.c:2390 hid_hw_close+0xaf/0xe0 drivers/hid/hid-core.c:2415 drop_ref+0x186/0x390 drivers/hid/hidraw.c:360 hidraw_release+0x3e6/0x560 drivers/hid/hidraw.c:384 __fput+0x3ff/0xb70 fs/file_table.c:464 task_work_run+0x14e/0x250 kernel/task_work.c:227 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] exit_to_user_mode_loop kernel/entry/common.c:114 [inline] exit_to_user_mode_prepare include/linux/entry-common.h:329 [inline] __syscall_exit_to_user_mode_work kernel/entry/common.c:207 [inline] syscall_exit_to_user_mode+0x24e/0x260 kernel/entry/common.c:218 do_syscall_64+0xda/0x250 arch/x86/entry/common.c:89 entry_SYSCALL_64_after_hwframe+0x77/0x7f Second to last potentially related work creation: kasan_save_stack+0x33/0x60 mm/kasan/common.c:47 kasan_record_aux_stack+0x9b/0xb0 mm/kasan/generic.c:548 insert_work+0x36/0x230 kernel/workqueue.c:2183 __queue_work+0x97e/0x1080 kernel/workqueue.c:2339 queue_work_on+0x11a/0x140 kernel/workqueue.c:2390 queue_work include/linux/workqueue.h:662 [inline] schedule_work include/linux/workqueue.h:723 [inline] steam_client_ll_open+0xab/0xf0 drivers/hid/hid-steam.c:1145 hid_hw_open+0xe2/0x170 drivers/hid/hid-core.c:2392 hidraw_open+0x274/0x7e0 drivers/hid/hidraw.c:308 chrdev_open+0x237/0x6a0 fs/char_dev.c:414 do_dentry_open+0x6cb/0x1390 fs/open.c:956 vfs_open+0x82/0x3f0 fs/open.c:1086 do_open fs/namei.c:3830 [inline] path_openat+0x1e88/0x2d80 fs/namei.c:3989 do_filp_open+0x20c/0x470 fs/namei.c:4016 do_sys_openat2+0x17a/0x1e0 fs/open.c:1428 do_sys_open fs/open.c:1443 [inline] __do_sys_openat fs/open.c:1459 [inline] __se_sys_openat fs/open.c:1454 [inline] __x64_sys_openat+0x175/0x210 fs/open.c:1454 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f The buggy address belongs to the object at ffff888135dc7000 which belongs to the cache kmalloc-1k of size 1024 The buggy address is located 304 bytes inside of freed 1024-byte region [ffff888135dc7000, ffff888135dc7400) The buggy address belongs to the physical page: page: refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x135dc0 head: order:3 mapcount:0 entire_mapcount:0 nr_pages_mapped:0 pincount:0 flags: 0x200000000000040(head|node=0|zone=2) page_type: f5(slab) raw: 0200000000000040 ffff888100041dc0 ffffea000460f200 dead000000000002 raw: 0000000000000000 0000000080100010 00000000f5000000 0000000000000000 head: 0200000000000040 ffff888100041dc0 ffffea000460f200 dead000000000002 head: 0000000000000000 0000000080100010 00000000f5000000 0000000000000000 head: 0200000000000003 ffffea0004d77001 ffffffffffffffff 0000000000000000 head: 0000000000000008 0000000000000000 00000000ffffffff 0000000000000000 page dumped because: kasan: bad access detected page_owner tracks the page as allocated page last allocated via order 3, migratetype Unmovable, gfp_mask 0xd20c0(__GFP_IO|__GFP_FS|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC), pid 3037, tgid 3037 (syz-executor), ts 50506887177, free_ts 0 set_page_owner include/linux/page_owner.h:32 [inline] post_alloc_hook+0x181/0x1b0 mm/page_alloc.c:1551 prep_new_page mm/page_alloc.c:1559 [inline] get_page_from_freelist+0xe76/0x2b90 mm/page_alloc.c:3477 __alloc_frozen_pages_noprof+0x21c/0x2290 mm/page_alloc.c:4739 alloc_pages_mpol+0xe7/0x410 mm/mempolicy.c:2270 alloc_slab_page mm/slub.c:2423 [inline] allocate_slab mm/slub.c:2587 [inline] new_slab+0x23d/0x330 mm/slub.c:2640 ___slab_alloc+0xc41/0x1670 mm/slub.c:3826 __slab_alloc.constprop.0+0x56/0xb0 mm/slub.c:3916 __slab_alloc_node mm/slub.c:3991 [inline] slab_alloc_node mm/slub.c:4152 [inline] __do_kmalloc_node mm/slub.c:4293 [inline] __kmalloc_noprof+0x154/0x4d0 mm/slub.c:4306 kmalloc_noprof include/linux/slab.h:905 [inline] kzalloc_noprof include/linux/slab.h:1037 [inline] ip6t_alloc_initial_table+0x6c/0x7b0 net/ipv6/netfilter/ip6_tables.c:40 ip6table_filter_table_init+0x1c/0xa0 net/ipv6/netfilter/ip6table_filter.c:41 xt_find_table_lock+0x2dc/0x520 net/netfilter/x_tables.c:1260 xt_request_find_table_lock+0x28/0xf0 net/netfilter/x_tables.c:1285 get_info+0x13d/0x490 net/ipv6/netfilter/ip6_tables.c:979 do_ip6t_get_ctl+0x176/0x10b0 net/ipv6/netfilter/ip6_tables.c:1668 nf_getsockopt+0x79/0xe0 net/netfilter/nf_sockopt.c:116 ipv6_getsockopt+0x1f7/0x280 net/ipv6/ipv6_sockglue.c:1493 page_owner free stack trace missing Memory state around the buggy address: ffff888135dc7000: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ffff888135dc7080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb >ffff888135dc7100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ^ ffff888135dc7180: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ffff888135dc7200: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ================================================================== Tested on: commit: 5cf80612 Merge tag 'x86-urgent-2025-02-22' of git://gi.. git tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master console output: https://syzkaller.appspot.com/x/log.txt?x=14d87498580000 kernel config: https://syzkaller.appspot.com/x/.config?x=28127f006c1c31ee dashboard link: https://syzkaller.appspot.com/bug?extid=0154da2d403396b2bd59 compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40 patch: https://syzkaller.appspot.com/x/patch.diff?x=14ea5fdf980000