Re: [syzbot] [netfilter?] KASAN: slab-use-after-free Read in nf_tables_trans_destroy_work (2)

[syzbot <syzbot+5d8c5789c8cb076b2c25@syzkaller.appspotmail.com>]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
WARNING: bad unlock balance in nf_tables_abort

=====================================
WARNING: bad unlock balance detected!
6.14.0-rc5-syzkaller-g7eb172143d55-dirty #0 Not tainted
-------------------------------------
syz.0.20/6539 is trying to release lock (&nft_net->commit_mutex) at:
[<ffffffff898b345d>] nf_tables_module_autoload net/netfilter/nf_tables_api.c:10962 [inline]
[<ffffffff898b345d>] nf_tables_abort+0x29fd/0x3d60 net/netfilter/nf_tables_api.c:11254
but there are no more locks to release!

other info that might help us debug this:
no locks held by syz.0.20/6539.

stack backtrace:
CPU: 3 UID: 0 PID: 6539 Comm: syz.0.20 Not tainted 6.14.0-rc5-syzkaller-g7eb172143d55-dirty #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_unlock_imbalance_bug kernel/locking/lockdep.c:5289 [inline]
 print_unlock_imbalance_bug+0x1aa/0x1f0 kernel/locking/lockdep.c:5263
 __lock_release kernel/locking/lockdep.c:5528 [inline]
 lock_release+0x525/0x6f0 kernel/locking/lockdep.c:5872
 __mutex_unlock_slowpath+0xa3/0x6a0 kernel/locking/mutex.c:891
 nf_tables_module_autoload net/netfilter/nf_tables_api.c:10962 [inline]
 nf_tables_abort+0x29fd/0x3d60 net/netfilter/nf_tables_api.c:11254
 nfnetlink_rcv_batch+0xabb/0x24e0 net/netfilter/nfnetlink.c:568
 nfnetlink_rcv_skb_batch net/netfilter/nfnetlink.c:647 [inline]
 nfnetlink_rcv+0x3c3/0x430 net/netfilter/nfnetlink.c:665
 netlink_unicast_kernel net/netlink/af_netlink.c:1312 [inline]
 netlink_unicast+0x53c/0x7f0 net/netlink/af_netlink.c:1338
 netlink_sendmsg+0x8b8/0xd70 net/netlink/af_netlink.c:1882
 sock_sendmsg_nosec net/socket.c:718 [inline]
 __sock_sendmsg net/socket.c:733 [inline]
 ____sys_sendmsg+0xaaf/0xc90 net/socket.c:2573
 ___sys_sendmsg+0x135/0x1e0 net/socket.c:2627
 __sys_sendmsg+0x16e/0x220 net/socket.c:2659
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f8dd078d169
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f8dd1634038 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f8dd09a5fa0 RCX: 00007f8dd078d169
RDX: 0000000000000000 RSI: 000040000000c2c0 RDI: 0000000000000003
RBP: 00007f8dd080e2a0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f8dd09a5fa0 R15: 00007fff3449f258
 </TASK>


Tested on:

commit:         7eb17214 Linux 6.14-rc5
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1382a464580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=da4b04ae798b7ef6
dashboard link: https://syzkaller.appspot.com/bug?extid=5d8c5789c8cb076b2c25
compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
patch:          https://syzkaller.appspot.com/x/patch.diff?x=125ca464580000