From: Joe Perches <joe@perches.com>
To: Ioana Ciornei <ioana.ciornei@nxp.com>, Andrew Lunn <andrew@lunn.ch>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
Subject: Re: [PATCH] dpaa2-ethsw: move the DPAA2 Ethernet Switch driver out of staging
Date: Sat, 10 Aug 2019 18:03:09 -0700 [thread overview]
Message-ID: <67dd4fe22f197700a7bc3b663a63383ce51346df.camel@perches.com> (raw)
In-Reply-To: <VI1PR0402MB2800FF2E5C4DE24B25E7D843E0D10@VI1PR0402MB2800.eurprd04.prod.outlook.com>
On Sat, 2019-08-10 at 21:45 +0000, Ioana Ciornei wrote:
> On 8/9/19 10:05 PM, Andrew Lunn wrote:
[]
> >> +static int
> >> +ethsw_get_link_ksettings(struct net_device *netdev,
> >> + struct ethtool_link_ksettings *link_ksettings)
> >> +{
> >> + struct ethsw_port_priv *port_priv = netdev_priv(netdev);
> >> + struct dpsw_link_state state = {0};
> >> + int err = 0;
> >> +
> >> + err = dpsw_if_get_link_state(port_priv->ethsw_data->mc_io, 0,
> >> + port_priv->ethsw_data->dpsw_handle,
> >> + port_priv->idx,
> >> + &state);
> >> + if (err) {
> >> + netdev_err(netdev, "ERROR %d getting link state", err);
trivia: Do please add terminating '\n's to all the formats.
next prev parent reply other threads:[~2019-08-11 1:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 15:56 [PATCH] dpaa2-ethsw: move the DPAA2 Ethernet Switch driver out of staging Ioana Ciornei
2019-08-09 19:04 ` Andrew Lunn
2019-08-10 21:45 ` Ioana Ciornei
2019-08-11 1:03 ` Joe Perches [this message]
2019-08-11 3:22 ` Andrew Lunn
2019-08-11 21:20 ` Ioana Ciornei
2019-08-12 14:03 ` Andrew Lunn
2019-08-12 13:57 ` Andrew Lunn
2019-08-13 7:21 ` Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67dd4fe22f197700a7bc3b663a63383ce51346df.camel@perches.com \
--to=joe@perches.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ioana.ciornei@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox